| Summary: | Logout gray fadeaway appears all the time regardless of the kcontrol setting | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Darrell <darrella> |
| Component: | tdebase | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | albator78, bugwatch, darrella, slavek.banko |
| Priority: | P5 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Attachments: |
Patch to add secondary fadeaway control
tdebase : make fancy logout checkbox grayed if fadeaway is disabled Updated patch to add secondary fadeaway control |
||
|
Description
Darrell
2014-03-07 14:26:56 CST
I believe this is in fact the expected behaviour. I think there has always been 2 different fadeaway: the default one, and the "fancy" one. The check box in kcontrol activates the fancy fadeway. If you disable it, then the default fadeaway is used. This one is simpler and faster, so it runs better on older hardware. The problem is that, until 3.5.13.2 , the default fadeaway was broken and did not work, so we had forgotten that it existed. Look at commit 3a84ecae . From my perspective the broken way is the correct way. The folks who want eye candy can have that and those who don't should have that too. This has always been the way of KDE/TDE configurations. I believe the gray fadeaway should not appear at all when the kcontrol option is disabled. In bug 258 I reported that the fadeaway is too slow for older hardware. That argument still applies. I propose the "definition" of "fancy fadeaway" be changed. When the option is enabled the gray fadeaway appears and when disabled the fadeaway does not appear. When bug 258 is completed and full controls are provided, those controls will control the speed and darkness of the fadeaway, but the current check box would control whether or not the fadeaway appears. I suppose somebody will scream if the fadeaway is removed. A new check box could be added:
| | Confirm logout
| | Show logout fadeaway <-NEW OPTION
| | Show fancy logout fadeaway <-Indented as a child check box
Both fadeaway options are disabled when 'Confirm logout' is unchecked.
'Show fancy logout fadeaway' is disabled when 'Show logout fadeaway' is unchecked.
Created attachment 2001 [details] Patch to add secondary fadeaway control The patch seems to work for me, as described in comment 3. There is no indentation but that does not seem important. Still a minor issue with patch: when "Confirm Logout" (1st checkbox) is disabled, closing then reopeing the control panel: "Show Fancy Logout" (3rd checkbox) is not grayed, but it should. I don't know how to fix that. Created attachment 2002 [details]
tdebase : make fancy logout checkbox grayed if fadeaway is disabled
Apply this patch after yours, it should do the trick (works on my computer).
Created attachment 2004 [details]
Updated patch to add secondary fadeaway control
Patch updated by merging attachments 2001 and 2002.
Comment on attachment 2004 [details]
Updated patch to add secondary fadeaway control
Fixed (showLogoutStatusDialog changed to confirmLogoutCheck)
and pushed to GIT in hash 907d8b7d.
Looks good, thank you both. |