| Summary: | New KSplash splash screen for TDE | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Alex Couture <ac586133> |
| Component: | tdeartwork | Assignee: | Michele Calgaro <michele.calgaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | ac586133, bugwatch, darrella, michele.calgaro, slavek.banko |
| Priority: | P5 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | Other | ||
| OS: | Other | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Bug Depends on: | |||
| Bug Blocks: | 2014 | ||
| Attachments: |
The ''Refresh'' KSplash splash screen
A preview of the splash screen Refresh KSplash theme v2 Refresh v3, with centered icons |
||
Created attachment 2012 [details]
A preview of the splash screen
Very good, thanks! I propose we make it the new default splash screen, renaming the current default to TDE-classic or TDE-nostalgia. I have to agree with that! :) -Alexandre Let's wait for other users comments as well, even though the existing splash screen looks a little bit "stale" to me. Pushed to git in commits 77b01cb, eb8c794, 0b4c2f5 (main) and 3c7357c, 5f1492d (packaging, Debian/Ubuntu). Reopened, following Slavek request to change one of the two TDE icons.
---------------------
> Hi E. Liddell,
> please can you as an expert on graphic look at the new splash screen? It does
> not feel good that in the lower right corner is twice logos TDE. What do you
> think? Any idea what to do with it?
> http://bugs.trinitydesktop.org/attachment.cgi?id=2012
Let's extend this request to Alex as well, since he is the author of the original work. Perhaps we can replace the small TDE icon with another one.
-------------------------
Created attachment 2014 [details]
Refresh KSplash theme v2
Thanks Alex, the new icon looks good! as said in the ML, could you move the 7 icons on the bottom a little to the left, so they are centered with the picture? Hi, Sorry but I can't do it. As I wrote in the dev mailing list: I know that the small icons are a little off-center. I needed to do this to avoid a problem with where ksplash cut the pictures to let them blink. At first, a part of the next icons were blinking, because it was a little in the area of the last one, so I can't move it. Not even just a little. Sorry, it's TDE's fault. But if TDE is so efficient, you shouldn't have much time to see a little detail like that :) -Alexandre Ok, I will have a look at it sooner or later. The (x,y) coordinates of the flashing rectangles must be set somewhere in the code or in a configuration file. We can adjust them so that they are centered and then we can shift the icons in the picture. For my own reference, see: file tdebase/ksplashml/themeengine/default/themelegacy.cpp function TQPixmap ThemeDefault::updateBarPixmap( int state ) lines 264-268 This is were the problem is, because different icons have different blinking areas. I will probably look at a fix during the coming week. Yes, that is what I was thinking about. As of my own point of view, the area should be slitted in equal sizes. But, doing so might break the older splash screens using this engine, creating the same trouble as I had when they were well centered. If the problem is fixed, let me know it. It is very easy for me to move the layers of the small icon in my Gimp files. There is also the trouble of the MoodinKDE theme engine who does not resize the background as it should. -Alexandre (In reply to Alex Couture from comment #12) >As of my own point of view, the area should be slitted in equal sizes. >But, doing so might break the older splash screens using this engine, creating >the same trouble as I had when they were well centered My idea is to use fixed size for all icons and adjust the old default style icons to fit. Makes everything more easy. (In reply to Michele Calgaro from comment #13) Alex, can you prepare a set of icons which is centered? I am working on a solution for this problem and when I am done with it, I will need the new centered set so that I can push it to git. To help your design, each icon is allowed 58 pixel in the code. If you need larger or narrower icons, the new solution can handle that, but as much as possible try to keep it to that size. The default set uses icon starting x-coordinate as 0, 58, 116, 172 (+8), 232, 290 and 340 (-8). The +8 and -8 is what is causing the problem: this was a nasty hardcoded hack in the code :-( Created attachment 2015 [details]
Refresh v3, with centered icons
Here it is!
Fixed in commits e861c61 and 278d757. The 'default' theme engine has now an additional "Icon Offsets" option that allows to customize the start x-coordinate of each of the seven icons. The nasty hardcoded hack has been removed and the TDE-Classic's Theme.rc has been updated to work with the new version. The new centered version of the default theme have been pushed as well. Thanks to Alex for the graphic part. Hi, Is there a way to display the user's background while the slash is there? Or maybe to add an option to add the possibility to include a background file with the KSplash theme and to use it? -Alexandre > Is there a way to display the user's background while the slash is there? Does using transparency have any effect on that? Just wondering. > Or maybe to add an option to add the possibility to include a background file > with the KSplash theme and to use it? That could be done, of course. Perhaps after v14.0.0 is released. We could draw a background image first and on top of that another one with transparency. |
Created attachment 2011 [details] The ''Refresh'' KSplash splash screen Hi all! Here is a proposed splash screen for the upcoming R14 release. Or at least a splash screen that could be part of the available splash screen list. It uses the classic splash screen theme engine and features the same background as the MoodinKDE splash screen. It is to be placed in /opt/trinity/share/apps/KSplash/themes Tell me what you think, or how I can improve it! Thank you! -Alexandre