By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 2043

Summary: konqueror arkplugin Compress & Extract options
Product: TDE Reporter: Brian James <bugs-tde>
Component: tdeaddonsAssignee: Michele Calgaro <michele.calgaro>
Status: RESOLVED FIXED    
Severity: normal CC: be4youcome, bugwatch, michele.calgaro
Priority: P5    
Version: R14.0.0 [Trinity]   
Hardware: All   
OS: Linux   
Compiler Version: TDE Version String:
Application Version: Application Name:
Bug Depends on:    
Bug Blocks: 2696    

Description Brian James 2014-05-02 04:26:56 CDT
In konqueror file-manager, right click on folder or file | Compress | Compress As

Bugs
----

1] i) Blank before *.tar.lzma option
   ii) Compress As *.tar.xz/*.tar.lzma options compress with file extensions .txz/.tlz
   iii) Compress As 'blank' compresses with file extension .tar.lzma

2] i) Compress As *.xz & *.lzma options are duplicated
   ii) Right click on any *.xz/*.tar.lzma/*.tlz file and the Compress option shows
        -> should be Extract option


Reasons
-------

1] arkplugin.cpp has an entry for
                   m_extractMimeTypes << "application/x-tbz2";

   but application/x-tbz2 doesn't exist. The MimeType for dealing with *.tar.bz2 & *.tbz2 patterns is application/x-tbz

2] In arkplugin.cpp, under ArkMenu::extMimeTypes(), lzma and xz have m_archiveMimeTypes
    -> should be m_extractMimeTypes


Solution
--------

Apply patch:

--- tdeaddons/konq-plugins/arkplugin/arkplugin.cpp	2014-04-03 09:33:15.000000000 +0000
+++ arkplugin-new.cpp	2014-05-01 21:31:52.000000000 +0000
@@ -304,10 +304,7 @@
         if ( havegz )
             m_archiveMimeTypes << "application/x-tgz";
         if ( havebz2 )
-        {
             m_archiveMimeTypes << "application/x-tbz";
-            m_archiveMimeTypes << "application/x-tbz2";
-        }
         if ( havelzop )
             m_archiveMimeTypes << "application/x-tzo";
         if ( havelzma )
@@ -379,14 +376,14 @@
     if ( !TDEStandardDirs::findExe( "lzma" ).isNull() )
     {
         havelzma = true;
-        m_archiveMimeTypes << "application/x-lzma";
+        m_extractMimeTypes << "application/x-lzma";
     }
 
     bool havexz = false;
     if ( !TDEStandardDirs::findExe( "xz" ).isNull() )
     {
         havexz = true;
-        m_archiveMimeTypes << "application/x-xz";
+        m_extractMimeTypes << "application/x-xz";
     }
 
     if ( !TDEStandardDirs::findExe( "tar" ).isNull() )
@@ -395,14 +392,11 @@
         if ( havegz )
             m_extractMimeTypes << "application/x-tgz";
         if ( havebz2 )
-        {
             m_extractMimeTypes << "application/x-tbz";
-            m_extractMimeTypes << "application/x-tbz2";
-        }
         if ( havelzop )
             m_extractMimeTypes << "application/x-tzo";
         if ( havelzma )
-            m_extractMimeTypes << "application/x-lzma";
+            m_extractMimeTypes << "application/x-tlz";
         if ( havexz )
             m_extractMimeTypes << "application/x-txz";
     }
Comment 1 Michele Calgaro 2016-10-02 01:51:14 CDT
Confirmed. Some entries are duplicated and some do not match exactly the presented string
Comment 2 Michele Calgaro 2017-11-25 04:19:03 CST
The following commits have removed the non-existent application/x-tbz2 mimetype.
The patch from Brian James has also been pushed.

dolphin 5354953 (R14.1.x) and a44b641 (R14.0.x)
tdeutils 96765e0 (R14.1.x) and e2a62bd (R14.0.x)
tdeaddons 33b03b1 (R14.1.x) and 8621eda (R14.0.x)

I am not closing the bug yet because I want to verify if there is any other issue that needs to be fixed with the Konqueror ark plugin menu. But first I need a full TDE rebuild...
Comment 3 Michele Calgaro 2017-11-26 01:34:25 CST
Menu entry adjusted with commit dbd30d1 (R14.1.x) and 4fe8d8d (R14.0.x)