By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 2077

Summary: Docbook catalogs in SGML causes FTBFS
Product: TDE Reporter: Slávek Banko <slavek.banko>
Component: tdelibsAssignee: Slávek Banko <slavek.banko>
Status: RESOLVED FIXED    
Severity: major CC: albator78, bugwatch, michele.calgaro, slavek.banko
Priority: P5    
Version: R14.0.0 [Trinity]   
Hardware: All   
OS: Linux   
Compiler Version: TDE Version String:
Application Version: Application Name:
Attachments: tdelibs : Switch docbook catalogs to xml
tdelibs : Switch docbook catalogs to xml (1)
Add docbook xml catalogs in tdelibs on Debian and Ubuntu
tdelibs : Switch docbook catalogs to xml (2)
tdelibs: fix el, fi, ko catalog.xml

Description Slávek Banko 2014-07-20 09:16:39 CDT
Created attachment 2097 [details]
tdelibs : Switch docbook catalogs to xml

During the last build filelight on Debian 8 (Jessie), I came across a serious problem with Docbook - catalogs in SGML format is no longer supported.

So I prepared a XML version of catalogs. Please, before I'll push the patch, test it on other distributions.
Comment 1 Slávek Banko 2014-07-20 10:05:01 CDT
Created attachment 2098 [details]
tdelibs : Switch docbook catalogs to xml (1)
Comment 2 Slávek Banko 2014-07-21 02:39:20 CDT
Created attachment 2099 [details]
Add docbook xml catalogs in tdelibs on Debian and Ubuntu

For completeness, I also attach a patch for tde-packaking.
Comment 3 Slávek Banko 2014-07-21 11:42:20 CDT
As I have now traced, the change is probably associated with updating libxml2 to libxml2 2.9.1+dfsg1-4:

https://packages.qa.debian.org/libx/libxml2.html
Comment 4 Slávek Banko 2014-07-24 13:05:46 CDT
I looked through the patches, which are incorporated in the updated Debian package, one interested me, I tried to revert it and got it!

https://git.gnome.org/browse/libxml2/commit/?id=054c716e

This commit causes: if enabled XML catalogs are supported >>exclusively<< XML catalogs. The question is whether this is a bug or intention?
Comment 5 Slávek Banko 2014-07-24 13:46:32 CDT
Created attachment 2100 [details]
tdelibs : Switch docbook catalogs to xml (2)

Cleanup patch:
+ fixed a few not closed tags
+ catalogs are passed using variable XML_CATALOG_FILES instead of SGML_CATALOG_FILES
Comment 6 Michele Calgaro 2014-07-25 08:51:16 CDT
Slavek,
I took a look at the patches and the solution is quite elegant.
I built tdelibs and tdebase without errors and see no problems with the handbooks.

Whether the change in libxml2 was intentional or not I don't know, but I think you can push the patches to GIT so that we don't need to worry about that.

Well done!
Comment 7 Slávek Banko 2014-07-25 18:21:15 CDT
Comment on attachment 2100 [details]
tdelibs : Switch docbook catalogs to xml (2)

Pushed to GIT in hash 1bb6f88d.
Comment 8 Slávek Banko 2014-07-25 18:21:54 CDT
Comment on attachment 2099 [details]
Add docbook xml catalogs in tdelibs on Debian and Ubuntu

Pushed to GIT in hash 5dfe8ce1.
Comment 9 Slávek Banko 2014-07-25 18:28:05 CDT
Patches pushed, rebuild tdelibs packages is now underway...
Comment 10 Francois Andriot 2014-09-17 11:44:36 CDT
Created attachment 2248 [details]
tdelibs: fix el, fi, ko catalog.xml

There are a few errors in the "el", "fi" and "ko" files "catalog.xml", which cause koffice-i18n FTBFS.
Basically, on some lines, the attribute "uri=" is missing.
The attached patches fixes the XML files.
Comment 11 Slávek Banko 2014-09-17 17:33:09 CDT
Comment on attachment 2248 [details]
tdelibs: fix el, fi, ko catalog.xml

Pushed to GIT in hash 2824570e.
Thank you!