Bug 2105

I just realized I can set K3B to use /tmp/tde-{username} , however I will leave this bug open since the default should be changed to the correct path.

(In reply to Kristopher from comment #1)
> I just realized I can set K3B to use /tmp/tde-{username} , however I will
> leave this bug open since the default should be changed to the correct path.

This might have been a result of the upgrade from 3.5.13.x to R14, as the k3b configuration file would likely have retained the old kde- temp directory name.  Can you see if this bug exists in your clean (non-upgraded) R14 VM?

Thanks!

Tim

(In reply to Timothy Pearson from comment #2)
> (In reply to Kristopher from comment #1)
> > I just realized I can set K3B to use /tmp/tde-{username} , however I will
> > leave this bug open since the default should be changed to the correct path.
> 
> This might have been a result of the upgrade from 3.5.13.x to R14, as the
> k3b configuration file would likely have retained the old kde- temp
> directory name.  Can you see if this bug exists in your clean (non-upgraded)
> R14 VM?
> 
> Thanks!
> 
> Tim

No need for testing this in a VM (I've copied my settings anyways for testing another bug, I forget which): I switched to a dummy user I have set up, and under that user K3B uses the correct /tmp/tde-{username} .

If this is as a result of upgrading from 3.5.x, I'd suggest adding a check to the R14 version TDE applications that use the old /tmp/kde-{username} to see if that needs updating. That will save a lot of confusion for non-advanced users when R14 becomes stable.

(In reply to Kristopher from comment #3)
> (In reply to Timothy Pearson from comment #2)
> > (In reply to Kristopher from comment #1)
> > > I just realized I can set K3B to use /tmp/tde-{username} , however I will
> > > leave this bug open since the default should be changed to the correct path.
> > 
> > This might have been a result of the upgrade from 3.5.13.x to R14, as the
> > k3b configuration file would likely have retained the old kde- temp
> > directory name.  Can you see if this bug exists in your clean (non-upgraded)
> > R14 VM?
> > 
> > Thanks!
> > 
> > Tim
> 
> No need for testing this in a VM (I've copied my settings anyways for
> testing another bug, I forget which): I switched to a dummy user I have set
> up, and under that user K3B uses the correct /tmp/tde-{username} .
> 
> If this is as a result of upgrading from 3.5.x, I'd suggest adding a check
> to the R14 version TDE applications that use the old /tmp/kde-{username} to
> see if that needs updating. That will save a lot of confusion for
> non-advanced users when R14 becomes stable.

Thanks for the info.  It seems then that the R14 upgrade script isn't properly upgrading the k3b files so I'm going to add Darrell and Slavek to the CC list.  Can one of you please fix the R14 upgrade script to handle this case?

Thanks!

Created attachment 2391 [details]
tdebase: update r14-xdg-update: update references to temp folders

Update references for /tmp/kde-*, /tmp/ksocket-* and /var/tmp/kdecache-*.

Tim is already too late to push this patch into R14.0.0?

(In reply to Slávek Banko from comment #5)
> Created attachment 2391 [details]
> tdebase: update r14-xdg-update: update references to temp folders
> 
> Update references for /tmp/kde-*, /tmp/ksocket-* and /var/tmp/kdecache-*.
> 
> Tim is already too late to push this patch into R14.0.0?

Go ahead and push now; I didn't have time to update the TDE version code or tag R14 so this one patch can go in.

The patch is hard-coded to look in /tmp. In the situation where $TMP is defined in user's environment, the temporary files will not be stored in /tmp but in $TMP.

Rather than hard-code for /tmp, use the variables defined at lines 278-280?

CACHE_DIR="`readlink $PROFILE_DIR/cache-\`uname -n\``"
SOCKET_DIR="`readlink $PROFILE_DIR/socket-\`uname -n\``"
TMP_DIR="`readlink $PROFILE_DIR/tmp-\`uname -n\``"

(In reply to Darrell from comment #7)
> The patch is hard-coded to look in /tmp. In the situation where $TMP is
> defined in user's environment, the temporary files will not be stored in
> /tmp but in $TMP.
> 
> Rather than hard-code for /tmp, use the variables defined at lines 278-280?
> 
> CACHE_DIR="`readlink $PROFILE_DIR/cache-\`uname -n\``"
> SOCKET_DIR="`readlink $PROFILE_DIR/socket-\`uname -n\``"
> TMP_DIR="`readlink $PROFILE_DIR/tmp-\`uname -n\``"

I'll leave the merge window for this specific bug open until 12/09/2014 06:00 GMT to allow time to "get it right".

Tim

Created attachment 2393 [details]
tdebase: update r14-xdg-update: update references to temp folders (1)

Well, I modified the patch.
Please verify before I push it.

Created attachment 2394 [details]
tdebase: update r14-xdg-update: update references to temp folders (2)

Forget the previous variant of the patch! First, the directories may be deleted in the previous step. In addition, variables may contain original folder names. Now is from the variables used only path to parent directory.

Comment on attachment 2394 [details]
tdebase: update r14-xdg-update: update references to temp folders (2)

Well, no comments, and time is running out. Therefore, I pushed the patch.