| Summary: | Build issue: Arts on openbsd | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Francois Andriot <albator78> |
| Component: | non-core programs | Assignee: | Francois Andriot <albator78> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | albator78, bugwatch, slavek.banko |
| Priority: | P5 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | All | ||
| OS: | Other | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Attachments: |
Arts: fix hardcoded link flag to "dl" library
cmake: fix openbsd library naming convention Arts: add sndio support (part 1) + fix "dl" library detection Arts: add sndio support (part 2) Arts: add sndio support (part 3) Arts: add sndio support (part 4) |
||
|
Description
Francois Andriot
2014-09-06 09:06:47 CDT
Created attachment 2150 [details]
Arts: fix hardcoded link flag to "dl" library
Created attachment 2151 [details]
cmake: fix openbsd library naming convention
This patch is not specific to Arts. It is common to all TDE packages.
Created attachment 2152 [details]
Arts: add sndio support (part 1) + fix "dl" library detection
Created attachment 2153 [details]
Arts: add sndio support (part 2)
Created attachment 2154 [details]
Arts: add sndio support (part 3)
Created attachment 2155 [details]
Arts: add sndio support (part 4)
The "sndio" is the audio subsystem for openbsd.
Patches look good. For me no objections. François, you're ready to have any additional patches for admin and cmake common modules? (In reply to Slávek Banko from comment #7) > Patches look good. For me no objections. > > François, you're ready to have any additional patches for admin and cmake > common modules? No, this is the only cmake/admin patch that I have now. Comment on attachment 2151 [details]
cmake: fix openbsd library naming convention
Pushed to GIT in hash 38a8a335.
Comment on attachment 2150 [details]
Arts: fix hardcoded link flag to "dl" library
Pushed to GIT in hash c73ca85a.
Openbsd sndio support pushed in GIT hash d6fd5da5. Slavek, currently the cmake step fails in openbsd because the check_function_exists( dlopen HAVE_DLOPEN ) was put BEFORE the include( CheckFunctionExists ) Either move the check_function_exits() down or move the include up... (In reply to Francois Andriot from comment #12) > Slavek, currently the cmake step fails in openbsd because the > check_function_exists( dlopen HAVE_DLOPEN ) was put BEFORE the include( > CheckFunctionExists ) > > Either move the check_function_exits() down or move the include up... Thank you for heads up. All includes was moved to top of the CMakeLists.txt in GIT hash e39b3d2d. |