|
Description
Francois Andriot
2014-09-06 09:17:42 CDT
Created attachment 2156 [details]
tdelibs: add tdehwlib option, fix libdl detection, fix other header detections
Under openbsd, there are some problem with the cmake function "check_include_file".
The following headers are impacted:
net/if.h
sys/mount.h
sys/ucred.h
Same problem with "check_function_exists" for "alloca".
The cmake sample program that is used to test the availability of these headers generates a FTBFS either because of undeclared type in source code (e.g: "size_t is undefined"), or problem at linking (e.g. missing library)
It looks like MANY openbsd system header files actually require "#include <stdlib.h>", but this line is not present in the header...
Created attachment 2157 [details]
tdelibs: enable previously disabled build option in config.h
Created attachment 2158 [details]
tdelibs: enable conditional build of tdehwlib (part 1) + fix ftbfs because missing link to "util" library
Created attachment 2159 [details]
tdelibs: enable conditional build of tdehwlib (part 2)
Created attachment 2160 [details]
tdelibs: enable conditional build of tdehwlib (part 3)
Created attachment 2161 [details]
tdelibs: enable conditional build of tdehwlib (part 4)
Created attachment 2162 [details]
tdelibs: enable conditional build of tdehwlib (part 5)
Created attachment 2163 [details]
tdelibs: add support for openbsd pty in kpty
I'm not sure this patch actually works or is correct.
It is based on a kdelibs3 patch from openbsd.
Created attachment 2164 [details]
tdelibs: add support for openbsd in kresolver (1/2)
Patch from kdelibs3 on openbsd.
Created attachment 2165 [details]
tdelibs: add support for openbsd in kresolver (2/2)
Created attachment 2166 [details]
tdelibs: fix FTBFS because Linux specific include in tdeapplication.cpp
Created attachment 2167 [details]
tdelibs: add 'tdesu' to tdeioslave_file mount/umount command
openbsd has no support for HAL nor TDEHWLIB.
The only way to handle removable drives is direct mount/umount command.
These command can only work as root user, so tdesu is needed here.
(patch from kdelibs3 openbsd)
Created attachment 2168 [details]
tdelibs: fix security issue in tdeioslave_ftp
Patch from kdelibs3 openbsd.
Created attachment 2169 [details]
tdelibs: fix FTBFS because undefined __progname in tdeio_connection
Created attachment 2170 [details]
tdelibs: disable environment-based completion in kurlcompletion
Under openbsd, there is no such thing as "extern char **environ".
So the environment-related code would need to be modified here ...
Created attachment 2171 [details]
tdelibs: fix cupsd process detection
There is no "/proc" filesystem under openbsd. We detect running processes by using it.
(patch from kdelibs3 openbsd)
Created attachment 2172 [details]
tdelibs: fix cups default directories
Under openbsd, most programs are installed under "/usr/local" instead of just "/usr".
Many path, including cups, must be modified accordingly.
(patch from kdelibs3 openbsd)
Created attachment 2173 [details]
tdelibs: fix FTBFS because hardcoded link to "dl" library
Created attachment 2174 [details]
tdelibs: fix tdesu process handling
patch from kdelibs3 openbsd.
Not sure, but it is probably a security fix.
Created attachment 2175 [details]
tdelibs: fix default spell checker in openbsd
openbsd use aspell only, not ispell. Use aspell by default.
(patch from kdelibs3 openbsd)
Comment on attachment 2173 [details]
tdelibs: fix FTBFS because hardcoded link to "dl" library
With part from attachmen 2156 pushed to GIT in hash af2c2afb.
Comment on attachment 2163 [details]
tdelibs: add support for openbsd pty in kpty
Pushed to GIT in hash e61585ed.
Comment on attachment 2164 [details]
tdelibs: add support for openbsd in kresolver (1/2)
Pushed to GIT in hash 439f3ba7.
Comment on attachment 2165 [details]
tdelibs: add support for openbsd in kresolver (2/2)
Pushed to GIT in hash 439f3ba7.
Comment on attachment 2166 [details]
tdelibs: fix FTBFS because Linux specific include in tdeapplication.cpp
Pushed to GIT in hash 8f3cf10d.
Comment on attachment 2167 [details]
tdelibs: add 'tdesu' to tdeioslave_file mount/umount command
Pushed to GIT in hash b588c6e6.
Comment on attachment 2169 [details]
tdelibs: fix FTBFS because undefined __progname in tdeio_connection
Pushed to GIT in hash 9c7a8637.
Comment on attachment 2170 [details]
tdelibs: disable environment-based completion in kurlcompletion
Pushed to GIT in hash 78a66b11.
Comment on attachment 2171 [details]
tdelibs: fix cupsd process detection
Pushed to GIT in hash 754647ba.
Comment on attachment 2172 [details]
tdelibs: fix cups default directories
Pushed to GIT in hash 69e7a5c4.
Comment on attachment 2175 [details]
tdelibs: fix default spell checker in openbsd
Pushed to GIT in hash cca50763.
Created attachment 2285 [details]
Enable condition build of tdehwlib
I believe that to enable / disable tdehwlib is not sufficient to use the build option. All programs that use kinstance.h would have properly set WITH_TDEHWLIB during build. And that's not good.
I have therefore prepared a solution where the value is written to kdemacros.h, and everything then uses the definition __TDE_HAVE_TDEHWLIB.
Please test it.
Comment on attachment 2285 [details]
Enable condition build of tdehwlib
Patch works as expected on OpenBSD.
Created attachment 2287 [details]
tdelibs: fix openpty detection on openbsd
Another library detection issue:
under openbsd, there is no "pty.h" file, but the "openpty" function is defined in "util.h" .
This patch allows detection of "openpty" function in both files.
Comment on attachment 2157 [details]
tdelibs: enable previously disabled build option in config.h
Pushed to GIT in hash 223f0c75
Comment on attachment 2287 [details]
tdelibs: fix openpty detection on openbsd
Pushed to GIT in hash e255a8ca
Comment on attachment 2285 [details]
Enable condition build of tdehwlib
Pushed to GIT in hash 84e3f9e0
Created attachment 2293 [details]
tdelibs: fix ucred support in openbsd
Created attachment 2294 [details]
tdelibs: fix linking to Xext library
This patch adds a cmake detection for Xext library.
Add missing link flag in tdeui.
Remove hardcoded Xext flags in tderandr and tdestyles/keramik.
Comment on attachment 2293 [details]
tdelibs: fix ucred support in openbsd
Pushed to GIT in hash 3adf509a.
Comment on attachment 2294 [details]
tdelibs: fix linking to Xext library
Pushed to GIT in hash aae8990d.
Comment on attachment 2168 [details]
tdelibs: fix security issue in tdeioslave_ftp
Rejected - is already applied on 3.5.10 sources.
Comment on attachment 2174 [details]
tdelibs: fix tdesu process handling
Pushed to GIT in hash c8b810f1.
All patches are now committed. Therefore now I closed this bug report. If you will have any more patches, please reopen it. |