|
Description
Francois Andriot
2014-09-06 10:36:37 CDT
Created attachment 2176 [details]
tdebase: enable shadow related build flags in config.h
Created attachment 2177 [details]
tdebase: enable libdl detection in configurechecks.cmake
Created attachment 2178 [details]
tdebase: enable building drkonqui without tdehwlib
Created attachment 2179 [details]
tdebase: fix kate externatools command syntax
It looks like there is a missing space separator in the command.
(patch from kdebase3 openbsd)
Created attachment 2180 [details]
tdebase: fix time saving in kcontrol clock module
Patch from kdebase3 openbsd.
Created attachment 2181 [details]
tdebase: enable conditionnal tdehwlib build in kcontrol
Created attachment 2182 [details]
tdebase: fix potential segmentation fault in kcontrol info module
patch from kdebase3 openbsd.
Created attachment 2183 [details]
tdebase: fix process pid detection in tdefontinst
Created attachment 2184 [details]
tdebase: fix default halt command in tdm
There is no "poweroff" option in openbsd.
Created attachment 2185 [details]
tdebase: fix FTBFS due to hardcoded link flag to "dl" library in kdesktop
Created attachment 2186 [details]
tdebase: fix FTBFS due to linux specific header in kdesktop_lock
Created attachment 2187 [details]
tdebase: fix openbsd process detection in kicker applet naughtyprocessmonitor
Created attachment 2188 [details]
tdebase: fix build kickoff menu without tdehwlib and without hal
Created attachment 2189 [details]
tdebase: fix FTBFS due to hardcoded link flag to "dl" library in konsole
Created attachment 2190 [details]
tdebase: enable building ksmserver without tdehwlib (part 1)
Created attachment 2191 [details]
tdebase: enable building ksmserver without tdehwlib (part 2)
Created attachment 2192 [details]
tdebase: enable building ksmserver without tdehwlib (part 3)
Created attachment 2193 [details]
tdebase: enable building ksmserver without tdehwlib (part 4)
Created attachment 2194 [details]
tdebase: add more processes to watch in ksysguard process management
Created attachment 2195 [details]
tdebase: enable ksysguard build for openbsd
Created attachment 2196 [details]
tdebase: enable openbsd process management in ksysguard (part 1)
Created attachment 2197 [details]
tdebase: enable openbsd process management in ksysguard (part 2)
Created attachment 2198 [details]
tdebase: enhance openbsd memory management in ksysguard (part 1)
Created attachment 2199 [details]
tdebase: enhance openbsd memory management in ksysguard (part 2)
Created attachment 2200 [details]
tdebase: enable openbsd process management in ksysguard (part 3)
Created attachment 2201 [details]
tdebase: enable openbsd process management in ksysguard (part 4)
Created attachment 2202 [details]
tdebase: fix FTBFS due to hardcoded link flag to "dl" library in nsplugins_viewer
Created attachment 2203 [details]
tdebase: workaround sasl header detection in tdeioslave
Created attachment 2204 [details]
tdebase: add perl function support in tdeioslave_man
patch from kdebase3 openbsd
Created attachment 2205 [details]
tdebase: enable building tdeioslave_media without tdehwlib (part 1)
Created attachment 2206 [details]
tdebase: fix FTBFS in tdeioslave_media because of invalid headers
Created attachment 2207 [details]
tdebase: enable building tdeioslave_media without tdehwlib (part 2)
Created attachment 2208 [details]
tdebase: enable building tdeioslave_media without tdehwlib (part 3)
Created attachment 2209 [details]
tdebase: fix FTBFS in tdeioslave_media because of missing header
Created attachment 2210 [details]
tdebase: fix FTBFS because missing link directory in tdeioslave_nfs
Created attachment 2211 [details]
tdebase: fix FTBFS in tdeioslave_smtp because missing headers
Created attachment 2212 [details]
tdebase: fix FTBFS in tdesu because missing header
Created attachment 2213 [details]
tdebase: fix tdm auth backend for openbsd
Created attachment 2214 [details]
tdebase: fix FTBFS in tdm backend because linux specific header
Created attachment 2215 [details]
tdebase: fix tdm backend fd support
Created attachment 2216 [details]
tdebase: fix tdm cmake variables
Created attachment 2217 [details]
tdebase: enable building tdm without tdehwlib (part 1)
Created attachment 2218 [details]
tdebase: enable building tdm without tdehwlib (part 2)
Created attachment 2219 [details]
tdebase: fix conditionnal utmpx support in tdm
Created attachment 2220 [details]
tdebase: fix FTBFS because conflicting declaration in twin compton
Created attachment 2221 [details]
tdebase: fix FTBFS because missing header in twin utils
Created attachment 2229 [details]
tdebase: fix conditionnal utmpx support in tdm + fix tdm_greet crash
I've noticed that tdm_greet crashes on openbsd . There are several reasons:
1) the parent directory of FIFO_DIR is not created correctly, because the mkdir line 1303 is creating FIFO_DIR itself, not the parent directory of FIFO_DIR.
Then the 2nd mkdir at line 1318 fails because missing parent folder, then the socket is never created.
The simple fix is at line 1300.
2) systematic crash at line 1305: free(fifo_parent_dir);
I do not understand why a free() should be needed here, maybe old code that was not removed.
3) when /tmp/tdesocket-global/tdm (FIFO_DIR) is set to permissions 0600, then the tdm_greet crashes (segfault) at command FD_SET(mPipe_fd, &rfds);
Settng the FIFO_DIR permissions to 0700 avoids the crash. I'm not sure why ...
Please, can you push at least the patches related to not having tdehwlib ? It is required to build on both *BSD and older Linux (like CentOS 5). Thanks (In reply to Francois Andriot from comment #48) > Please, can you push at least the patches related to not having tdehwlib ? > It is required to build on both *BSD and older Linux (like CentOS 5). > > Thanks Currently I'm processing patch for PIE from bug 2133. Patches from this bug report I have already downloaded and will be processed after completion cmake PIE patch. (In reply to Francois Andriot from comment #35) > Created attachment 2210 [details] > tdebase: fix FTBFS because missing link directory in tdeioslave_nfs Please, can be used ${CMAKE_CURRENT_SOURCE_DIR} instead of proposed ${CMAKE_SOURCE_DIR}/tdeioslave/nfs ? Created attachment 2307 [details]
tdebase: fix FTBFS because missing link directory in tdeioslave_nfs (2)
Yes, it works as you suggest.
Created attachment 2309 [details]
tdebase: fix conditionnal utmpx support in tdm + fix tdm_greet crash (2)
Memory for fifo_parent_dir is allocated by strdup, but your proposed patch removes corresponding free. At the same time, I believe that 0700 folder creation is OK for all systems.
Please look at the corrected patch.
Comment on attachment 2176 [details]
tdebase: enable shadow related build flags in config.h
Pushed to GIT in hash 56c4daef.
Comment on attachment 2177 [details]
tdebase: enable libdl detection in configurechecks.cmake
Pushed to GIT in hash bfbcf19a.
Comment on attachment 2185 [details]
tdebase: fix FTBFS due to hardcoded link flag to "dl" library in kdesktop
Pushed to GIT as part of hash bfbcf19a.
Comment on attachment 2189 [details]
tdebase: fix FTBFS due to hardcoded link flag to "dl" library in konsole
Pushed to GIT as part of hash bfbcf19a.
Comment on attachment 2202 [details]
tdebase: fix FTBFS due to hardcoded link flag to "dl" library in nsplugins_viewer
Pushed to GIT as part of hash bfbcf19a.
Comment on attachment 2179 [details]
tdebase: fix kate externatools command syntax
Pushed to GIT in hash 1389b139.
Comment on attachment 2307 [details]
tdebase: fix FTBFS because missing link directory in tdeioslave_nfs (2)
Pushed to GIT in hash d4436877.
Comment on attachment 2211 [details]
tdebase: fix FTBFS in tdeioslave_smtp because missing headers
Pushed to GIT in hash e12a6ff6.
Comment on attachment 2221 [details]
tdebase: fix FTBFS because missing header in twin utils
Pushed to GIT in hash 01d5f3ea.
(In reply to Slávek Banko from comment #52) > Created attachment 2309 [details] > tdebase: fix conditionnal utmpx support in tdm + fix tdm_greet crash (2) > > Memory for fifo_parent_dir is allocated by strdup, but your proposed patch > removes corresponding free. At the same time, I believe that 0700 folder > creation is OK for all systems. > > Please look at the corrected patch. This patch builds OK but I will test it later. (I'm on tdemultimedia now) (In reply to Francois Andriot from comment #11) > Created attachment 2186 [details] > tdebase: fix FTBFS due to linux specific header in kdesktop_lock It looks like this patch contains a type. #ifdef __linux__ should be entirely lowercase, not having an uppercase "L", which now causes FTBFS on Linux. (In reply to Francois Andriot from comment #63) > (In reply to Francois Andriot from comment #11) > > Created attachment 2186 [details] > > tdebase: fix FTBFS due to linux specific header in kdesktop_lock > > It looks like this patch contains a type. > > #ifdef __linux__ should be entirely lowercase, not having an uppercase "L", > which now causes FTBFS on Linux. Well, that's what happens when a bona fide first push and then tested :) Fixed in commit 68cfc4fe. Comment on attachment 2180 [details]
tdebase: fix time saving in kcontrol clock module
Pushed to GIT in hash 9a75b749.
Comment on attachment 2182 [details]
tdebase: fix potential segmentation fault in kcontrol info module
Pushed to GIT in hash 180cd2fc.
Comment on attachment 2183 [details]
tdebase: fix process pid detection in tdefontinst
Pushed to GIT in hash a501cd74.
Comment on attachment 2184 [details]
tdebase: fix default halt command in tdm
Pushed to GIT in hash 3cc6437a.
Comment on attachment 2187 [details]
tdebase: fix openbsd process detection in kicker applet naughtyprocessmonitor
Pushed to GIT in hash 54a7c726.
Comment on attachment 2194 [details]
tdebase: add more processes to watch in ksysguard process management
Pushed to GIT in hash f19d2da9.
Comment on attachment 2186 [details]
tdebase: fix FTBFS due to linux specific header in kdesktop_lock
Pushed to GIT as part of commit d3ce4fa7.
Comment on attachment 2214 [details]
tdebase: fix FTBFS in tdm backend because linux specific header
Pushed to GIT as part of commit d3ce4fa7.
Comment on attachment 2195 [details]
tdebase: enable ksysguard build for openbsd
Pushed to GIT as part of commit 3abdbba6.
Comment on attachment 2197 [details]
tdebase: enable openbsd process management in ksysguard (part 2)
Pushed to GIT as part of commit 3abdbba6.
Comment on attachment 2196 [details]
tdebase: enable openbsd process management in ksysguard (part 1)
Pushed to GIT as part of commit ffb5336b.
Comment on attachment 2200 [details]
tdebase: enable openbsd process management in ksysguard (part 3)
Pushed to GIT as part of commit ffb5336b.
Comment on attachment 2201 [details]
tdebase: enable openbsd process management in ksysguard (part 4)
Pushed to GIT as part of commit ffb5336b.
Comment on attachment 2198 [details]
tdebase: enhance openbsd memory management in ksysguard (part 1)
Pushed to GIT as part of commit 794af5ed.
Comment on attachment 2199 [details]
tdebase: enhance openbsd memory management in ksysguard (part 2)
Pushed to GIT as part of commit 794af5ed.
Created attachment 2323 [details]
tdebase: fix tdm cmake variables
François, I noticed that CRYPT_LIBRARY is tested and set at two different locations - kcheckpass/ConfigureChecks.cmake and tdm/ConfigureChecks.cmake. It seems to me strange. So I moved test and setting to a common place - ConfigureChecks.cmake in tdebase root folder.
Please, can you test it?
Created attachment 2324 [details]
tdebase: allow contitional build with tdehwlib
I modified all patches for allow conditional build with tdehwlib to use a value __TDE_HAVE_TDEHWLIB defined in kdemacros.h. Also added CMake test to verify whether it is possible to build with option WITH_TDEHWLIB.
Please, can you test it?
Created attachment 2325 [details]
tdebase: fix FTBFS because invalid include in kickoff menu
Created attachment 2326 [details]
tdebase: fix FTBFS because 'abs' function in kcontrol/displayconfig
Still not tested attachment 2309 [details].
I have applied your 2 latest patches 2323 and 2324 , and they are OK for me.
Now I have other FTBFS that I need to investigate.
Created attachment 2327 [details]
tdebase: fix tdm backend fd support (2)
Oh, I see, I apologize, patches from attachment 2325 [details] and attachment 2327 [details] I still have in my queue, because I am divided original patches to OpenBSD part and tdehwlib part. That was the reason why OpenBSD part here was missing. Thank you for adding patches again to this bug report. Now everything is back in order? OK now it builds on openbsd. I have no more patches yet. (In reply to Francois Andriot from comment #87) > OK now it builds on openbsd. I have no more patches yet. Please, can I state at your patches? Signed-off-by: François Andriot <francois.andriot@free.fr> Yes you can add the signed-off and push the patches. Comment on attachment 2203 [details]
tdebase: workaround sasl header detection in tdeioslave
Pushed to GIT in hash b4c4c466.
Comment on attachment 2204 [details]
tdebase: add perl function support in tdeioslave_man
Pushed to GIT in hash e22eb72f.
Comment on attachment 2206 [details]
tdebase: fix FTBFS in tdeioslave_media because of invalid headers
Pushed to GIT in hash 46a0c294.
Comment on attachment 2209 [details]
tdebase: fix FTBFS in tdeioslave_media because of missing header
Pushed to GIT in hash 0f2ad672.
Comment on attachment 2212 [details]
tdebase: fix FTBFS in tdesu because missing header
Pushed to GIT in hash 7d4e2581.
Comment on attachment 2213 [details]
tdebase: fix tdm auth backend for openbsd
Pushed to GIT in hash 18b81de3.
Comment on attachment 2327 [details]
tdebase: fix tdm backend fd support (2)
Pushed to GIT in hash a679541f.
Comment on attachment 2323 [details]
tdebase: fix tdm cmake variables
Pushed to GIT in hash 71fb8e0e.
Comment on attachment 2309 [details]
tdebase: fix conditionnal utmpx support in tdm + fix tdm_greet crash (2)
Pushed to GIT in hash 1651fcb5 and d246c7d9.
Comment on attachment 2325 [details]
tdebase: fix FTBFS because invalid include in kickoff menu
Pushed to GIT in hash 6382ec3f.
Comment on attachment 2220 [details]
tdebase: fix FTBFS because conflicting declaration in twin compton
Pushed to GIT in hash a6d7fd77.
Comment on attachment 2324 [details]
tdebase: allow contitional build with tdehwlib
Pushed to GIT in hash 10722069.
Comment on attachment 2326 [details]
tdebase: fix FTBFS because 'abs' function in kcontrol/displayconfig
Pushed to GIT in hash 44654c9a.
All patches are now committed. Therefore now I closed this bug report. If you will have any more patches, please reopen it. Everything works except the "crypt" detection now.
I don't know how it could work previously.
I have strange behaviour in cmake in "configurechecks.cmake".
# crypt
set( CRYPT_LIBRARY crypt )
check_library_exists( ${CRYPT_LIBRARY} crypt "" HAVE_CRYPT )
if( NOT HAVE_CRYPT )
unset( CRYPT_LIBRARY )
check_function_exists( crypt LIBC_HAVE_CRYPT )
if( LIBC_HAVE_CRYPT )
set( HAVE_CRYPT 1 CACHE INTERNAL "" FORCE )
endif( LIBC_HAVE_CRYPT )
endif( NOT HAVE_CRYPT )
Under openbsd there is no "/usr/lib/libcrypt.so", so I get HAVE_CRYPT=false .
BUT, at build time, I still have CRYPT_LIBRARY="crypt" , then I get FTBFS in tdm/backend because ld cannot find "-lcrypt".
This is the 2nd case I have in openbsd/cmake (I have a similar problem in tqtinterface) . I wonder if it is correct to set a variable at top level, then unset it inside a "if( )" statement ... It looks like the unset is not taken into account.
Anyway, it looks like in openbsd, there is a '/usr/lib/libcrypto.so' which can be used instead of 'libcrypt.so' . So I need to try further anyway.
Never mind, I had a time difference between my openbsd VM and my repository server. This time difference caused several strange errors during the build. I've enabled time synchronization and now it builds correctly. |