| Summary: | Build issue: rpmlint gives several warnings at build time | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Francois Andriot <albator78> |
| Component: | non-core programs | Assignee: | Francois Andriot <albator78> |
| Status: | NEEDINFO --- | ||
| Severity: | normal | CC: | albator78, bugwatch, michele.calgaro, slavek.banko |
| Priority: | P5 | ||
| Version: | R14.0.x [Trinity] | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Attachments: |
tdelibs: fix return in keramik isFormWidget
tqtinterface: add missing shebang in bash script tdebase: fix rpmlint errors tdelibs: build setuid binaries with PIE options tdebase: build setuid binaries with PIE options cmake : build setuid binaries with PIE flags tdenetwork : Fix FTBFS due to CMake PIE detection |
||
|
Description
Francois Andriot
2014-09-29 11:29:03 CDT
tqtinterface: the missing "shebang" is easy to fix. [ 169s] trinity-tqtinterface.i586: W: script-without-shebang /usr/bin/convert_qt_tqt1 [ 169s] This text file has executable bits set or is located in a path dedicated for [ 169s] executables, but lacks a shebang and cannot thus be executed. If the file is [ 169s] meant to be an executable script, add the shebang, otherwise remove the [ 169s] executable bits or move the file elsewhere. [ 169s] [ 169s] trinity-tqtinterface.i586: W: no-manual-page-for-binary moc-tqt [ 169s] trinity-tqtinterface.i586: W: no-manual-page-for-binary dcopidlng-tqt [ 169s] trinity-tqtinterface.i586: W: no-manual-page-for-binary tqt-replace-stream [ 169s] trinity-tqtinterface.i586: W: no-manual-page-for-binary convert_qt_tqt1 [ 169s] trinity-tqtinterface.i586: W: no-manual-page-for-binary convert_qt_tqt2 [ 169s] trinity-tqtinterface.i586: W: no-manual-page-for-binary convert_qt_tqt3 [ 169s] trinity-tqtinterface.i586: W: no-manual-page-for-binary dcopidl2cpp-tqt [ 169s] trinity-tqtinterface.i586: W: no-manual-page-for-binary uic-tqt [ 169s] trinity-tqtinterface.i586: W: no-manual-page-for-binary tmoc [ 169s] trinity-tqtinterface.i586: W: no-manual-page-for-binary dcopidl-tqt [ 169s] trinity-tqtinterface.i586: W: no-manual-page-for-binary tqt-replace [ 169s] trinity-tqtinterface.i586: W: no-manual-page-for-binary mcopidl-tqt [ 169s] Each executable in standard binary directories should have a man page. Created attachment 2279 [details]
tdelibs: fix return in keramik isFormWidget
TDELIBS gives the following output:
[ 1109s] I: Program is likely to break with new gcc. Try -fno-strict-aliasing.
[ 1109s] W: trinity-tdelibs strict-aliasing-punning /home/abuild/rpmbuild/BUILD/trinity-tdelibs-14.0.0/libtdemid/deviceman.cc:547, 560, 579, 601, 622
[ 1109s] W: trinity-tdelibs strict-aliasing-punning /home/abuild/rpmbuild/BUILD/trinity-tdelibs-14.0.0/libtdemid/fmout.cc:121, 235, 237, 238, 243, 280, 290, 302, 316
[ 1109s] W: trinity-tdelibs strict-aliasing-punning /home/abuild/rpmbuild/BUILD/trinity-tdelibs-14.0.0/libtdemid/gusout.cc:200, 234, 236, 237, 241, 276, 298, 312, 407
[ 1109s] W: trinity-tdelibs strict-aliasing-punning /home/abuild/rpmbuild/BUILD/trinity-tdelibs-14.0.0/libtdemid/midiout.cc:81
[ 1109s] W: trinity-tdelibs strict-aliasing-punning /home/abuild/rpmbuild/BUILD/trinity-tdelibs-14.0.0/libtdemid/synthout.cc:167, 173, 180, 191
[ 1109s] W: trinity-tdelibs strict-aliasing-punning /home/abuild/rpmbuild/BUILD/trinity-tdelibs-14.0.0/tdecore/kcrash.cpp:304
[ 1109s] W: trinity-tdelibs strict-aliasing-punning /home/abuild/rpmbuild/BUILD/trinity-tdelibs-14.0.0/tdecore/kmdcodec.cpp:1288, 1289
[ 1109s] W: trinity-tdelibs strict-aliasing-punning /home/abuild/rpmbuild/BUILD/trinity-tdelibs-14.0.0/tdeioslave/iso/kiso.cpp:252, 308, 309, 315
[ 1109s]
[ 1109s] I: Program returns random data in a function
[ 1109s] E: trinity-tdelibs no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/trinity-tdelibs-14.0.0/tdestyles/keramik/keramik.cpp:1380
Attached patch fixes the return error.
Created attachment 2280 [details]
tqtinterface: add missing shebang in bash script
Comment on attachment 2280 [details]
tqtinterface: add missing shebang in bash script
Pushed to GIT in hash b79cc765.
Comment on attachment 2279 [details]
tdelibs: fix return in keramik isFormWidget
Pushed to GIT in hash 5b38cb97.
Partial report for tdelibs. Warning about weird-sized icons: [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/22x22/mimetypes/database.png expected: 22x22 actual: 22x25 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/128x128/mimetypes/presentation.png expected: 128x128 actual: 128x143 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/32x32/actions/music_eightnote.png expected: 32x32 actual: 20x32 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/32x32/actions/music_dottednote.png expected: 32x32 actual: 24x32 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/16x16/actions/compfile.png expected: 16x16 actual: 22x22 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/22x22/actions/music_quarternote.png expected: 22x22 actual: 14x22 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/32x32/mimetypes/database.png expected: 32x32 actual: 32x36 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/32x32/actions/music_quarternote.png expected: 32x32 actual: 20x32 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/128x128/mimetypes/drawing.png expected: 128x128 actual: 128x143 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/64x64/mimetypes/database.png expected: 64x64 actual: 64x72 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/128x128/mimetypes/database.png expected: 128x128 actual: 127x142 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/22x22/actions/music_fermatenote.png expected: 22x22 actual: 14x22 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/48x48/mimetypes/presentation.png expected: 48x48 actual: 48x54 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/16x16/actions/inline_image.png expected: 16x16 actual: 19x18 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/16x16/actions/inline_table.png expected: 16x16 actual: 19x18 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/22x22/actions/music_32ndnote.png expected: 22x22 actual: 14x22 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/64x64/mimetypes/rtf.png expected: 64x64 actual: 64x72 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/16x16/actions/trinity.png expected: 16x16 actual: 16x240 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/48x48/actions/trinity.png expected: 48x48 actual: 48x720 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/64x64/mimetypes/presentation.png expected: 64x64 actual: 64x72 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/22x22/actions/music_sixteenthnote.png expected: 22x22 actual: 14x22 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/64x64/mimetypes/drawing.png expected: 64x64 actual: 64x72 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/32x32/actions/music_fullnote.png expected: 32x32 actual: 20x32 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/48x48/mimetypes/database.png expected: 48x48 actual: 48x54 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/16x16/actions/music_dottednote.png expected: 16x16 actual: 8x15 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/32x32/mimetypes/rtf.png expected: 32x32 actual: 32x36 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/128x128/mimetypes/rtf.png expected: 128x128 actual: 128x143 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/32x32/actions/music_natur.png expected: 32x32 actual: 20x32 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/22x22/mimetypes/presentation.png expected: 22x22 actual: 22x25 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/64x64/places/file_broken.png expected: 64x64 actual: 128x128 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/22x22/actions/music_cleficon.png expected: 22x22 actual: 18x22 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/32x32/actions/music_fermatenote.png expected: 32x32 actual: 14x22 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/128x128/mimetypes/koffice.png expected: 128x128 actual: 116x128 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/16x16/actions/music_natur.png expected: 16x16 actual: 8x15 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/22x22/mimetypes/drawing.png expected: 22x22 actual: 22x25 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/32x32/actions/music_cross.png expected: 32x32 actual: 14x32 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/48x48/mimetypes/drawing.png expected: 48x48 actual: 48x54 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/32x32/actions/music_32ndnote.png expected: 32x32 actual: 20x32 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/32x32/actions/music_cleficon.png expected: 32x32 actual: 26x32 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/22x22/actions/music_natur.png expected: 22x22 actual: 14x22 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/22x22/actions/music_eightnote.png expected: 22x22 actual: 14x22 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/22x22/actions/trinity.png expected: 22x22 actual: 22x330 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/22x22/actions/music_fullnote.png expected: 22x22 actual: 14x22 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/22x22/actions/music_flat.png expected: 22x22 actual: 14x22 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/48x48/mimetypes/koffice.png expected: 48x48 actual: 43x48 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/64x64/mimetypes/koffice.png expected: 64x64 actual: 58x64 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/32x32/actions/music_halfnote.png expected: 32x32 actual: 20x32 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/48x48/mimetypes/rtf.png expected: 48x48 actual: 48x54 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/22x22/mimetypes/rtf.png expected: 22x22 actual: 22x25 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/16x16/actions/music_cross.png expected: 16x16 actual: 8x15 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/16x16/actions/make_tdevelop.png expected: 16x16 actual: 22x22 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/22x22/actions/music_halfnote.png expected: 22x22 actual: 14x22 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/16x16/actions/music_flat.png expected: 16x16 actual: 8x15 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/32x32/actions/music_flat.png expected: 32x32 actual: 20x32 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/32x32/mimetypes/drawing.png expected: 32x32 actual: 32x36 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/16x16/actions/music_cleficon.png expected: 16x16 actual: 13x16 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/22x22/actions/music_cross.png expected: 22x22 actual: 14x22 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/32x32/mimetypes/presentation.png expected: 32x32 actual: 32x36 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/32x32/actions/trinity.png expected: 32x32 actual: 32x480 [ 1899s] trinity-tdelibs.i586: W: wrong-icon-size /opt/trinity/share/icons/crystalsvg/32x32/actions/music_sixteenthnote.png expected: 32x32 actual: 20x32 [ 1899s] Your icon file is installed in a fixed-size directory, but has a largely [ 1899s] incorrect size. Some desktop environments (e.g. GNOME) display them [ 1899s] incorrectly. Warning about shared libraries calling 'exit' (?) [ 1899s] trinity-tdelibs.i586: W: shared-lib-calls-exit /opt/trinity/lib/libtdeinit_tdelauncher.so exit@GLIBC_2.0 [ 1899s] trinity-tdelibs.i586: W: shared-lib-calls-exit /opt/trinity/lib/libtdeprint.so.14.0.0 exit@GLIBC_2.0 [ 1899s] trinity-tdelibs.i586: W: shared-lib-calls-exit /opt/trinity/lib/libDCOP.so.14.0.0 exit@GLIBC_2.0 [ 1899s] trinity-tdelibs.i586: W: shared-lib-calls-exit /opt/trinity/lib/libtdeinit_kded.so exit@GLIBC_2.0 [ 1899s] trinity-tdelibs.i586: W: shared-lib-calls-exit /opt/trinity/lib/libtdescreensaver.so.14.0.0 exit@GLIBC_2.0 [ 1899s] trinity-tdelibs.i586: W: shared-lib-calls-exit /opt/trinity/lib/libtdeunittest.so.1.0.0 exit@GLIBC_2.0 [ 1899s] trinity-tdelibs.i586: W: shared-lib-calls-exit /opt/trinity/lib/libtdeio.so.14.0.0 exit@GLIBC_2.0 [ 1899s] This library package calls exit() or _exit(), probably in a non-fork() [ 1899s] context. Doing so from a library is strongly discouraged - when a library [ 1899s] function calls exit(), it prevents the calling program from handling the [ 1899s] error, reporting it to the user, closing files properly, and cleaning up any [ 1899s] state that the program has. It is preferred for the library to return an [ 1899s] actual error code and let the calling program decide how to handle the [ 1899s] situation. 4 programs are setuid: [ 1899s] trinity-tdelibs.i586: E: permissions-file-setuid-bit (Badness: 10000) /opt/trinity/bin/start_tdeinit is packaged with setuid/setgid bits (04711) [ 1899s] trinity-tdelibs.i586: E: permissions-file-setuid-bit (Badness: 10000) /opt/trinity/bin/fileshareset is packaged with setuid/setgid bits (04711) [ 1899s] trinity-tdelibs.i586: E: permissions-file-setuid-bit (Badness: 10000) /opt/trinity/bin/kpac_dhcp_helper is packaged with setuid/setgid bits (04711) [ 1899s] trinity-tdelibs.i586: E: permissions-file-setuid-bit (Badness: 10000) /opt/trinity/bin/kgrantpty is packaged with setuid/setgid bits (04711) [ 1899s] If the package is intended for inclusion in any SUSE product please open a bug [ 1899s] report to request review of the program by the security team The same setuid programs are expected to be "position independant" (???) See 'tdecore/CMakeLists.txt' and 'admin/acinclude.m4.in' [ 1899s] trinity-tdelibs.i586: E: non-position-independent-executable (Badness: 10000) /opt/trinity/bin/start_tdeinit [ 1899s] trinity-tdelibs.i586: E: non-position-independent-executable (Badness: 10000) /opt/trinity/bin/fileshareset [ 1899s] trinity-tdelibs.i586: E: non-position-independent-executable (Badness: 10000) /opt/trinity/bin/kpac_dhcp_helper [ 1899s] trinity-tdelibs.i586: E: non-position-independent-executable (Badness: 10000) /opt/trinity/bin/kgrantpty [ 1899s] This executable must be position independent. Check that it is built with [ 1899s] -fPIE/-fpie in compiler flags and -pie in linker flags. Missing semicolons in 'tderesources.desktop': [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "Qt;TDE;X-TDE-settings-components;" for key "Categories" in group "Desktop Entry" contains an unregistered value "TDE"; values extending the format should start with "X-" [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop (will be fatal in the future): value "Qt;TDE;X-TDE-settings-components;" for key "Categories" in group "Desktop Entry" does not contain a registered main category [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "TDE;" for key "OnlyShowIn" in group "Desktop Entry" contains an unregistered value "TDE"; values extending the format should start with "X-" [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "resources,konnector resource,contact resource,calendar resource,notes resource,imap" for locale string list key "Keywords" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "hulpbronne,konnector hulpbron,kontak hulpbron,kalender hulpbron, notas hulpbron, imap" for locale string list key "Keywords[af]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "???????,????????,????????,???????,resources,konnector resource,contact resource,calendar resource,notes resource,imap" for locale string list key "Keywords[be]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "??????, ???????, ?????????, ???????, ???????, ????????, ?????, ????????, resources, konnector resource, contact resource, calendar resource, notes resource, imap" for locale string list key "Keywords[bg]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "resources,konnector resource,contact resource,calendar resource,notes resource,imap,resursi,konektor resurs,kontakt resurs,kalendar resurs,bilje?ke resurs" for locale string list key "Keywords[bs]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "recursos,recurs konnector,recurs de contacte,recurs de calendari,recurs de notes,imap" for locale string list key "Keywords[ca]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "zdroje,konektor,kontakty,kalend??,pozn?mky,IMAP" for locale string list key "Keywords[cs]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "dost?nczi,konnector, dost?nczi kal?dz?rza,dost?nczi wizutnych bilet?w, dos??nczi notownika,imap" for locale string list key "Keywords[csb]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "ressourcer,konnector ressource,kontakt resource,kalender ressource,noter ressource,imap" for locale string list key "Keywords[da]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "Ressourcen,Kontakt-Ressource,Kalender-Ressource,Notizen-Ressource,IMAP" for locale string list key "Keywords[de]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "?????,????? ??? konnector,????? ??????,????? ???????????,????? ??????????,imap" for locale string list key "Keywords[el]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "risurcoj,kontakrisurco,kalendarrisurco,notrisuroco" for locale string list key "Keywords[eo]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "recursos, recurso konnector, recurso de contacto, recurso de calendario, recurso de notas, konnector, contacto, calendario, notas, imap" for locale string list key "Keywords[es]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "ressursid,konnectori ressurss,kontakti ressurss,kalendri ressurss,sedelite ressurss,imap" for locale string list key "Keywords[et]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "baliabideak,konnector baliabidea,contact baliabidea,egutegi baliabidea,oharren baliabidea,imap" for locale string list key "Keywords[eu]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "?????? ???? konnector? ???? ????? ???? ?????? ???? ?????????? imap" for locale string list key "Keywords[fa]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "resurssit,konnektor-resurssi,yhteystietojen resurssi,muistiinpanojen resurssi,imap" for locale string list key "Keywords[fi]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "resources,konnector,contact,calendrier,notes,imap,agenda,rendez-vous" for locale string list key "Keywords[fr]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "helpboarne,ferbinings-helpboarne,kontakt-helpboarne,kalinder-helpboarne,notysje-helpboarne,imap,kontakt,kalinder,notysje,ferbining" for locale string list key "Keywords[fy]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "acmhainn?,acmhainn konnector,acmhainn teagmh?la,acmhainn fh?ilire,acmhainn n?ta?,imap" for locale string list key "Keywords[ga]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "recursos,recurso konnector,recurso contactos,recurso axenda,recurso notas ,recurso imap" for locale string list key "Keywords[gl]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "??????, konnector, ??? ???, ?????, imap, ???, esources, resource,contact resource,calendar resource,notes resource" for locale string list key "Keywords[he]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "??????????,??????? ???????,????????? ???????,??????? ???????,????? ???????,?????" for locale string list key "Keywords[hi]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "resursi,konnector resurs,contact resurs,calendar resurs,notes resurs,imap" for locale string list key "Keywords[hr]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "er?forr?sok,csatol?-er?forr?s,n?vjegy-er?forr?s,napt?r-er?forr?s,feljegyz?s-er?forr?s,IMAP" for locale string list key "Keywords[hu]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "risorse,risorsa konnector,risorsa contatti, risorsa calendario,risorsa note,imap" for locale string list key "Keywords[it]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "????,konnector resource, ?????????,?????????,?????????, ???????,imap" for locale string list key "Keywords[ja]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "?????????,???????? ?????????,?????????? ?????????,????????? ?????????,?????????? ?????????,imap" for locale string list key "Keywords[ka]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "?????, ????? konnector, ????????????????, ??????????????, ???????????,imap" for locale string list key "Keywords[km]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "Ressourcen,Konnector-Ressource,Kontakt-Ressource,Kalenner-Ressource,Notizen-Ressource,imap" for locale string list key "Keywords[lb]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "resursai,konnector resursas,kontakt? resursas,kalendoriaus resursas,priminim? resursas,imap" for locale string list key "Keywords[lt]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "sumber, sumber konnector, sumber hubungan, sumber kalendar, sumber nota,imap" for locale string list key "Keywords[ms]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "ressurser,konnector-ressurs,kontaktressurs,kalenderressurs, notatressurs,imap" for locale string list key "Keywords[nb]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "Ressourcen,konnector-Ressource,Kontakt-Ressource,Kalenner-Ressource,Notiz-Ressource,IMAP" for locale string list key "Keywords[nds]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "??????, ????????? ??????, ??????? ??????, ?????? ??????, ????? ??????, ?? ?????" for locale string list key "Keywords[ne]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "gegevensbron,verbindingsgegevensbron,contact-gegevensbron,kalender-gegevensbron,notities-gegevensbron,imap,contact,kalender,notitie,verbinding" for locale string list key "Keywords[nl]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "ressursar,konnector-ressurs,kontaktressurs,kalenderressurs,notatressurs,imap" for locale string list key "Keywords[nn]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "zasoby,konnector,zasoby wizyt?wek,zasoby kalendarzy,zasoby notatek,?r?d?a danych wizyt?wek,?r?d?a danych kalendarzy,?r?d?a danych notatek,imap" for locale string list key "Keywords[pl]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "recursos,recurso de conector,recurso de contacto,recurso de calend?rio,recurso de notas,imap" for locale string list key "Keywords[pt]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "fontes de dados,konnector,contato,conector,calend?rio, notas,imap" for locale string list key "Keywords[pt_BR]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "resurse,konnector,contact,calendar,noti?e,imap" for locale string list key "Keywords[ro]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "ibikorana, ibikorana impuza, ibikorana aderesi, ibikorana kalindari, ibikorana impugukirwa, imap" for locale string list key "Keywords[rw]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "resurssat,konnector-resursa,oktavuohtaresursa,kaleandarresursa,nohtaresursa,imap" for locale string list key "Keywords[se]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "zdroje,zdroj pre konnector,zdroj kontaktov,zdroj kalend?ra,zdroj pozn?mok,imap" for locale string list key "Keywords[sk]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "resurs,vir,stikov vir,koledarski vir,imap," for locale string list key "Keywords[sl]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "resources,konnector resource,contact resource,calendar resource,notes resource,imap,???????,??????,?????????,??????? ??????, ??????????? ??????" for locale string list key "Keywords[sr]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "resources,konnector resource,contact resource,calendar resource,notes resource,imap,resursi,resurs,poveziva?,kontakt resurs, kalendarski resurs" for locale string list key "Keywords[sr@Latn]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "resurser,konnector-resurs,kontaktresurs,kalenderresurs,anteckningsresurs,IMAP" for locale string list key "Keywords[sv]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "????????,??????? ?????,??????? ?????,?????????? ?????,??????????? ?????e,imap" for locale string list key "Keywords[ta]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "??????,?????????? ????,?????????? ????, ??????? ????, ?????? ????, ?????" for locale string list key "Keywords[te]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "kaynaklar,ba?lant? kayna??,iletii?m kayna??,takvim kaynak,not kayna??,imap" for locale string list key "Keywords[tr]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "???????,?????? ??? konnector,?????? ?????????,?????? ?????????,?????? ????????,imap" for locale string list key "Keywords[uk]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "t?i nguy?n,t?i nguy?n konnector,t?i nguy?n li?n l?c,t?i nguy?n l?ch,t?i nguy?n ghi ch?,imap" for locale string list key "Keywords[vi]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] trinity-tdelibs.i586: W: invalid-desktopfile /opt/trinity/share/applications/tde/tderesources.desktop value "resources,konnector resource,contact resource,calendar resource,notes resource,imap??,konnector ??,?????,????,????" for locale string list key "Keywords[zh_CN]" in group "Desktop Entry" does not have a semicolon (';') as trailing character [ 1899s] .desktop file is not valid, check with desktop-file-validate Warning about programs and libraries calling 'gethostbyname': [ 1899s] trinity-tdelibs.i586: I: binary-or-shlib-calls-gethostbyname /opt/trinity/lib/trinity/kded_proxyscout.so [ 1899s] trinity-tdelibs.i586: I: binary-or-shlib-calls-gethostbyname /opt/trinity/lib/libtdeinit_dcopserver.so [ 1899s] trinity-tdelibs.i586: I: binary-or-shlib-calls-gethostbyname /opt/trinity/bin/kpac_dhcp_helper [ 1899s] trinity-tdelibs.i586: I: binary-or-shlib-calls-gethostbyname /opt/trinity/lib/libDCOP.so.14.0.0 [ 1899s] The binary calls gethostbyname(). Please port the code to use getaddrinfo(). rpmlint partial report for tdebase: [ 1375s] I: Program is using implicit definitions of functions getting [ 1375s] pointers or implemented by macros. These functions need to use their [ 1375s] correct prototypes to allow correct argument passing on e.g. x86_64 . [ 1375s] - Implicit memory/string functions need #include <string.h>. [ 1375s] - Implicit *printf functions need #include <stdio.h>. [ 1375s] - Implicit *printf functions need #include <stdio.h>. [ 1375s] - Implicit *read* functions need #include <unistd.h>. [ 1375s] - Implicit *recv* functions need #include <sys/socket.h>. [ 1375s] W: trinity-tdebase implicit-pointer-decl /home/abuild/rpmbuild/BUILD/trinity-tdebase-14.0.0/ksysguard/ksysguardd/Linux/diskstat.c:166 [ 1375s] W: trinity-tdebase implicit-pointer-decl /home/abuild/rpmbuild/BUILD/trinity-tdebase-14.0.0/ksysguard/ksysguardd/Linux/netdev.c:296 [ 1375s] W: trinity-tdebase implicit-pointer-decl /home/abuild/rpmbuild/BUILD/trinity-tdebase-14.0.0/ksysguard/ksysguardd/Linux/netstat.c:122 [ 1375s] W: trinity-tdebase implicit-pointer-decl /home/abuild/rpmbuild/BUILD/trinity-tdebase-14.0.0/tdm/backend/ctrl.c:120, 594 [ 1375s] [ 1375s] I: Function call needs to pass NULL-pointer as last argument [ 1375s] E: trinity-tdebase missing-sentinel /home/abuild/rpmbuild/BUILD/trinity-tdebase-14.0.0/ksysguard/gui/kpm.c:7 [ 1375s] [ 1375s] I: Program returns random data in a function [ 1375s] E: trinity-tdebase no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/trinity-tdebase-14.0.0/kcontrol/background/KCrossBGRender.cc:224 [ 1375s] E: trinity-tdebase no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/trinity-tdebase-14.0.0/kcontrol/iccconfig/iccconfig.cpp:268 [ 1375s] [ 1375s] I: Program returns random data in a function [ 1375s] E: trinity-tdebase no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/trinity-tdebase-14.0.0/kcontrol/background/KCrossBGRender.cc:224 [ 1375s] E: trinity-tdebase no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/trinity-tdebase-14.0.0/kcontrol/iccconfig/iccconfig.cpp:268 Created attachment 2292 [details]
tdebase: fix rpmlint errors
Comment on attachment 2292 [details]
tdebase: fix rpmlint errors
Pushed to GIT in hash 373dcb07.
Created attachment 2300 [details]
tdelibs: build setuid binaries with PIE options
rpmlint complains about "non position independant executable" (PIE).
It looks like setuid programs must be built with "-fPIE" and linked with "-pie".
The attached patch adds the flag for tdelibs setuid binaries.
Created attachment 2301 [details]
tdebase: build setuid binaries with PIE options
Same stuff for tdebase.
Created attachment 2302 [details]
cmake : build setuid binaries with PIE flags
It seems to me like a good idea to add test for PIE support and also set PIE flags to targets in global CMake module.
Look at the attached patch.
Comment on attachment 2302 [details]
cmake : build setuid binaries with PIE flags
Yes, this patch works and is more generic than patching every cmakelists manually.
Comment on attachment 2302 [details]
cmake : build setuid binaries with PIE flags
Pushed to GIT in hash 08c6f54d.
Comment on attachment 2300 [details] tdelibs: build setuid binaries with PIE options Patch to handle additional build definition for tdeinit pushed to GIT in hash a22b1fc9. Other parts solved by patch from attachment 2302 [details]. Comment on attachment 2301 [details] tdebase: build setuid binaries with PIE options Solved by patch from attachment 2302 [details]. The PIE patch causes FTBFS in tdenetwork during cmake phase. -- Looking for sys/param.h - found -- Looking for net/if_ppp.h -- Looking for net/if_ppp.h - found CMake Error at cmake/modules/TDEMacros.cmake:1029 (set_target_properties): set_target_properties called with incorrect number of arguments. Call Stack (most recent call first): kppp/CMakeLists.txt:40 (tde_add_executable) CMake Error at cmake/modules/TDEMacros.cmake:1030 (set_target_properties): set_target_properties called with incorrect number of arguments. Call Stack (most recent call first): kppp/CMakeLists.txt:40 (tde_add_executable) (In reply to Francois Andriot from comment #17) > The PIE patch causes FTBFS in tdenetwork during cmake phase. > > -- Looking for sys/param.h - found > -- Looking for net/if_ppp.h > -- Looking for net/if_ppp.h - found > CMake Error at cmake/modules/TDEMacros.cmake:1029 (set_target_properties): > set_target_properties called with incorrect number of arguments. > Call Stack (most recent call first): > kppp/CMakeLists.txt:40 (tde_add_executable) > > > CMake Error at cmake/modules/TDEMacros.cmake:1030 (set_target_properties): > set_target_properties called with incorrect number of arguments. > Call Stack (most recent call first): > kppp/CMakeLists.txt:40 (tde_add_executable) I believe that there are two issues simultaneously: 1) ${TDE_PIE_CFLAGS} and ${TDE_PIE_LDFLAGS} should be in quotes 2) in tdenetwork not been used tde_setup_architecture_flags Created attachment 2321 [details]
tdenetwork : Fix FTBFS due to CMake PIE detection
The attached patch fixes both problems mentioned above.
Please test it.
Comment on attachment 2321 [details]
tdenetwork : Fix FTBFS due to CMake PIE detection
works for me.
Comment on attachment 2321 [details]
tdenetwork : Fix FTBFS due to CMake PIE detection
Pushed to GIT in hash 47d77551 (cmake) and af4c1177 (tdenetwork).
tdeaccessibility: there are 3 desktop files (kmag, kmousetool, kmouth) that are installed under /opt/trinity/share/applnk/Applications . Rpmlint gives fatal error because obsolete and non-XDG compliant path. These files should go to /opt/trinity/share/applications/tde instead . (In reply to Francois Andriot from comment #22) > tdeaccessibility: > there are 3 desktop files (kmag, kmousetool, kmouth) that are installed > under /opt/trinity/share/applnk/Applications . > Rpmlint gives fatal error because obsolete and non-XDG compliant path. > These files should go to /opt/trinity/share/applications/tde instead . Fixed in GIT hash 46f4ca81 (master) and 941edc75 (r14.0.x). Francois, what is the status of this metabug? |