By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 2143

Summary:	Icons do not display on some dialog push buttons
Product:	TDE	Reporter:	Darrell <darrella>
Component:	other (any)	Assignee:	Timothy Pearson <kb9vqf>
Status:	NEW ---
Severity:	normal	CC:	bugwatch, darrella, kb9vqf, michele.calgaro
Priority:	P5
Version:	R14.0.x [Trinity]
Hardware:	Other
OS:	Linux
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Bug Depends on:
Bug Blocks:	2968

Description Darrell 2014-10-04 13:45:43 CDT

When "Show icons on buttons" is enabled, some buttons nonetheless do not display an icon. This bug was first reported in bug 1800.

The bug seems to affect buttons using the 'setButtonOK' method. An example of such a button is in Kompare. The Cancel button displays an icon but the 'Compare' button does not.

Comment 1 Timothy Pearson 2014-10-04 13:48:38 CDT

Question is, what icon should be shown?  If I remember correctly the bug caused a green checkmark to appear on buttons with default focus; is this appropriate and desired in all circumstances?

Comment 2 Darrell 2014-10-04 14:00:53 CDT

A green check mark is appropriate. Bug 1800 did not introduce this bug. As mentioned in the comments and discussion in bug 1800, the bug is a long time latent bug from KDE3. That is, certain push buttons never did display an icon even when configured to display icons. The malforming of the icons reported in bug 1800 was a regression because the previous (incorrect) behavior was not to display icons for certain buttons. This bug is not TDE regression but a letent bug from KDE3.

Comment 3 Timothy Pearson 2014-10-04 16:53:37 CDT

This is caused by the original application authors specifying an empty icon for their default buttons.  This is not something that can be fixed globally; it has to be fixed application by application.

Kompare has been fixed in GIT hash 0aaf68d.  What other applications are affected?

Thanks!

Comment 4 Darrell 2014-10-04 17:17:59 CDT

>What other applications are affected?
According to bug 1800, at least the following:

* Find & Replace 'Replace' button
* khelpcenter 'Build Index' button
* Replace Confirmation 'Find Next' button

Refer to the images attached in bug 1800.

Probably more buttons exist. Best to leave this bug report open, for a while, now that we know what to watch for. Should not be an R14 blocker.

Comment 5 Darrell 2014-10-04 18:52:29 CDT

>Kompare has been fixed in GIT hash 0aaf68d.
Kompare dialog 'Compare' button looks great here. Thank you.

Comment 6 Michele Calgaro 2014-10-05 06:50:15 CDT

*** Bug 2141 has been marked as a duplicate of this bug. ***