| Summary: | TDE presents unnecessary dialog when connecting ebook reader | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Darrell <darrella> |
| Component: | tdelibs | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugwatch, darrella, kb9vqf |
| Priority: | P5 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Attachments: |
TDEHW screen capture
Screen capture of TDE deamon dialogs lsusb and udevadm outputs for ebook reader |
||
|
Description
Darrell
2014-11-25 15:27:59 CST
Sounds like the notification daemon should check for mountability before popping up dialogs. Thanks for the info that TDE already properly detects internally whether the partition is mountable; this should be an easy fix. (In reply to Timothy Pearson from comment #1) > Sounds like the notification daemon should check for mountability before > popping up dialogs. > > Thanks for the info that TDE already properly detects internally whether the > partition is mountable; this should be an easy fix. Ah, nevermind. On looking again at your answer it seems the only difference is that one is read only and one is read write, which can't be used to select popups. Can you attach a screenshot of the TDE hardware manager showing both devices? Thanks! Created attachment 2357 [details] TDEHW screen capture >On looking again at your answer it seems the only difference is that one is >read only and one is read write, which can't be used to select popups. Yes. The read-only partition is superfluous although mountable. As I shared, KDE4 and gvfs get this right and don't bother the user with the partition. I have no idea how they do that. >Can you attach a screenshot of the TDE hardware manager showing both devices? Attached. The list is exactly the same as the lsscsi output. Created attachment 2358 [details]
Screen capture of TDE deamon dialogs
Another note. One of the dialog options is to download photos with digikam. See the attached images.
I don't know how TDEHW distinguishes USB devices, if at all, but seems digikam should not be an option with an ebook reader.
(In reply to Darrell from comment #4) > Created attachment 2358 [details] > Screen capture of TDE deamon dialogs > > Another note. One of the dialog options is to download photos with digikam. > See the attached images. > > I don't know how TDEHW distinguishes USB devices, if at all, but seems > digikam should not be an option with an ebook reader. I've run into that particular bug myself with the SD card from a camera, so I'll see if I can fix it. Not sure there's a whole lot I can do about the Ebook reader; out of curiousity what happens on KDE/gvfs when a multi-partition USB drive is inserted? (In reply to Timothy Pearson from comment #5) > (In reply to Darrell from comment #4) > > Created attachment 2358 [details] > > Screen capture of TDE deamon dialogs > > > > Another note. One of the dialog options is to download photos with digikam. > > See the attached images. > > > > I don't know how TDEHW distinguishes USB devices, if at all, but seems > > digikam should not be an option with an ebook reader. > > I've run into that particular bug myself with the SD card from a camera, so > I'll see if I can fix it. Not sure there's a whole lot I can do about the > Ebook reader; out of curiousity what happens on KDE/gvfs when a > multi-partition USB drive is inserted? On digging further it looks like Digikam is an option for any removable device. I'm not sure that this is wrong, as there is no way to know if the removable device is a camera memory card until it is mounted. I do want to know how KDE handles multi-partition USB devices if you have some time to test. Something tells me they only generate one popup per device instead of one popup per partition, but I could be wrong. Can you attach the output of 'lsusb -vv' with your Ebook reader attached? Also helpful would be the output of this command run once on each of the mountable partitions of your reader: udevadm info --query=all --name=/dev/<node> Thanks! Created attachment 2360 [details]
lsusb and udevadm outputs for ebook reader
I included the lsscsi output so you can match the udevadm outputs.
I confirm that digikam is an option regardless of the USB device. I tried several USB flash drives and the TDE Deamon dialog was always the same. I do not have a USB hard drive to test.
Regarding KDE, the System Settings Removable Devices module shows the Sony PRS-950 Launcher and Sony PRS-950. That is similar to the two TDE Daemon pop dialogs for SETTING and READDER respectively. The difference with KDE is when I mount the ebook reader, only the READER device mounts at /media/READER. The other device (SETTING) does not mount. So seems the KDE code does have a way to distinguish what to mount.
Curiously, there are two actions provided by KDE: 1) dowqnload photos with gwenview and 2) open with file manager. The digikam option in TDE is much the same.
I don't know the GTK systems well enough to know how to determine whether gvfs also sees the SETTING partition/device but also is coded not to mount. My guess is because the partition is read-only that gvfs more than likely sees the partition but ignores.
I never mentioned, but the SETTING partition is Windows and Mac setup files for installing GUI apps for managing the ebook reader with a desktop computer. (In reply to Darrell from comment #7) > Created attachment 2360 [details] > lsusb and udevadm outputs for ebook reader > > I included the lsscsi output so you can match the udevadm outputs. Thanks for that; it looks like I can suppress the unwanted dialog after all by keying in on this setting: UDISKS_IGNORE=1 This should be a trivial fix so it might make its way into R14 RC2. > I confirm that digikam is an option regardless of the USB device. I tried > several USB flash drives and the TDE Deamon dialog was always the same. I do > not have a USB hard drive to test. I'm going to say this is not a bug, especially given the mechanics behind the device detection and the fact that KDE hasn't figured out a way to do it any differently. Thanks for the info! (In reply to Timothy Pearson from comment #9) > (In reply to Darrell from comment #7) > > Created attachment 2360 [details] > > lsusb and udevadm outputs for ebook reader > > > > I included the lsscsi output so you can match the udevadm outputs. > > Thanks for that; it looks like I can suppress the unwanted dialog after all > by keying in on this setting: > UDISKS_IGNORE=1 > > This should be a trivial fix so it might make its way into R14 RC2. This ended up being such a trivial patch that I decided to push it for RC2. This bug should be fixed in GIT hashes 7b66a28 (tdelibs) and 5ab19b1 (tdebase). Please test and verify that it is truly fixed; I obviously cannot test as I have no device that sets the Hidden flag. Thanks! I now see only one TDE deamon dialog for READER. I still see two desktop icons. The SETTING device is not auto-mounted, but I can manually mount using the icon popup menu. I have mixed feelings about the second (SETTING) desktop icon still appearing. No such icon or device appears in the gvfs systems, which provides for a cleaner desktop. As the device/partition is read-only, I wonder about the value of being able to manually mount, other than mere curiosity. Is there a way the the read-only device is available in konqueror or kcontrol (Storage Media) but no desktop icon appears? (In reply to Darrell from comment #11) > I now see only one TDE deamon dialog for READER. > > I still see two desktop icons. The SETTING device is not auto-mounted, but I > can manually mount using the icon popup menu. > > I have mixed feelings about the second (SETTING) desktop icon still > appearing. No such icon or device appears in the gvfs systems, which > provides for a cleaner desktop. As the device/partition is read-only, I > wonder about the value of being able to manually mount, other than mere > curiosity. Is there a way the the read-only device is available in konqueror > or kcontrol (Storage Media) but no desktop icon appears? I chose to hide the udev hidden devices (e.g. the system partition) via TDE's hidden file mechanism. This provides the best of both worlds; affected devices are hidden by default but can be exposed by selecting the standard Show Hidden Files menu option. As I already had to rebuild tdebase to fix a twin crash that had snuck in (Bug 2218) I went ahead and committed this to GIT in hash 2c1d4ad. Thanks for reporting, and for the information that led to the fix! I now see only the READER desktop icon and only one TDE deamon popup. For the curious user, the read-only SETTING partition is mountable and browsable through the Storage Media mechanism. The updated behavior seems correct to me and is consistent with other desktops. Thanks. :) |