By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 230

Summary: Amarok Keyboard Shortcuts Do Not Work Correctly
Product: TDE Reporter: Darrell <darrella>
Component: non-core programsAssignee: Timothy Pearson <kb9vqf>
Status: RESOLVED FIXED    
Severity: major CC: bugwatch, darrella, kb9vqf, slavek.banko
Priority: P1    
Version: 3.5.13 [Trinity]   
Hardware: All   
OS: All   
Compiler Version: TDE Version String:
Application Version: Application Name: Amarok
Attachments: Partial patch to fix keyboard shortcuts

Description Darrell 2010-07-22 13:01:23 CDT 
Bug No. 1:

Amarok has three keyboard shortcuts for the Playlist Browser Sidebar hard-coded as defaults:

1) Space bar: To load and start playing a playlist
2) F2: To rename a playlist
3) Shift-Delete: To delete a playlist

None of these keyboard shortcuts work.

The playlist browser pop-up context menu shows the shortcuts and the options work correctly from the context menu.

These same keyboard shortcuts are hard-coded in the playlist window too. The duplication is okay, but something in the source code prevents the shortcuts from functioning correctly in the playlist browser sidebar.

Bug No. 2:

Oddly, the Space bar keyboard shortcut functions correctly in the playlist browser sidebar AFTER remapping the playlist window Pause shortcut to something different from than Space bar. However, that change is good only for the current playing session. Closing and restarting Amarok always remaps the Pause keyboard shortcut back to the Space bar, which then renders useless the same keyboard shortcut for loading and playing a playlist.

Bug No. 3:

A double-click on a playlist in the playlist browser sidebar will load and start playing a playlist. The equivalent keyboard shortcut is supposed to be the Space bar, which currently does not work. If the Space bar bug is resolved such that the Space bar shortcut then would open and start playing a playlist as originally intended, there still would be no keyboard shortcut to only load a playlist. The playlist browser context menu provides such an option. There then should be a keyboard shortcut too. The context menu shows the L key as the shortcut, but that key will not work if any playlist in the playlist browser is spelled with the first letter L. To remain consistent with the keyboard shortcuts in the playlist window, the Enter key should be used to only load a playlist. The playlist browser pop-up context menu should be updated to reflect that Loading a playlist uses the Enter key and not the L key.

After resolving these three related bugs, the shortcuts then would look like this:

Space bar: 1) in the playlist window toggles Pause/Play; 2) in the playlist browser sidebar loads and starts playing a playlist.

Enter: 1) in the playlist window starts playing the selected song; 2) in the playlist browser sidebar loads but does not start playing a playlist.
Comment 1 Darrell 2012-10-10 23:17:07 CDT 
Created attachment 861 [details]
Partial patch to fix keyboard shortcuts

I have a partial patch but need coaching to finish.

I modified the playlist browser context menu to list Enter as Load and Shift+Enter as Load and Play. With that there should be no conflict with Key_Space, which is used to Pause/Play songs. Both of the menu items work as intended: Load only loads the playlist but does not play and Load and Play is the same as double-click, which loads and starts playing the playlist.

I am unable to get Enter, Shift+Enter, F2, and Shift+Delete to function at all. Initially, Shift+Delete seemed to work, but when I commented out case Key_Delete, then I discovered Shift+Delete was not really working.

The keyboard shortcuts are defined in playlistbrowser.cpp, line 2888, void PlaylistBrowserView::keyPressEvent( TQKeyEvent *e ).

I don't know the proper TQString to pass to the Load shortcut, as noted in the patch comments. Everything I try results in a build failure.

One option is to remove the keyboard shortcut references in the context menu, since they don't work anyway, but fixing the shortcuts would be nicer.

The patch is commented to identify the remaining problems.
Comment 2 Timothy Pearson 2013-04-05 00:15:01 CDT 
Patch fixed and pushed to GIT in hash 0cc1c9a.  Note that Rename was changed to Shift+F2 to avoid a conflict with the global Rename shortcut F2.