By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 2301

Summary:	twin/compton-tde does not compile without OpenGL support
Product:	TDE	Reporter:	Martin Gebert <Murphy.Gebert>
Component:	tdebase	Assignee:	Timothy Pearson <kb9vqf>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugwatch, kb9vqf, slavek.banko
Priority:	P5
Version:	R14.0.0 [Trinity]
Hardware:	i386
OS:	Other
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Bug Depends on:
Bug Blocks:	2246
Attachments:	Shorten disabled code when OpenGL is not available

Description Martin Gebert 2015-01-05 16:22:23 CST

Trying to compile tdebase on a current Gentoo without OpenGL installed, I got stuck in the compton subdir of twin. Apparently when CONFIG_VSYNC_OPENGL is not defined many central macros and structs are missing, e. g. printf_errf, session_t etc.
Also there seem to be nesting issues, as the second appearance of

#ifdef CONFIG_VSYNC_OPENGL

(line 374) seems to appear within the first one at line 146, which AFAI can tell is closed at line 1398.

A quick workaround to continue the build would be appreciated; I try to adapt 3.5.13.x ebuilds for 14.0.0 with the prospect of making them available as Gentoo overlay ASA tdebase can be installed.

Comment 1 Martin Gebert 2015-01-05 17:58:38 CST

Created attachment 2413 [details]
Shorten disabled code when OpenGL is not available

This patch shortens the code disabled by an undefined CONFIG_VSYNC_OPENGL to the minimum, leaving the necessary macros and structs enabled. Now twin builds, but I haven't tested if it works yet.

Comment 2 Slávek Banko 2015-01-05 19:16:42 CST

Interesting. I did a comparison the code with upstream GIT and appears to be almost the same == with the same strangeness.

See https://github.com/chjj/compton/blob/master/src/common.h

Comment 3 Slávek Banko 2015-01-16 18:47:35 CST

It seems that the problem was fixed in Compton upstream in commit 03ebae4c - see commit https://github.com/chjj/compton/commit/03ebae4c

Tim, please, can you update the Compton-TDE by upstream?

Comment 4 Timothy Pearson 2015-01-17 12:44:59 CST

Sure, I'll see what I can do.

Comment 5 Timothy Pearson 2015-01-17 13:11:49 CST

(In reply to Timothy Pearson from comment #4)
> Sure, I'll see what I can do.

Updated in GIT hash da5cf5e (tdebase).

Let me know if this resolves the issue...

Comment 6 Slávek Banko 2015-01-28 20:46:57 CST

Because the patch from Compton upstream is essentially identical to proposed patch, I think we can close this bug report as resolved - fixed.