| Summary: | Fix KDE->TDE branding in error dialog | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Darrell <darrella> |
| Component: | tdebase | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | trivial | CC: | bugwatch, darrella, michele.calgaro, slavek.banko |
| Priority: | P5 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Bug Depends on: | |||
| Bug Blocks: | 2246 | ||
| Attachments: | Patch to fix KDE->TDE branding in error dialog | ||
The patch looks good. Darrell, you can either push it yourself or provide a "Signed-off-by" clause here and then I can push it. >provide a "Signed-off-by" clause
What is that?
>>provide a "Signed-off-by" clause >What is that? Have a look here: http://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for Any contributor to TDE is now required to sign a TDE CLA ( https://www.trinitydesktop.org/cla/ http://trinity-devel.pearsoncomputing.net/?0::13900 ) before committing or before his/her contribution is accepted. If you have already done that, you can commit with "git -s" or you can provide a string such as Signed-off-by: Name Surname <email address> that will be used by another committer to push your patch in the correct way. How do I add 'Signed-off-by: Name Surname <email address>' directly in the patch? > How do I add 'Signed-off-by: Name Surname <email address>' directly in the
> patch?
You can just type the sentence here in bugszilla whenever you submit a patch. Or you can commit using 'git -s' which will automatically add the string for you without having to do anything else.
Pushed in commit ad2dc879. Please let me know whether I did this correctly. > Please let me know whether I did this correctly.
That's good. In general though the Sign-off-by clause is inserted as the last line of the commit message ;-)
Ported to r14.0.x branch in commit ed4336e.
Guys, thank you both. >the Sign-off-by clause is inserted as the last line of the commit message
I noticed that when I typed the comment. How do I force the sign-off to the end?
I used the following: git commit -a -s
>>the Sign-off-by clause is inserted as the last line of the commit message
>I noticed that when I typed the comment. How do I force the sign-off to the end?
It may seems silly, but just type the commit message above the sign-off sentence in your editor :-)
|
Created attachment 2437 [details] Patch to fix KDE->TDE branding in error dialog Fix branding in dialog.