By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 2402

Summary:	Build issue: bibletime error on rpmlint
Product:	TDE	Reporter:	Francois Andriot <albator78>
Component:	non-core programs	Assignee:	Francois Andriot <albator78>
Status:	RESOLVED FIXED
Severity:	normal	CC:	albator78, bugwatch, slavek.banko
Priority:	P5
Version:	R14.0.0 [Trinity]
Hardware:	Other
OS:	Linux
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Bug Depends on:
Bug Blocks:	2246
Attachments:	bibletime: use strcmp instead of string comparison bibletime: use strcmp instead of string comparison (2)

Description Francois Andriot 2015-03-21 11:30:10 CDT

Bibletime builds correctly on opensuse but fails at the rpmlint stage, because forbidden string comparison.

Comment 1 Francois Andriot 2015-03-21 11:31:04 CDT

Created attachment 2470 [details]
bibletime: use strcmp instead of string comparison

The attached patch makes rpmlint happy with the string comparisons.

Comment 2 Slávek Banko 2015-03-21 13:16:51 CDT

François, I believe that the patch causes a reversal of the sense of conditions.

Previous getGlobalOption( optionName(type).latin1() ) == "On" gives a 'true' if strings are identical. While strcmp if strings are identical gives '0' => therefore 'false'.

Comment 3 Francois Andriot 2015-03-21 13:22:52 CDT

AFAIK, in C++, "integer 0" translates to "boolean true", and "any integer other than 0" translates to "boolean false".

In shell scripting, it's the contrary ... "0" means "false" and "anything above 0" means "true".

Comment 4 Francois Andriot 2015-03-21 13:24:41 CDT

(In reply to Francois Andriot from comment #3)
> AFAIK, in C++, "integer 0" translates to "boolean true", and "any integer
> other than 0" translates to "boolean false".
> 
> In shell scripting, it's the contrary ... "0" means "false" and "anything
> above 0" means "true".

Oh no, it's precisely the contrary of what I said ... please ignore this comment, and yes, you're right, the patch probably does the contrary of expected behaviour.

Comment 5 Francois Andriot 2015-03-21 16:36:09 CDT

Created attachment 2471 [details]
bibletime: use strcmp instead of string comparison (2)

This patch should produce the expected behaviour.

Comment 6 Slávek Banko 2015-03-23 18:40:16 CDT

Comment on attachment 2471 [details]
bibletime: use strcmp instead of string comparison (2)

Pushed to GIT in hash a18630c3 (master) and 5ae4a0b3 (r14.0.x).