By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 2434

Summary:	Build issue: smartcardauth rpmlint errors
Product:	TDE	Reporter:	Francois Andriot <albator78>
Component:	non-core programs	Assignee:	Slávek Banko <slavek.banko>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugwatch, slavek.banko
Priority:	P5
Version:	R14.0.0 [Trinity]
Hardware:	Other
OS:	Linux
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Bug Depends on:
Bug Blocks:	2468
Attachments:	Fix functions prototypes

Description Francois Andriot 2015-04-26 17:15:43 CDT

Build log (extract):

[   70s] + ./build_ckpasswd
[   70s] gcc ckpasswd.c -c
[   70s] ckpasswd.c: In function 'password_system':
[   70s] ckpasswd.c:211:9: warning: return makes pointer from integer without a cast [enabled by default]
[   70s]          return xstrdup(pwd->pw_passwd);
[   70s]          ^
[   70s] ckpasswd.c: In function 'group_system':
[   70s] ckpasswd.c:234:5: warning: return makes pointer from integer without a cast [enabled by default]
[   70s]      return xstrdup(gr->gr_name);
[   70s]      ^
[   70s] ckpasswd.c: In function 'main':
[   70s] ckpasswd.c:306:26: warning: assignment makes pointer from integer without a cast [enabled by default]
[   70s]                  authinfo = xmalloc(sizeof(struct auth_info));
[   70s]                           ^
[   70s] ckpasswd.c:313:26: warning: assignment makes pointer from integer without a cast [enabled by default]
[   70s]                  authinfo = xmalloc(sizeof(struct auth_info));
[   70s]                           ^
[   70s] gcc xmalloc.c -c
[   70s] gcc messages.c -c
[   70s] messages.c: In function 'message_handlers':
[   70s] messages.c:205:11: warning: assignment makes pointer from integer without a cast [enabled by default]
[   70s]      *list = xmalloc(sizeof(message_handler_func) * (count + 1));
[   70s]            ^
[   70s] gcc ckpass.c -c
[   71s] ckpass.c: In function 'password_system':
[   71s] ckpass.c:210:9: warning: return makes pointer from integer without a cast [enabled by default]
[   71s]          return xstrdup(pwd->pw_passwd);
[   71s]          ^
[   71s] ckpass.c: In function 'group_system':
[   71s] ckpass.c:233:5: warning: return makes pointer from integer without a cast [enabled by default]
[   71s]      return xstrdup(gr->gr_name);
[   71s]      ^
[   71s] ckpass.c: In function 'check_password':
[   71s] ckpass.c:267:14: warning: assignment makes pointer from integer without a cast [enabled by default]
[   71s]      authinfo = xmalloc(sizeof(struct auth_info));
[   71s]               ^
[   71s] ckpass.c:268:24: warning: assignment discards 'const' qualifier from pointer target type [enabled by default]
[   71s]      authinfo->username = username;
[   71s]                         ^
[   71s] ckpass.c:269:24: warning: assignment discards 'const' qualifier from pointer target type [enabled by default]
[   71s]      authinfo->password = password;
[   71s]                         ^
[   71s] gcc ckpasswd.o xmalloc.o messages.o -o ckpasswd -lpam -lcrypt
[   71s] g++ -I/usr/include/tqt -I/usr/include/qt3 -I/usr/include/tqt3 smartauthmon.cpp -c
[   71s] gcc smartauthmon.o ckpass.o xmalloc.o messages.o -o smartauthmon -ltqt -lpam -lcrypt -ltqt-mt -lstdc++
[   71s] + exit 0



Then rpmlint errors:
[   73s] E: trinity-smartcardauth 64bit-portability-issue ckpass.c:210, 233, 267
[   73s] E: trinity-smartcardauth 64bit-portability-issue ckpasswd.c:211, 234, 306, 313
[   73s] E: trinity-smartcardauth 64bit-portability-issue messages.c:205

Comment 1 Slávek Banko 2015-10-21 12:27:11 CDT

Created attachment 2582 [details]
Fix functions prototypes

Attached patch solves most of warnings.
Please, test it.

Comment 2 Slávek Banko 2015-10-21 13:49:52 CDT

Well, because the problem is manifested also with Ubuntu 15.10 (Wily), and patch solves it, I believe that this also fixes a problem with rpmlint. 
If not, do not hesitate to reopen this bug report!

The patch was pushed into the GIT in hash d0579538 (r14.0.x branch only).