| Summary: | Kvirc: irc protocol files not included in Debian/Ubuntu packages | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Michele Calgaro <michele.calgaro> |
| Component: | other (any) | Assignee: | Slávek Banko <slavek.banko> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | bugwatch, michele.calgaro, slavek.banko |
| Priority: | P1 | ||
| Version: | R14.0.1 [Trinity] | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Bug Depends on: | |||
| Bug Blocks: | 2246 | ||
| Attachments: |
Fix installation of kvirc protocol files on Debian and Ubuntu
alternative patch for debian/rules |
||
|
Description
Michele Calgaro
2015-08-03 19:08:33 CDT
Created attachment 2548 [details]
Fix installation of kvirc protocol files on Debian and Ubuntu
I found two mistakes. Outside move from /opt/trinity/share/services to /opt/trinity/share/kvirc/3.4/services, in postinst / prerm scripts was expected directory with 3.4.0 instead of 3.4.
Now I'm doing the test on my builder, then will be upload to build-farm.
Created attachment 2549 [details]
alternative patch for debian/rules
Alternative patch proposed. Do not use 'mv' after building, just call configure with an additional option.
BTW, current options of configure are not recognized. I have left them in so that in future we can check more in detail and update/remove as required.
The alternative patch works ok in Debian Stretch. (In reply to Michele Calgaro from comment #3) > The alternative patch works ok in Debian Stretch. Your patch looks cleaner, but I see a potential problem. The services path from configure is also registered in kvirc-config script - is installed in the package kvirc-trinity-dev. But /opt/trinity/share/kvirc/3.4/services not the right path to services at runtime. This path is just a hack to install - for use alternatives. I therefore believe that the patch with the move in rules, although it is not so clear, is safer. What's your opinion? >Your patch looks cleaner, but I see a potential problem. The services path from
>configure is also registered in kvirc-config script - is installed in the
>package kvirc-trinity-dev. But /opt/trinity/share/kvirc/3.4/services not the
>right path to services at runtime. This path is just a hack to install - for
>use alternatives.
>I therefore believe that the patch with the move in rules, although it is not
>so clear, is safer. What's your opinion?
The patch with the 'mv' is also ok for me. I hadn't seen the fact that kdeservicedir gets registered in kvirc-config, although it is not accessible since there is no option to get it returned from the script.
(In reply to Michele Calgaro from comment #5) > >Your patch looks cleaner, but I see a potential problem. The services path from > >configure is also registered in kvirc-config script - is installed in the > >package kvirc-trinity-dev. But /opt/trinity/share/kvirc/3.4/services not the > >right path to services at runtime. This path is just a hack to install - for > >use alternatives. > >I therefore believe that the patch with the move in rules, although it is not > >so clear, is safer. What's your opinion? > The patch with the 'mv' is also ok for me. I hadn't seen the fact that > kdeservicedir gets registered in kvirc-config, although it is not accessible > since there is no option to get it returned from the script. Because the patch with 'mv' will not cause undesirable side effects, I will push this patch. In any case, thank you for bug report and good alternative patch. Fixed in tde-packaging: 6253ed4f (master), 165ddae6 (r14.0.x). |