By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 2509

Summary: Login from TDM fails after upgrade
Product: TDE Reporter: Kristopher <gamrat.kristopher>
Component: rhelAssignee: Timothy Pearson <kb9vqf>
Status: NEEDINFO ---    
Severity: major CC: albator78, bugwatch, gamrat.kristopher, michele.calgaro, slavek.banko
Priority: P5    
Version: R14.0.x [Trinity]   
Hardware: Other   
OS: Linux   
Compiler Version: TDE Version String:
Application Version: Application Name:
Attachments: Attatchment of old config file
~/.xsession-errors
"New" tdmrc
Updated old config file

Description Kristopher 2015-08-30 10:25:19 CDT
I upgraded from R14.0.0 -> R14.0.1 as of today (30 Aug 2015) and I find myself unable to log in to any desktop. I type my user name and password, they are accepted by TDM, then I witness what appears to be Xorg completely restarting itself followed by TDM, as if I had never logged in. This occurs regardless of whether I set the desktop to TDE, Fluxbox, or TWM. This did *not* happen before the upgrade when I was still running R14.0.0.

Loggin in to the command line and manually startx'ing TDE seems to work normally, so TDE itself is working. It is just TDM that I am having an issue with.

I am running TDE on CentOS 6. I don't have another distro to test this on.

This *might* be related to bug 2427, however the bug described there is different as in that instance, it seems to start the TDE login process rather than simply bouncing back to TDM as I am seeing.
Comment 1 Kristopher 2015-08-30 10:44:23 CDT
Created attachment 2555 [details]
Attatchment of old config file

Upond investigating, I noticed a new file: /etc/trinity/tdm/tdmrc.rpmnew . For testing, I made a backup of the original tdmrc and overwrote it with the .rpmnew version, then ran

init 3 && sleep 5 && init 5

to force-restart TDM. Afterward, TDM allowed me to log back in without issue using both Fluxbox and TDE (didn't test with TWM as I did before, but I never use it anyway :-) ).

I am attaching my original tdmrc file, I am not sure what would be causing the issue, but it is bad juju to ask people to replace their existing configs just for the sake of a minor point-upgrade.
Comment 2 Kristopher 2015-08-30 10:45:55 CDT
(In reply to Kristopher from comment #1)
> Created attachment 2555 [details]
> Attatchment of old config file
> 
> Upond investigating, I noticed a new file: /etc/trinity/tdm/tdmrc.rpmnew .
> For testing, I made a backup of the original tdmrc and overwrote it with the
> .rpmnew version, then ran
> 
> init 3 && sleep 5 && init 5
> 
> to force-restart TDM. Afterward, TDM allowed me to log back in without issue
> using both Fluxbox and TDE (didn't test with TWM as I did before, but I
> never use it anyway :-) ).
> 
> I am attaching my original tdmrc file, I am not sure what would be causing
> the issue, but it is bad juju to ask people to replace their existing
> configs just for the sake of a minor point-upgrade.

As a P.S. to my last comment, I did not make any manual edits to tdmrc, all changes were done through the Control Center.
Comment 3 Slávek Banko 2015-08-30 11:06:23 CDT
Please attach the file .xsession-errors generated after a failed login.
Comment 4 Kristopher 2015-08-30 11:13:03 CDT
Created attachment 2557 [details]
~/.xsession-errors

This was done with the original tdmrc used prior to upgrade. It is the same regardless of whether I select TDE or Fluxbox as the desktop.
Comment 5 Francois Andriot 2015-08-30 13:48:02 CDT
Hello, in previous releases, the TDM configuration files were expected to be under /usr/share/config/tdm , but now, they are expected to be under /etc/trinity/tdm .

There is a probability that your R14.0.0 tdmrc contains reference to "/usr/share/config/tdm" , which are now invalid.
Comment 6 Kristopher 2015-08-30 19:31:35 CDT
(In reply to Francois Andriot from comment #5)
> Hello, in previous releases, the TDM configuration files were expected to be
> under /usr/share/config/tdm , but now, they are expected to be under
> /etc/trinity/tdm .
> 
> There is a probability that your R14.0.0 tdmrc contains reference to
> "/usr/share/config/tdm" , which are now invalid.

If you look at the one I attached, you will see that there is no reference to "/usr/share/config/tdm", nor a reference to "/usr/share/config/". That is the same one that I was using under R14.0.0, which is now broken under R14.0.1.
Comment 7 Michele Calgaro 2015-08-31 10:14:08 CDT
Kristopher, could you trying changing that "/opt/trinity/share/config/tdm/" to "/etc/trinity/tdm/" in your original config file? As far as I can tell, on my system (Debian) I don't have a "/opt/trinity/share/config/tdm/" folder and those "Xreset/Xsession/Xstartup..." files are in "/etc/trinity/tdm/". Not sure if CentOs is doing things differently, but give it a try.
Also could you attached the new config file so we can so a quick compare?
Thanks
Comment 8 Michele Calgaro 2015-08-31 10:15:04 CDT
Well, just looking at your attached .xsession-errors, I guess my previous comment could be right ;-)

error: Session "/opt/trinity/share/config/tdm/Xsession" execution failed: No such file or directory
Comment 9 Kristopher 2015-08-31 23:08:03 CDT
(In reply to Michele Calgaro from comment #7)
> Kristopher, could you trying changing that "/opt/trinity/share/config/tdm/"
> to "/etc/trinity/tdm/" in your original config file? As far as I can tell,
> on my system (Debian) I don't have a "/opt/trinity/share/config/tdm/" folder
> and those "Xreset/Xsession/Xstartup..." files are in "/etc/trinity/tdm/".
> Not sure if CentOs is doing things differently, but give it a try.

Making those changes to the original seems to fix it.

> Also could you attached the new config file so we can so a quick compare?
> Thanks

Sure.
Comment 10 Kristopher 2015-08-31 23:15:31 CDT
Created attachment 2558 [details]
"New" tdmrc

This is the tdmrc file included in the RPM. Instead of using it to replace the existing tdmrc, it did what was (in my opinion) the right thing by installing it as tdmrc.rpmnew .

If the path changes were intentional, I'd still consider this a bug because it would be the job of the package's upgrade script or, better yet, TDM itself to check the config file and ensure the paths were changed after upgrade. It would be unfriendly to ask people just to throw out the old config file just because of a change of path, and I'm sure many system administrators (including myself) and businesses would consider it unacceptable to come into work one day to find themselves suddenly and mysteriously unable to log in and do their jobs because of an upgrade.
Comment 11 Kristopher 2015-08-31 23:17:35 CDT
Created attachment 2559 [details]
Updated old config file

This is the old config file from R14.0.0, updated according to Michele's suggestion in comment 7. This one works and allows me to log in to TDE normally.
Comment 12 Michele Calgaro 2015-09-11 08:54:56 CDT
> Upond investigating, I noticed a new file: /etc/trinity/tdm/tdmrc.rpmnew .

Rereading through the bug report, a doubt comes to my mind.
tdmrc is from time to time updated. On Debian, when this happens the installation process pauses and ask me if I want to preserve the existing version or instead install the new one. If I preserve the old one, then a new tdmrc.dpkgnew file (or something similar) is created on the filesystem.
I wonder if by mistake you also preserved the old version when upgrading from 3.5.13.x to r14.0.0 or from r14.0.0 to r14.0.1.
Having said that, I do not know the details of the TDE CentOS packages, so maybe I am saying something wrong. 
Francois is defenitely the one that could provide some more info about this bug.
Comment 13 Kristopher 2015-09-11 15:27:03 CDT
(In reply to Michele Calgaro from comment #12)
> > Upond investigating, I noticed a new file: /etc/trinity/tdm/tdmrc.rpmnew .
> 
> Rereading through the bug report, a doubt comes to my mind.
> tdmrc is from time to time updated. On Debian, when this happens the
> installation process pauses and ask me if I want to preserve the existing
> version or instead install the new one. If I preserve the old one, then a
> new tdmrc.dpkgnew file (or something similar) is created on the filesystem.
> I wonder if by mistake you also preserved the old version when upgrading
> from 3.5.13.x to r14.0.0 or from r14.0.0 to r14.0.1.
> Having said that, I do not know the details of the TDE CentOS packages, so
> maybe I am saying something wrong. 
> Francois is defenitely the one that could provide some more info about this
> bug.

It never asked me if I want to preserve the config, it simply plopped the .rpmnew version into place.

As I said early, though, it's unfriendly to ask people to throw out their old configs just because something changed. There should definitely be a way to have either the packages or the software itself update the existing config files according to what changed. Simply replacing them would require that people redo whatever changes to their settings that they made, and for those of us who (like me) tweak every possible setting until we get things just right, having to do so over and over and over and .................... again will just serve as encouragement to either fork or find something different.
Comment 14 Michele Calgaro 2018-08-03 22:19:53 CDT
Is this bug still valid with newer versions?