| Summary: | Add support for subversion 1.9 | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Slávek Banko <slavek.banko> |
| Component: | other (any) | Assignee: | Michele Calgaro <michele.calgaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | bugwatch, michele.calgaro, slavek.banko |
| Priority: | P5 | ||
| Version: | R14.0.1 [Trinity] | ||
| Hardware: | All | ||
| OS: | All | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Bug Depends on: | |||
| Bug Blocks: | 2468 | ||
| Attachments: |
tdevelop patch for FTBFS
tdesdk patch Updated tdevelop patch which include the license_svn file as well tdesvn patch |
||
|
Description
Slávek Banko
2015-09-13 05:54:17 CDT
I will tackle this bug. It may take a while because I first need to do a full local rebuild on my system to see what is ok and what is FTBFS. Upgraded to major because we can not release the next r14.0.2 if packages such as tdevelop and tdesdk FTBFS. (In reply to Michele Calgaro from comment #1) > I will tackle this bug. It may take a while because I first need to do a > full local rebuild on my system to see what is ok and what is FTBFS. > > Upgraded to major because we can not release the next r14.0.2 if packages > such as tdevelop and tdesdk FTBFS. I would like to clarify a bit: Because the problem at this point affects only Debian Stretch, and because the final r14.0.2 "can not" be officially released for "testing" version of the distribution, it is not necessary at this point be considered this bug as blocking for r14.0.2. That's my opinion. For inspiration (because i have traditionally not oriented in the KDE GIT, so I can not find the appropriate commit): https://git.reviewboard.kde.org/r/124783/diff/1#index_header >I would like to clarify a bit: Because the problem at this point affects only >Debian Stretch, and because the final r14.0.2 "can not" be officially released >for "testing" version of the distribution, it is not necessary at this point be >considered this bug as blocking for r14.0.2. That's my opinion. I didn't know the problem was only in stretch. Dropped to major. >For inspiration (because i have traditionally not oriented in the KDE GIT, so I >can not find the appropriate commit): >https://git.reviewboard.kde.org/r/124783/diff/1#index_header Yes, I have already seen this. But thanks anyway. Created attachment 2578 [details]
tdevelop patch for FTBFS
Slavek,
the attached patch fixes TDevelop FTBFS on my local non fully updated system.
Before I push it into GIT, could you test whether it builds correctly also in an updated system?
Also please check versions that still use svn 1.8 because the patch contains small changes that
affect the building process with svn < 1.9
Created attachment 2579 [details]
tdesdk patch
Equivalent patch for tdesdk.
Slavek, please test this as well.
Created attachment 2580 [details]
Updated tdevelop patch which include the license_svn file as well
Slavek, no code changes between the first patch and this one. I only added the license file for the svn code that was used.
Created attachment 2581 [details]
tdesvn patch
And finally the patch for tdesvn. Please test :-)
(In reply to Michele Calgaro from comment #6) > Created attachment 2579 [details] > tdesdk patch > > Equivalent patch for tdesdk. > Slavek, please test this as well. All 46 builds of tdesdk successfully done. (In reply to Michele Calgaro from comment #8) > Created attachment 2581 [details] > tdesvn patch > > And finally the patch for tdesvn. Please test :-) All 46 builds of tdesvn successfully done. >All 46 builds of tdesdk successfully done.
>All 46 builds of tdesvn successfully done.
Thanks a lot for testing Slavek. I will push tomorrow, now it is sleep time for me. In the mean time I guess tdevelop will complete building as well.
(In reply to Michele Calgaro from comment #11) > >All 46 builds of tdesdk successfully done. > >All 46 builds of tdesvn successfully done. > Thanks a lot for testing Slavek. I will push tomorrow, now it is sleep time > for me. In the mean time I guess tdevelop will complete building as well. Yes, builds are now underway - for now 8 successfull (squeeze, wheezy, jessie, stretch, trusty), 36 pending :) (In reply to Slávek Banko from comment #12) > (In reply to Michele Calgaro from comment #11) > > >All 46 builds of tdesdk successfully done. > > >All 46 builds of tdesvn successfully done. > > Thanks a lot for testing Slavek. I will push tomorrow, now it is sleep time > > for me. In the mean time I guess tdevelop will complete building as well. > > Yes, builds are now underway - for now 8 successfull (squeeze, wheezy, > jessie, stretch, trusty), 36 pending :) Previous numbers were obviously wrong - pending was 38, but now it is: All 46 of tdevelop builds successfully done. Pushed in the following commits. Slavek, thanks again for testing in all those builds. tdevelop e392d02, db397b2 (master) b7feb0f, fb4b4ab (r14.0.x) tdesdk e4d5087 (master), 2ac1aa9 (r14.0.x) tdesvn e42c189 (master), e665050 (r14.0.x) |