| Summary: | TDEpowersave + Logout menu should offer Suspend2Hybrid | ||
|---|---|---|---|
| Product: | TDE | Reporter: | ThoMaus <thomas.maus> |
| Component: | tdebase | Assignee: | Michele Calgaro <michele.calgaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | bugwatch, deloptes, michele.calgaro, thomas.maus |
| Priority: | P5 | ||
| Version: | R14.1.x [Trinity] | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Bug Depends on: | |||
| Bug Blocks: | 2247 | ||
|
Description
ThoMaus
2016-02-27 03:05:29 CST
To be considered: Suspend triggers like lid-close, suspend+hibernate buttons can be handled via "logind" (config: "/etc/systemd/logind.conf"). Perhaps worth considering: if feasible, let "logind" do all kind of suspends thus isolating TDE from the specifics. If somebody in the know kindly indicates, where to look in the TDE sources, I'll try to investigate the possibility and provide a concrete proposal. If I press CTRL+ALT+DEL I see the shutdown screen and there is * Freeze * Suspend * Hibernate Are you talking about adding another option Freeze+Suspend? BTW I do not know how it looks at the moment - cause no time to play, but these options were not available to me unless i installed older versions of policykit-1 and upower and flagged them as hold hi policykit-1 0.105-3 hi upower 0.9.23-2+b1 (In reply to deloptes from comment #2) > If I press CTRL+ALT+DEL I see the shutdown screen and there is > > * Freeze > * Suspend > * Hibernate > > Are you talking about adding another option Freeze+Suspend? Thanking you for confirming my argumentation in bug 2602 (alas ignored). You just demonstrated how the current (and future) terminology provokes fundamental misunderstandings! To answer your question: Waht I'm talking about would be equivalent to Suspend+Hibernate in TDE terminology (but you are excused: "Hibernate" and "Freeze" were used as synonyms formerly (see bug 2602) ...) Initial support added in commit 3b095cf and e972ff0. There is some more code that needs to be written, will be added in a separate commit. Hybrid suspend will only be added to R14.1.x, not R14.0.x. > Perhaps worth considering: if feasible, let "logind" do all kind of suspends
> thus isolating TDE from the specifics.
> If somebody in the know kindly indicates, where to look in the TDE sources,
> I'll try to investigate the possibility and provide a concrete proposal.
Hi Thomas, sorry I just noticed this today.
You can look at tdelibs/tdecore/tdehw/tderootsystemdevice.cpp as a starting point.
For your info, if suspend can not be achieved by writing to /sys/power/state and tde has been compiled with WITH_LOGINDPOWER, TDE will try to achieve suspend using a dbus call to org.freedesktop.login1.Manager
But we can not make this the default way to suspend the system because TDE is dcop based and dbus is not installed by default. On older distros or if the user does not install the tde dbus packages, this would probably fail. So first choice will remain to write to /sys/power/state directly
DBus support for hybrid suspend added in commit ba3ed71. Previous commit was incomplete (one file was forgotten by mistake). Completed in commit a297127. Improved code in commit 92394e2 and added support in TDE Control/Hardware manager in commit b491941 Added support for hybrid suspend in Kickoff menu in commit fb91cbd. Fixed hybrid suspend support using HAL in commit c7171b9 Added support for hybrid suspend in tdepowersave in commit a3caab9 |