| Summary: | Some icons not displayed in systray, | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Q4OS Team <q4os> |
| Component: | tdebase | Assignee: | Michele Calgaro <michele.calgaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugwatch, michele.calgaro, q4os, slavek.banko |
| Priority: | P5 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Bug Depends on: | |||
| Bug Blocks: | 2575, 2696 | ||
| Attachments: |
missing icon in systray
patch patch (1) Systray icon rendering |
||
|
Description
Q4OS Team
2016-09-08 03:01:05 CDT
Created attachment 2686 [details]
missing icon in systray
Yes, I can confirm this bug because I saw it with other non-TDE applications as well from time to time. There was also a similar bug for missing icons on the main menu, again only for non-TDE apps. If you edit the menu and assign an icon to the application, then save and restart TDE, does the icon shows up? Thanks. The Network manager 'nm-applet' has no shortcut in the start menu. If I directly edit '/usr/share/applications/nm-applet.desktop' and assign some TDE icon, for ex. 'clock', it will show icon in systray after reboot. If I assign another icon, it will show empty space. If I refresh systray with the command: dcop kicker SystemTrayApplet iconSizeChanged proper icon immediately appears in the systray. Thank you! Thanks to your hint, I found an old KDE commit in SVN (before the fork Trinity), where is the core of the problem - method getIconSize: https://websvn.kde.org/branches/trinity/3.5.13_frozen/kdebase/kicker/applets/systemtray/systemtrayapplet.cpp?r1=848618&r2=854109 There is hope that this long-term bug would be corrected soon! Stay tuned :) Created attachment 2710 [details]
patch
Slavek, Q4OS team,
please try attached patch and let me know if it is now ok.
I could not reproduce the problem exactly, but noticed that using another application the icon initially appeared smaller when first added to systray. After calling iconSizeChange through DCOP the icon was resized.
The current patch executes the same "resizing" code when an icon is first added to systray. Now the icon of the same application is immidiately displayed with the same size that it would have had after calling the DCOP method.
Created attachment 2711 [details]
patch (1)
The same method of solution - without changes in the method iconSizeChanged.
Tested - icon is fine, as expected.
Fixed in GIT hash 6bd9497d (master) and 89aa5220 (r14.0.x). Created attachment 2740 [details]
Systray icon rendering
Unfortunately, the bug still persists, although the fix improved things a bit. The bug is still reproducible exactly the same way as before: - Fresh TDE stable (14.0.4) installation on Debian Jessie. - Install Network manager applet: 'apt-get install network-manager-gnome' - Reboot. - There is an empty space instead of 'nm-applet' icon in the system tray. I have realized, that the icon size and placing is (very probably) correct, the problem seems to be bad icon rendering only. I have attached a short screencast, that shows the problem in a clear way. Maybe it's about a new bug, so should I create new report or it would be better to reopen this one ? Thanks for the feedback Q4OS team. I have reopened the bug and added to R14.0.5 bug list Out of curiosity: nm-applet was precisely the application on that I've successfully tested the bug fix. The difference is only in the fact that I've tested it on Wheezy. @Q4OS team Can you check if the problem still persist on the latest R14.0.5 preliminary build? I just tried to reproduce the bug in buster/R14.1-dev and the network manager icon displayed ok. I tried different panel sizes as well, no problems. Looks well now, as I am not able to reproduce this bug on the latest R14.0.5 preliminary build. Debian stable Stretch, TDE R14.0.5 preliminary. Ok, since we can't seem to reproduce the bug anymore and things seem ok, I am closing the bug for the time being. Should you run into the same issue again, please reopen the bug. Thanks for your report and testing. |