By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 2692

Summary:	Build issue: tdepim fails rpmlint test
Product:	TDE	Reporter:	Francois Andriot <albator78>
Component:	tdepim	Assignee:	Timothy Pearson <kb9vqf>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugwatch, slavek.banko
Priority:	P5
Version:	R14.1.x [Trinity]
Hardware:	Other
OS:	Linux
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Bug Depends on:
Bug Blocks:	2575
Attachments:	Fix return value in kmobiledevice unlock

Description Francois Andriot 2016-09-16 14:29:02 CDT

Extract from rpmlint output below:

[ 1434s] I: There are likely swapped arguments in a memset
[ 1434s]    Check that the function arguments match: memset(ptr,BYTEVALUE,LENGTH)
[ 1434s] W: trinity-tdepim memset-with-zero-length /home/abuild/rpmbuild/BUILD/trinity-tdepim-14.1.0/akregator/src/mk4storage/metakit/src/string.cpp:132:28
[ 1434s] 
[ 1434s] I: Program is likely to break with new gcc. Try -fno-strict-aliasing.
[ 1434s] W: trinity-tdepim strict-aliasing-punning /home/abuild/rpmbuild/BUILD/trinity-tdepim-14.1.0/akregator/src/mk4storage/metakit/src/column.cpp:838, 846, 854, 862, 870, 883, 900, 1057
[ 1434s] W: trinity-tdepim strict-aliasing-punning /home/abuild/rpmbuild/BUILD/trinity-tdepim-14.1.0/akregator/src/mk4storage/metakit/src/persist.cpp:50, 100
[ 1434s] W: trinity-tdepim strict-aliasing-punning /home/abuild/rpmbuild/BUILD/trinity-tdepim-14.1.0/akregator/src/mk4storage/metakit/src/viewx.cpp:852
[ 1434s] W: trinity-tdepim strict-aliasing-punning /home/abuild/rpmbuild/BUILD/trinity-tdepim-14.1.0/tderesources/groupwise/soap/stdsoap2.h:754, 782
[ 1434s] 
[ 1434s] I: Program returns random data in a function
[ 1434s] E: trinity-tdepim no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/trinity-tdepim-14.1.0/kmobile/kmobiledevice.cpp:392

Comment 1 Slávek Banko 2016-09-26 19:42:29 CDT

Created attachment 2705 [details]
Fix return value in kmobiledevice unlock

Such a patch is sufficient?
It focuses only to the specified error.

Comment 2 Slávek Banko 2016-09-28 20:25:29 CDT

Comment on attachment 2705 [details]
Fix return value in kmobiledevice unlock

Pushed to GIT in hash 105df082 (master) and d465e287 (r14.0.x).

Comment 3 Slávek Banko 2016-09-28 20:27:00 CDT

Please, if the missing return value was not the only serious error, do not hesitate to reopen this bug report.