By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 2725

Summary:	When building tdenetwork cmake does not check for libv4l-dev
Product:	TDE	Reporter:	deloptes
Component:	tdenetwork	Assignee:	Slávek Banko <slavek.banko>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugwatch, deloptes, slavek.banko
Priority:	P5
Version:	R14.0.x [Trinity]
Hardware:	Other
OS:	Linux
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Bug Depends on:
Bug Blocks:	2696
Attachments:	Better videodev header check

Description deloptes 2016-11-11 16:11:17 CST

When building tdenetwork build fails on missing linux/videodev.h. This is provided via libv4l-dev. A proper check would be appreciated.

Comment 1 Slávek Banko 2016-11-11 18:17:17 CST

Now I look and I see the test for linux/videodev.h is located in kopete/ConfigureChecks.cmake. It seems that the test is properly performed.

It is possible that is not properly tested definition HAVE_LINUX_VIDEODEV_H somewhere in code?

Comment 2 deloptes 2016-11-11 18:47:15 CST

in
tdenetwork/kopete/plugins/motionautoaway/motionawayplugin.cpp

#ifdef HAVE_LIBV4L1_VIDEODEV_H
#include <libv4l1-videodev.h>
#else
#include <linux/videodev.h>
#endif

Comment 3 Slávek Banko 2016-11-12 04:37:04 CST

Ok, thank you. It may be better to write the test, just as it is now in Tellico:

http://mirror.git.trinitydesktop.org/cgit/tellico/tree/ConfigureChecks.cmake#n185

What do you think?

Comment 4 deloptes 2016-11-12 07:03:41 CST

Yes it looks like it would do the work. I am really not a cmake expert, but from what I see it is ok. If it is not possible to share the same check/file, I would add a comment in both files to remember changing the other as well if necessary at some point of time in the future.

regards

Comment 5 Slávek Banko 2016-11-12 10:50:17 CST

Created attachment 2741 [details]
Better videodev header check

Please verify the improved videodev header check.

Comment 6 deloptes 2016-11-12 18:29:43 CST

Yes this works now

CMake Error at cmake/modules/TDEMacros.cmake:24 (message):
  #################################################

   libv4l1-videodev.h or linux/videodev.h is required, but not found on your system

  #################################################
Call Stack (most recent call first):
  kopete/ConfigureChecks.cmake:33 (tde_message_fatal)
  kopete/CMakeLists.txt:16 (include)

Comment 7 Slávek Banko 2016-11-12 19:16:02 CST

Thank you for test. Pushed to GIT in hash c7ed96db (master) and 56484e2a (r14.0.x).