By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 2734

Summary:	tdecmshell autostart module crashes
Product:	TDE	Reporter:	Q4OS Team <q4os>
Component:	tdeadmin	Assignee:	Michele Calgaro <michele.calgaro>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugwatch, michele.calgaro, q4os
Priority:	P5
Version:	R14.0.x [Trinity]
Hardware:	Other
OS:	Linux
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Bug Depends on:
Bug Blocks:	2696

Description Q4OS Team 2016-12-06 13:48:14 CST

'tdecmshell autostart' module crashes, if I attempt to make konsole started on TDE session login.

Exact steps to reproduce:
- Fresh TDE stable (14.0.4) installation on Debian Jessie
- Install "kcontrol-autostart-trinity" package
- Go to TDE Control Center -> TDE Components -> Autostart Manager
- Add -> System -> Konsole -> Ok
- "Properties.." dialog appears
- Click Ok to add Konsole to autostart
- Informations dialog - "Could not start process.." appears
- Click OK or Cancel button
- Bug: Autostart module crashes

Comment 1 Michele Calgaro 2018-04-24 01:52:15 CDT

Confirmed in buster + R14.1

Comment 2 Michele Calgaro 2018-04-26 10:00:07 CDT

This seems to be a problem with adding the system menu Konsole entry to autostart. Adding other applications is working, as well as adding Konsole by selecting the executable file (/opt/trinity/bin/konsole) directly.
Will take a look.

Comment 3 Michele Calgaro 2018-04-26 12:39:31 CDT

There are a few things going on here.

1) the kcmautostart applications has a few bugs on its own. Not much relevant to the problem but worth noting

2) when selecting System->Konsole from the menu to add to autostart, we are not selecting an Application but a Service (major point)

3) when selecting /opt/trinity/bin/konsole we are selecting an Application

Services are not executable, if you try to double click a .desktop file in /opt/trinity/share/services, you will get an error message saying that the type Service is unknown.
(side note, changing Service to Application in the file, seems to work fine)
Application on the other hand are executable.

Proposed fix (still to be done):
1) fix various bugs in kcmautostart and add crash protection in case a service is selected
2) investigate why a Service is selected for Konsole instead of an Application, since the latter is also avaiable. Once understood, fix it

In the meantime, a workaround is to select the executable file directly from the disk.

Comment 4 Michele Calgaro 2018-04-27 09:56:21 CDT

Commits e5262dc (R14.1) and 6e41dc8 (R14.0) added crash protection to the autostart module when a Service is selected. They also fixes some other crashes and errors and improve code readability.
Still need to fix the Konsole selection though.

Comment 5 Michele Calgaro 2018-04-30 04:31:40 CDT

Commits
- bcdfbb95, c18840c7 (R14.1)
- 35f61f80, 4c0290ec (R14.0)
solves the problem with the service lookup.
Services are now lookup by .desktop file path rather than by name, since multiple desktop files could use the same Name field for different things.

This solves the bug, I can now add Konsole to the autostart manager.

Comment 6 Michele Calgaro 2018-04-30 04:32:05 CDT

@Q4OS, 
please check and let me know if the bug can be closed.

Comment 7 Q4OS Team 2018-05-01 16:36:36 CDT

Works fine now, thanks