By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 2750

Summary:	Konqueror - "Select All" actually invert selection
Product:	TDE	Reporter:	Q4OS Team <q4os>
Component:	tdebase	Assignee:	Slávek Banko <slavek.banko>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugwatch, slavek.banko
Priority:	P5
Version:	R14.0.x [Trinity]
Hardware:	Other
OS:	Linux
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Bug Depends on:
Bug Blocks:	2696
Attachments:	Fix behavior of selectAll and invertSelection in the IconView widget

Description Q4OS Team 2017-02-17 09:10:34 CST

I have found that if I then do an "Menu > Edit > Selection > Select All" it selects all except the file I have selected. I tried manually selecting the first 5 files and then the "Select all" would select everything except the 5 I had selected.

Exact steps to reproduce:
- Fresh TDE stable (14.0.4) installation on Debian Jessie.
- Run Konqueror and navigate to directory containing multiple files.
- Click to any file to select it.
- Click to "Menu > Edit > Selection > Select All"
- Bug: The file(s) selected before becomes unselected.

I argue it could potentially lead to losing some important files from doing this. This is more of an "invert selection" than a "select all".

Comment 1 Slávek Banko 2017-06-24 20:38:22 CDT

The problem come from the commit d82327fe (qt3). The intention was probably to remove from selection items that are hidden (by filter), because the same behavior is also in the list view.

However, the question is: Should be changed the selection of items that are currently hidden (by filter)? Because the same principle should be used to invert the selection as well as to select/deselect by filter.

Should hidden items be removed from the selection even in these other cases? What is your opinion?


In addition, there is another problem - probably more serious: If items are selected but hidden (by filter), tools such as copying, moving, deletion,... is also performed on these hidden items! I guess this is an unexpected behavior!

I think tools should not work with items that are selected but hidden. What is your opinion?

Comment 2 Slávek Banko 2017-06-24 20:48:20 CDT

Created attachment 2781 [details]
Fix behavior of selectAll and invertSelection in the IconView widget

Proposed patch to fix behavior of selectAll and invertSelection in the IconView widget if the items are hidden by the filter. This is the variant with removing items that are hidden by filter from the selection.

Comment 3 Slávek Banko 2017-07-03 17:45:27 CDT

Because there were no opinions, I applied my opinion. Pushed to GIT in hash 5b1f451d (master) and bcd361a8 (r14.0.x).

The same principle was applied to ListView. Selection by mask and behavior of commands over selected items will be fixed subsequently.

Thank you for reporting the problem - it had more impact than at first glance!