| Summary: | KMilo fixing and expanding to control properly for sound level and brightness into generic monitor | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Roman Savochenko <rom_as> |
| Component: | tdeutils | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | bugwatch, deloptes, michele.calgaro, rom_as |
| Priority: | P5 | ||
| Version: | R14.1.x [Trinity] | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| See Also: |
http://bugs.pearsoncomputing.net/show_bug.cgi?id=2782 http://bugs.pearsoncomputing.net/show_bug.cgi?id=2397 |
||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Bug Depends on: | 2781 | ||
| Bug Blocks: | 2247, 3161 | ||
| Attachments: |
KMilo patch for fixing and expanding.
KMilo changes for the KMix master channel treating and slow brightness |
||
Created pull request https://mirror.git.trinitydesktop.org/gitea/TDE/tdeutils/pulls/8 The brightness part of the patch has been reworked and merged to master and R14.0.x branch in https://mirror.git.trinitydesktop.org/gitea/TDE/tdeutils/pulls/21. The part related to mute/unmute needs rework, as well as the patch provided in bug 2782. Will post an update when ready. (In reply to Michele Calgaro from comment #2) > The brightness part of the patch has been reworked and merged to master and > R14.0.x branch in > https://mirror.git.trinitydesktop.org/gitea/TDE/tdeutils/pulls/21. > > The part related to mute/unmute needs rework, as well as the patch provided > in bug 2782. Will post an update when ready. That correction breaks the new KMix DCOP-channel handler "MixerMaster" and will manipulate "Mixer0" which is not the master often! Also you can turn off the display completely for the brightness 0, removing the lower limit 5! > That correction breaks the new KMix DCOP-channel handler "MixerMaster" and will manipulate "Mixer0" which is not the master often! Yes, I am aware of this. The patch in tdeutils#21 is only for the brightness part as I commented. I am working on the part related to mute/unmute, together with bug 2782. The new PR tdemultimedia#19 is the first step, still working on it. Will update and ask you to test when I am ready. > Also you can turn off the display completely for the brightness 0, removing the lower limit 5! Yes, this is done already in the new code. By the way, it seems there may be a bug in TDEPowersave (see comments here https://mirror.git.trinitydesktop.org/gitea/TDE/tdeutils/issues/21#issuecomment-7668 and following). Would you be able to verify if you also get the same values of brightness as explained in the link? > By the way, it seems there may be a bug in TDEPowersave (see comments here
> https://mirror.git.trinitydesktop.org/gitea/TDE/tdeutils/issues/
> 21#issuecomment-7668 and following). Would you be able to verify if you also
> get the same values of brightness as explained in the link?
Yes, I get the same brightness value in KMilo and TDEPowersave, changing that both by the mouse will on the icon in the system tray or directly in the powersave scheme. With my original patch of course.
Great, thanks for checking that Roman. That points to a bug in TDEPowersave since 3 people have the same results :-) This patch is obsoleted by PR tdeutils #26 https://mirror.git.trinitydesktop.org/gitea/TDE/tdeutils/pulls/26 tdeutils#26 has been merged into the master branch. This will be available for the R14.1.0 release. (In reply to Michele Calgaro from comment #8) > tdeutils#26 has been merged into the master branch. This will be available > for the R14.1.0 release. Not completely again for 14.0.9, so KMix master channel treating is broken yet! Created attachment 2994 [details]
KMilo changes for the KMix master channel treating and slow brightness
Adapted for 14.0.9 and appended for the brightness slow changing at Ctrl holding due to removing lower limit in 5%.
Hi Roman, thanks for the code, I have created PRs for inclusion into the master and R14.0 branches. https://mirror.git.trinitydesktop.org/gitea/TDE/tdeutils/pulls/29 https://mirror.git.trinitydesktop.org/gitea/TDE/tdeutils/pulls/30 I am unable to test here. With your screen, does 1% changes in brightness result in actual 1% changes? On my home laptop I remember brightness jumping in intervals of 12.5% each, so just curios to know if the fine tuning is useful with other displays. (In reply to Michele Calgaro from comment #11) > thanks for the code, I have created PRs for inclusion into the master and > R14.0 branches. > > https://mirror.git.trinitydesktop.org/gitea/TDE/tdeutils/pulls/29 > https://mirror.git.trinitydesktop.org/gitea/TDE/tdeutils/pulls/30 OK > I am unable to test here. With your screen, does 1% changes in brightness > result in actual 1% changes? I test all my proposes! And yes, my laptop (ThinkPad T450) is sensible for the brightness changing on 1% level and that is why my first patch has bottom limit in 5%, since on 0% my display completely blackens. The working brightness range on my laptop is [5...20]% and sometime I need get 6,7,8%. Thanks Roman. I know you test your code, never doubted that. I was just trying to have a better understanding, since on my laptops brightness goes in steps of 12.5% and so a 1% increase does not work. But the code will definitely be included, since it will be useful for users who have monitors that support fine control of brightness like you. New code merged to master and R14.0.10 code. Thanks for submitting the patch Roman! |
Created attachment 2778 [details] KMilo patch for fixing and expanding. KMilo now in the generic monitor works only for sound volume control but only through DCOP Id "Mixer0" which is not everything as master card used and more, into modern configurations with PulseAudio it newer uses as the master card. My patch: - Fixes crashing KMilo at key "XF86Search" pressing, and all other launching keys. - Extend for work with the master card exclusively by the DCOP object Id of KMix "MixerMaster". - Extend to control brightness by keys "XF86MonBrightnessUp", "XF86MonBrightnessDown" and through DCOP commands to tdepowersave. For now I have on my notebook proper work of the shortcut keys with notifications from KMilo about the volume state, level and the brightness level.