| Summary: | SIGSEGV in konversation: removeNickFromServer deferences pointer before checking if not null | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Vilem Marsik <tdebugs.20.vm> |
| Component: | tdenetwork | Assignee: | Slávek Banko <slavek.banko> |
| Status: | RESOLVED FIXED | ||
| Severity: | critical | CC: | bugwatch, slavek.banko, tdebugs.20.vm |
| Priority: | P5 | ||
| Version: | R14.0.x [Trinity] | ||
| Hardware: | amd64 | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Bug Depends on: | |||
| Bug Blocks: | 2696 | ||
| Attachments: |
Patch for the SIGSEGV
Patch for the SIGSEGV (1) |
||
Created attachment 2824 [details]
Patch for the SIGSEGV (1)
It seems that the variable wasOnline is nowhere else used in the code, so it can be completely removed - the patch is simplified.
Are you willing to provide a real email address with which I could list you as a patch author?
Fixed in GIT hash 3a934bd3 (master) and d6504c60 (r14.0.x). Thank you for bug report and patch! Thanks for including the patch. (In reply to Slávek Banko from comment #1) > Are you willing to provide a real email address with which I could list you > as a patch author? Not really, I guess none is going to ask me any details about that. |
Created attachment 2823 [details] Patch for the SIGSEGV konversation-14.0.4 on Fedora 26 is crashing in about 1 minute after logging in, on this sequence in server.cpp around line 2330: bool wasOnline = nickInfo->getPrintedOnline(); if (nickInfo && wasOnline) ... The pointer nickInfo is deferenced, before testing if not null. Attached patch seems to have solved the problem.