| Summary: | tdepim/libkpgp the GPG part needs update to gpg2 | ||
|---|---|---|---|
| Product: | TDE | Reporter: | deloptes |
| Component: | tdepim | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugwatch, deloptes, slavek.banko |
| Priority: | P5 | ||
| Version: | R14.0.x [Trinity] | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Bug Depends on: | |||
| Bug Blocks: | 2696 | ||
| Attachments: |
error (decryption failed)
signed mail when knode does not display properly signed mail when knode displays properly signature key exctraction patch signature key exctraction patch signature key exctraction patch signature key exctraction patch |
||
Luckily I could find one such message that is displayed exactly the way it is displayed also in kmail. So it looks like it depends on the way the message is structured. The one that works is -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 [blah blah] -----END PGP SIGNATURE----- The one that doesn't is This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gnknW2V3bf2fYIKGJhjNQYlTCuNkECDjz Content-Type: multipart/mixed; boundary="rwgnE5jUACrJdnaOnspBSDfTe9mt7oV7O"; protected-headers="v1" [blah blah] -----END PGP SIGNATURE----- --gnknW2V3bf2fYIKGJhjNQYlTCuNkECDjz-- Created attachment 2830 [details]
signed mail when knode does not display properly
The signature is displayed as attachment and trying opening it causes gpg to fail
Created attachment 2831 [details]
signed mail when knode displays properly
this is one mail where it is properly displayed
Created attachment 2832 [details]
signature key exctraction patch
old style signature
Example: Signature made Sun 06 May 2001 03:49:27 PM CEST using DSA key ID 12345678
the patch will handle new style signature
Example: Signature made Thu 05 Apr 2018 10:02:50 PM CEST
using DSA key A0CF1DC09533E5E87F54DB40F1EEB8CD9FB16A50
The other problem seems to be related to ftp://ftp.rfc-editor.org/in-notes/rfc3156.txt Created attachment 2833 [details]
signature key exctraction patch
previous patch extended to handle variable key size
// gpg: Signature made Thu 05 Apr 2018 10:02:50 PM CEST
// gpg: using DSA key A0CF1DC09533E5E87F54DB40F1EEB8CD9FB16A50
// gpg: Signature made Mon 02 Apr 2018 03:15:08 PM CEST
// gpg: using DSA key 05C82CF57AD1DA46
Created attachment 2834 [details]
signature key exctraction patch
extends the previous patch with a fix to properly display the user name in the sign/decrypt header. It prevents utf8 double encoding.
this was the last open item on knode I had for now
(In reply to deloptes from comment #7) > Created attachment 2834 [details] > signature key exctraction patch > > extends the previous patch with a fix to properly display the user name in > the sign/decrypt header. It prevents utf8 double encoding. > > this was the last open item on knode I had for now Please, you can test whether the use of TQstring::fromLocal8Bit() will be correct instead of the currently used TQString::fromUtf8()? When "error" is the output from the gpg call, potentially it could be in another encoding => fromLocal8Bit() should be the appropriate choice. Thank you. Created attachment 2842 [details]
signature key exctraction patch
Hi,
yes it works with TQString::fromLocal8Bit().
I was not sure about this, although I thought it might be more appropriate.
thanks for looking into it
Fixed in GIT hash f09192b2 (master) and 724a547c (r14.0.x). Thank you for your good work! |
Created attachment 2829 [details] error (decryption failed) When trying to open signature in knode, I get an error (decryption failed). I just wonder why it does not use gpgme the same as kmail.