By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 2982

Summary:	unable to port qtcurve 1.8.5 for qt3 to tqt
Product:	TDE	Reporter:	TCH <tch>
Component:	qt3	Assignee:	Timothy Pearson <kb9vqf>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugwatch, michele.calgaro, slavek.banko, tch
Priority:	P5
Version:	R14.0.x [Trinity]
Hardware:	All
OS:	Linux
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Bug Depends on:
Bug Blocks:	3085

Description TCH 2018-10-14 04:18:43 CDT

I'm currently trying to port QtCurve 1.8.5 for Qt3 to TQt, but no success.

Here is the archive https://github.com/QtCurve/qtcurve-qt3/archive/1.8.5@3578.tar.gz

Unfortunately it misses the "common" folder, but it can be obtained from the KDE4 folder in the Qt4 version: https://github.com/QtCurve/qtcurve-qt4/archive/1.8.5.tar.gz

Then, here is the replacement "CMakeLists.txt" for the project: https://pastebin.com/c8X0jfEA

Then, the "QtCurveTQt.cmake" for the projects' "cmake" folder: https://pastebin.com/Ws2YasLM

Then, the "FindTQt.cmake" for cmake globally: https://pastebin.com/c8X0jfEA

After that i run my homebrew script for converting Qt3 stuff to TQt. It worked when i ported KDocker, but now i ran into several problems. For example, even the header references are converted properly (qstyle.h => ntqstyle.h), the type "SFlags" is not found.

What is the problem, what did i do in the wrong way? I heard there is an official script for converting Qt3 sources to TQt, but i never found it...

Comment 1 Michele Calgaro 2018-10-14 10:22:53 CDT

Hi there,
the official scripts for renaming is in the "experimental" repo.

/experimental/qt3-tqt3/convert_existing_qt3_app_to_tqt3

As for Qtcurve, it may be good to look at tde-style-qtcurve repo, which is the version of qtstyle currently in TDE (I think 1.2.1).

To have more direct and quick feedback on such conversion, I invite you to join us on TGW, where it is easier to share code and discuss. See:
https://wiki.trinitydesktop.org/TDE_Gitea_Workspace
https://mirror.git.trinitydesktop.org/gitea/

Comment 2 TCH 2018-10-15 12:57:45 CDT

Thanks, i downloaded the script and used it. It converted everything, but it did not proveided a "FindTQt3.cmake" file, i still needed to use mine and i don't know if this is the source of the problem. Is there an official or experimental "FindTQt3.cmake" file? Also it did not convert the "QtCurveQt3.cmake" in the "cmake" directory.

Here is the result of make: https://pastebin.com/HPkyMdeJ

QtCurve in Trinity is 1.6.2.

Thanks i'll join shortly.

Comment 3 Michele Calgaro 2018-10-15 21:37:34 CDT

in TDE there are a series of macros used with CMake. That is why I sugggested you take a look at the current tde-style-qtcurve repo first. In the cmake folder, you will find this macros, there is also a FindTqt.cmake.
The idea is to start from existing repo, replace the code with the new one version, convert the code and try to build. It should be a simpler process.

Comment 4 Slávek Banko 2020-11-28 20:19:54 CST

The update was completed in TGW, where revisions and fine-tuning were performed using pull-requests.