Bug 3013

Hi,

a make cmd gives me:

--------------
CMake Error: The source directory "/media/UTILDISK/UPGRADE/qtcurve18/qtcurve-qt3-1.8.5-3578" does not exist.
Specify --help for usage, or press the help button on the CMake GUI.
Makefile:218: recipe for target 'cmake_check_build_system' failed
make: *** [cmake_check_build_system] Error 1
-------------

I was told that QtCurve is already part of TDE with release 1.6.2.

https://mirror.git.trinitydesktop.org/gitea/TDE/tde-style-qtcurve

How about you make a repo in TGW, clone tde-style-qtcurve and then steadily merge all the changes up to 1.8.5?

(In reply to gregory guy from comment #1)
> Hi,
> 
> a make cmd gives me:
> 
> --------------
> CMake Error: The source directory
> "/media/UTILDISK/UPGRADE/qtcurve18/qtcurve-qt3-1.8.5-3578" does not exist.
> Specify --help for usage, or press the help button on the CMake GUI.
> Makefile:218: recipe for target 'cmake_check_build_system' failed
> make: *** [cmake_check_build_system] Error 1
> -------------

So, cmake stores absolute paths of sources when building, instead of relative ones. I hate building environments... If QtCurve 1.8.5 would use the good old Makefiles, it would be long ported to Trinity.

(In reply to gregory guy from comment #2)
> I was told that QtCurve is already part of TDE with release 1.6.2.
> 
> https://mirror.git.trinitydesktop.org/gitea/TDE/tde-style-qtcurve
> 
> How about you make a repo in TGW, clone tde-style-qtcurve and then steadily
> merge all the changes up to 1.8.5?

What is TGW? But the idea sounds good, thanks.

TGW: TDE Gitea Workspace
https://mirror.git.trinitydesktop.org/gitea/explore/repos

Aren't you tch user?
https://mirror.git.trinitydesktop.org/gitea/tch

If you can't create any repo, ask for to Slavek or Michele, they will add you as a contributor, then you will be able to create repos or forks.

(In reply to gregory guy from comment #4)
> TGW: TDE Gitea Workspace
> https://mirror.git.trinitydesktop.org/gitea/explore/repos
> 
> Aren't you tch user?
> https://mirror.git.trinitydesktop.org/gitea/tch
> 
> If you can't create any repo, ask for to Slavek or Michele, they will add
> you as a contributor, then you will be able to create repos or forks.

Thanks, but i'd prefer to do it offline, i am not familiar with this workspace.

I've already cloned 1.6.2 to my workspace, so now i will put the changes in 1.8.5 into 1.6.2. (Of course after i ran my script on 1.8.5 to replace the old includes and other stuff to new.) I cannot just merge 1.8.5 into 1.6.2 as i would overwrite the TQt stuff with Qt3.

Okay, apparently the QtCurve 1.6.2 in the Trinity repo is broken. CMake gives back this if i try to build it:

============================================================
CMake Error at CMakeLists.txt:52 (include):
  include could not find load file:

    TDEMacros


CMake Error at CMakeLists.txt:57 (include):
  include could not find load file:

    TDESetupPaths


CMake Error at CMakeLists.txt:58 (tde_setup_paths):
  Unknown CMake command "tde_setup_paths".


-- Configuring incomplete, errors occurred!
See also "/media/UTILDISK/UPGRADE/qtcurve18/tde-style-qtcurve/build/CMakeFiles/CMakeOutput.log".
============================================================

The mentioned file is here:
http://oscomp.hu/depot/CMakeOutput.log

Also, what the hell is the difference between the "tqxxx.h" files and the "ntqxxx.h" files?

QtCurve 1.6.2 uses the tqxxx.h files, but if i try to use them in QtCurve 1.8.5, then the FindTQt.cmake i have do not find them.

your cmake folder is probably incomplete.
you might give It a try with a tarball such as this one: 
http://mirror.ppa.trinitydesktop.org/trinity/trinity-r14.0.0/debian/pool/main/t/tde-style-qtcurve-trinity/tde-style-qtcurve-trinity_14.0.6.orig.tar.xz

> Okay, apparently the QtCurve 1.6.2 in the Trinity repo is broken. 
Not, it is not broken. You need to have also the cmake submodule if you want to build it. Those missing macros are defined there. See https://mirror.git.trinitydesktop.org/gitea/TDE/tde-common-cmake

I strongly suggest you learn to use TGW: it may take a bit to get familiar with it, but once you get used to it, you wouldn't want to go back to bugzilla for sharing code. TGW makes the workflow way way easier. It is not a coincidence that it is now the center for the code dev team.

Re automake-cmake, same thing. You may be familiar with automake and not cmake, but cmake is way easier to learn and more powerful. Keep in mind we are slowing migrating all modules to cmake build (thanks Greg :-) )


> what the hell is the difference between the "tqxxx.h" files and the "ntqxxx.h" files?
tqxxx.h files are include files defined in tqtinterface. ntqxxx.h are the actual tqt include files, which are included by the tqxxx.h files. Long story short, long ago there was a plan to support qt3, tqt3 and qt4/tqt4, so tqtinterface was introduced and a lot of files renamed as you see. Now only tqt3 is supported, so in future (after R14.1.0) we may get rid of tqtinterface and simplify the include files structure.

The update was completed in TGW, where revisions and fine-tuning were performed using pull-requests.