| Summary: | QtCurve 1.7.1 backported to Triniry, but no config module and image background does not work | ||
|---|---|---|---|
| Product: | TDE | Reporter: | TCH <tch> |
| Component: | qt3 | Assignee: | Michele Calgaro <michele.calgaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugwatch, michele.calgaro, slavek.banko, tch |
| Priority: | P5 | ||
| Version: | R14.0.x [Trinity] | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.pearsoncomputing.net/show_bug.cgi?id=2936 | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Bug Depends on: | |||
| Bug Blocks: | 3085 | ||
| Attachments: | QtCurve 1.7.1 changes backporting patch for Trinity's QtCurve 1.6.2 | ||
|
Description
TCH
2020-02-15 11:10:28 CST
Thanks TCH, at a first quick look, the patch looks very clean. Good job. I have added you to the list of contributors on TGW since you already have an account there. Could you create a PR with your code? It is much easier to work and discuss further on TGW than on bugszilla :-) See here for a guide o nhow to do that. https://wiki.trinitydesktop.org/TDE_Gitea_Workspace#To_contribute_code_changes PS: I use QtCurve, so I will take a look at merging this patch i nnear future once on TGW. root@Csabi:/tmp/tde-style-qtcurve-1.7.1# git push -u master/tde-style-qtcurve fatal: 'master/tde-style-qtcurve' does not appear to be a git repository fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. --- I copied this ticket to gitea. From your local branch (which should be different from master), try: git push origin HEAD and see if it still gives you an error. In any case I have note yuor issue on TGW, so it won't get overlooked ;-) root@Csabi:/tmp/tde-style-qtcurve-1.7.1# git push origin HEAD Username for 'https://scm.trinitydesktop.org': tch Password for 'https://tch@scm.trinitydesktop.org': remote: invalid credentials fatal: Authentication failed for 'https://scm.trinitydesktop.org/gitea/TDE/tde-style-qtcurve.git/' root@Csabi:/tmp/tde-style-qtcurve-1.7.1# git push origin HEAD Username for 'https://scm.trinitydesktop.org': tch@protonmail.com Password for 'https://tch@protonmail.com@scm.trinitydesktop.org': remote: invalid credentials fatal: Authentication failed for 'https://scm.trinitydesktop.org/gitea/TDE/tde-style-qtcurve.git/' --- No luck. Never mind. Any ideas about the config module not building or why the image as window/menu background is not working? (In reply to TCH from comment #4) > root@Csabi:/tmp/tde-style-qtcurve-1.7.1# git push origin HEAD > Username for 'https://scm.trinitydesktop.org': tch > Password for 'https://tch@scm.trinitydesktop.org': > remote: invalid credentials > fatal: Authentication failed for > 'https://scm.trinitydesktop.org/gitea/TDE/tde-style-qtcurve.git/' > > root@Csabi:/tmp/tde-style-qtcurve-1.7.1# git push origin HEAD > Username for 'https://scm.trinitydesktop.org': tch@protonmail.com > Password for 'https://tch@protonmail.com@scm.trinitydesktop.org': > remote: invalid credentials > fatal: Authentication failed for > 'https://scm.trinitydesktop.org/gitea/TDE/tde-style-qtcurve.git/' > > --- > > No luck. Never mind. Any ideas about the config module not building or why > the image as window/menu background is not working? I don't know how carefully you read the instructions on the TGW wiki page, but the address you used - scm.trinitydesktop.org - is not correct. At this address is a Gitea instance that is read-only for everyone. On the TGW wiki page you can read that you need to use mirror.git.trinitydesktop.org to push your branch. I only read the linked section (https://wiki.trinitydesktop.org/TDE_Gitea_Workspace#To_contribute_code_changes) which did not contain any kind of URL. I've cloned QtCurve from https://scm.trinitydesktop.org/gitea/TDE/tde-style-qtcurve.git/ and had no idea that it is read-only. Thanks for pointing out, next time i'll use the other URL. @tch: I have posted a few comments on TGW about this and need your feedback so that I can merge the patch. Letting you know here in case you don't follow the TGW issue. I do follow, but i had other stuff to do. @TCH: As per bug 2936, Qt 1.8.5 is now part of TDE. The issue with background not working is tracked in https://mirror.git.trinitydesktop.org/gitea/TDE/tde-style-qtcurve/issues/3. Would it be ok to close this bug report off? Yes, please close it. Thanks! |