By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 3120

Summary:	Build issue: tdepim ftbfs on Fedora 32
Product:	TDE	Reporter:	Francois Andriot <albator78>
Component:	tdepim	Assignee:	Michele Calgaro <michele.calgaro>
Status:	RESOLVED FIXED
Severity:	blocker	CC:	albator78, bugwatch, michele.calgaro
Priority:	P5
Version:	R14.0.x [Trinity]
Hardware:	amd64
OS:	Linux
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Bug Depends on:
Bug Blocks:	3085
Attachments:	tdepim: fix ftbfs in libkholidays

Description Francois Andriot 2020-06-04 04:43:25 CDT

Fedora 32 is using GCC 10.0.1 .

libkholidays fails to link with following error:

[ 57%] Linking CXX shared library libkholidays.so
cd /tmp/BUILD.fc32.x86_64/trinity-tdepim-14.0.8/build/libkholidays && /usr/bin/cmake -E cmake_link_script CMakeFiles/kholidays-shared.dir/link.txt --verbose=1
/usr/lib64/ccache/c++ -fPIC -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -DNDEBUG  -DQT_NO_ASCII_CAST -DQT_CLEAN_NAMESPACE -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -DQT_THREAD_SUPPORT -D_REENTRANT -I/usr/include/tqt3 -I/usr/include/tqt -include tqt.h -DQT_NO_ASCII_CAST -DQT_CLEAN_NAMESPACE -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -DQT_THREAD_SUPPORT -D_REENTRANT -include tqt.h -DNDEBUG -Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Wl,--no-undefined -shared -Wl,-soname,libkholidays.so.1 -o libkholidays.so.1.0.0 CMakeFiles/kholidays-shared.dir/kholidays.cpp.o CMakeFiles/kholidays-shared.dir/scanholiday.c.o CMakeFiles/kholidays-shared.dir/parseholiday.c.o CMakeFiles/kholidays-shared.dir/lunarphase.cpp.o  -Wl,-rpath,/opt/trinity/lib64 /opt/trinity/lib64/libtdecore.so.14.0.0 /opt/trinity/lib64/libDCOP.so.14.0.0 /opt/trinity/lib64/libtdefx.so.14.0.0 -ltqt -ltqt-mt -lXrender -lX11 -lc -lz -lidn -lXcomposite -lICE -lSM -lgamin-1 -lutil 
/usr/bin/ld: CMakeFiles/kholidays-shared.dir/parseholiday.c.o:/tmp/BUILD.fc32.x86_64/trinity-tdepim-14.0.8/build/libkholidays/parseholiday.y:73: multiple definition of `kcalin'; CMakeFiles/kholidays-shared.dir/scanholiday.c.o:(.bss+0x10): first defined here
collect2: error: ld returned 1 exit status
make[3]: *** [libkholidays/CMakeFiles/kholidays-shared.dir/build.make:156: libkholidays/libkholidays.so.1.0.0] Error 1
make[3]: Leaving directory '/tmp/BUILD.fc32.x86_64/trinity-tdepim-14.0.8/build'
make[2]: *** [CMakeFiles/Makefile2:7853: libkholidays/CMakeFiles/kholidays-shared.dir/all] Error 2
make[2]: Leaving directory '/tmp/BUILD.fc32.x86_64/trinity-tdepim-14.0.8/build'
make[1]: *** [Makefile:164: all] Error 2
make[1]: Leaving directory '/tmp/BUILD.fc32.x86_64/trinity-tdepim-14.0.8/build'

Comment 1 Francois Andriot 2020-06-04 04:44:48 CDT

Created attachment 2963 [details]
tdepim: fix ftbfs in libkholidays

Simple patch to avoid the FTBFS.

Comment 2 Michele Calgaro 2020-06-08 11:24:37 CDT

Hi Francois, can you create PR in TGW? It is easier to merge and mantains authorship info :-)
thanks.

Comment 3 Michele Calgaro 2020-06-12 02:57:20 CDT

Solved by PR https://mirror.git.trinitydesktop.org/gitea/TDE/tdepim/pulls/41

Comment 4 Michele Calgaro 2020-08-18 00:00:09 CDT

This commit causes a regression as described in bug 3154. Reverting the commit fixed the regression, so I guess we need to find a different solution for this one.

Comment 5 Michele Calgaro 2020-08-19 05:13:30 CDT

tdepim #46 should solve this bug without causing bug 3154.
https://mirror.git.trinitydesktop.org/gitea/TDE/tdepim/pulls/46

Comment 6 Michele Calgaro 2020-08-19 20:21:54 CDT

Solved by the mentionied PR.