By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 3135

Summary:	tdelibs: Missing library paths, libr issue in later builds, write to source directory
Product:	TDE	Reporter:	aneejit1
Component:	tdelibs	Assignee:	Timothy Pearson <kb9vqf>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugwatch, slavek.banko
Priority:	P5
Version:	R14.0.x [Trinity]
Hardware:	Other
OS:	Linux
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Bug Depends on:
Bug Blocks:	3085
Attachments:	Patch for tdelibs for missing libraries, making libr private, source write and other issues

Description aneejit1 2020-06-15 09:45:13 CDT

Created attachment 2976 [details]
Patch for tdelibs for missing libraries, making libr private, source write and other issues

The build environment is Trinity installed to /opt/trinity and TQt3 installed to /opt/trinity/i686-pc-linux-gnu and /opt/trinity/x86_64-unknown-linux-gnu (to allow for 32-bit and 64-bit builds). In this situation, a number of later projects fail to build due to the path for libr having not been specified. Rather than modify all the projects affected by this, the implementation of private linking in tdelibs will resolve the problem for all projects down the line.

Bug 3133 implements the change necessary to provide the LINK_PRIVATE option to tde_add_library. Here, the option will be added to tdeio/CMakeLists.txt to fix the libr issue. Bugs 3123-2137, 3129, and 3131 which were raised to add library paths for libr will be closed.

The attached patch also amends kdoctools/CMakeLists.txt and kdoctools/ConfigureChecks.cmake to cause the write customization/entities/general.entities to happen to the binary directory rather than the source dir and force installation from the binary directory.

dnssd/CMakeLists.txt is amended to include missing include/link directories for avahi-tqt

kglib/CMakeLists.txt adds missing glib link directories makes links private

tdecore/CMakeLists.txt fixes an issue with an attempt to use dcopidl2cpp before it is built by adding a dependency. This occurs when a build is attempted using single tasking rather than multi-tasking.

Comment 1 aneejit1 2020-06-15 09:48:25 CDT

*** Bug 3123 has been marked as a duplicate of this bug. ***

Comment 2 aneejit1 2020-06-15 09:48:59 CDT

*** Bug 3124 has been marked as a duplicate of this bug. ***

Comment 3 aneejit1 2020-06-15 09:49:24 CDT

*** Bug 3125 has been marked as a duplicate of this bug. ***

Comment 4 aneejit1 2020-06-15 09:49:49 CDT

*** Bug 3126 has been marked as a duplicate of this bug. ***

Comment 5 aneejit1 2020-06-15 09:50:19 CDT

*** Bug 3127 has been marked as a duplicate of this bug. ***

Comment 6 aneejit1 2020-06-15 09:50:40 CDT

*** Bug 3129 has been marked as a duplicate of this bug. ***

Comment 7 aneejit1 2020-06-15 09:51:10 CDT

*** Bug 3131 has been marked as a duplicate of this bug. ***

Comment 8 Slávek Banko 2020-06-15 10:36:18 CDT

Please, can you do it as a pull-request in TGW instead of the patch in the Bugzilla attachment? This will make it easier to review the patch before merging. For example, changing the linking of the 'libr' library seems out of date to the current code.

Please, the change for docbook entities should be at least as a separate commit, possibly a separate pull-request. I'm not sure if this will work well during the generation of documentation within the build of tdelibs as such, when the data files for the docbook are read from the directory in the source code => ie without added entities related to the TDE version.

Comment 9 Slávek Banko 2020-06-23 04:57:33 CDT

Fixed by TDE/tdelibs#89 - https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/pulls/89