By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 387

Summary: Kicker/Panel Clock Font Display Looks Weird
Product: TDE Reporter: Darrell <darrella>
Component: tdebaseAssignee: ammo42 <monqpourbsd-linuxfr>
Status: RESOLVED FIXED    
Severity: normal CC: bugwatch, darrella, kb9vqf
Priority: P2    
Version: 3.5.13 [Trinity]   
Hardware: All   
OS: All   
Compiler Version: TDE Version String:
Application Version: Application Name:
Attachments: Eliminate the calls to the kshadowengine: reverts partially to KDE 3.5.10 code
Corrected patch

Description Darrell 2010-12-13 09:56:49 CST 
I have user accounts configured with the clock configured in the kicker/panel as Plain Clock (text) using the format H:MM a/pm. Font style is Regular.

With some user accounts, the clock font uses a shadow outline. Yet other accounts the font text looks the same as in KDE 3.5.10 with no shadow outline.

When I enable the date and day of week, that part of the clock display does not contain a shadow or outline. Only the time portion of the display.

I can toggle between Trinity and KDE and the outline/shadow appears only in Trinity.

The effect is caused by enabling Transparency in the Panel configuration: Appearance, Panel Background, Enable Transparency.

When Transparency is enabled, the clock font then displays with a shadow. The shadow color is set by the Tint option in the Advanced section.

This does not happen in KDE. I can toggle Transparency in KDE and the clock font remains normal. Perhaps this is a bug in KDE. Regardless, the effect in Trinity is somewhat irritating.

Workarounds include: changing the color of the clock font to the same as the Tint color or vice-versa, change the Transparency Tint color to that of the clock font. Another workaround is not to use Transparency, which is why some user accounts saw the problem and some did not. Not all accounts use Transparency.

The workarounds are doable, but chintzy. :)

A better approach is to provide an option to enable/disable Tinting.
Comment 1 ammo42 2011-11-22 20:07:39 CST 
Created attachment 153 [details]
Eliminate the calls to the kshadowengine: reverts partially to KDE 3.5.10 code

I couldn't test the patch since the system I am currently on has outdated SVN kdelibs on which kdebase 3.5.13 doesn't build. But the clock.{h,cpp} files seem to build, the build failure is near the end and in another place.
Comment 2 Darrell 2011-11-23 16:40:04 CST 
I could not get your specific patch to merge. I made my own using yours as a template. The build failed:

==================================
make[2]: Entering directory `/dev/shm/kdebase.build'
/usr/bin/cmake -E cmake_progress_report /dev/shm/kdebase.build/CMakeFiles
[ 61%] Building CXX object kicker/applets/systemtray/CMakeFiles/systemtray_panelapplet-module.dir/systemtrayapplet.cpp.o
cd /dev/shm/kdebase.build/kicker/applets/systemtray && /usr/bin/c++   -Dsystemtray_panelapplet_module_EXPORTS -DHAVE_CONFIG_H -O2 -march=i486 -mtune=i686  -DQT_NO_ASCII_CAST -DQT_CLEAN_NAMESPACE -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -DQT_THREAD_SUPPORT -D_REENTRANT -include tqt.h -fPIC -I/dev/shm/kdebase.build/kicker/applets/systemtray -I/dev/shm/kdebase.build/kicker/libkicker -I/dev/shm/kdebase/kicker/libkicker -I/opt/trinity/include -I/dev/shm/kdebase.build/kicker/applets/clock -I/dev/shm/kdebase/kicker/applets/clock   -o CMakeFiles/systemtray_panelapplet-module.dir/systemtrayapplet.cpp.o -c /dev/shm/kdebase/kicker/applets/systemtray/systemtrayapplet.cpp
/dev/shm/kdebase/kicker/applets/systemtray/systemtrayapplet.cpp: In member function 'void TrayEmbed::ensureBackgroundSet()':
/dev/shm/kdebase/kicker/applets/systemtray/systemtrayapplet.cpp:1189: error: variable 'QImage bgImage' has initializer but incomplete type
/dev/shm/kdebase/kicker/applets/systemtray/systemtrayapplet.cpp:1189: error: invalid use of incomplete type 'struct QImage'
/opt/trinity/lib/qt3-3.3.8.d/include/qwindowdefs.h:77: error: forward declaration of 'struct QImage'
make[2]: *** [kicker/applets/systemtray/CMakeFiles/systemtray_panelapplet-module.dir/systemtrayapplet.cpp.o] Error 1
make[2]: Leaving directory `/dev/shm/kdebase.build'
make[1]: *** [kicker/applets/systemtray/CMakeFiles/systemtray_panelapplet-module.dir/all] Error 2
make[1]: Leaving directory `/dev/shm/kdebase.build'
make: *** [all] Error 2
==================================
Comment 3 ammo42 2011-12-08 16:13:15 CST 
Created attachment 216 [details]
Corrected patch

This patch should build, it just adds a missing #include compared to the previous one.
Comment 4 ammo42 2011-12-08 16:21:59 CST 
The tinting seems to have disappeared (at least for me); however the patch doesn't enable the option to enable the tinting again, since it just reverts the code to the KDE 3.5.10 one.
Comment 5 Darrell 2011-12-08 19:02:47 CST 
Patch builds on Slackware 13.1 and the shadow effect is gone.

Works for me!

Tim:

When merging this patch be aware the shadow effect is gone. There is no option in the panel configuration for those who want to enable the shadow effect. Although this patch satisfies some people, like me :), others will be unhappy. A more appropriate long-term solution is to satisfy both crowds with a check box option.
Comment 6 Timothy Pearson 2013-04-03 21:12:13 CDT 
Fixed in GIT hash 48c5586, with option to enable/disable the shadow included.  The clock is more consistent with the rest of TDE without the shadow enabled, therefore the shadow is now off by default.

Thanks for reporting, and for the initial patch!