By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 392

Summary:	Desktop Device Icon Placement
Product:	TDE	Reporter:	Darrell <darrella>
Component:	tdebase	Assignee:	Timothy Pearson <kb9vqf>
Status:	RESOLVED FIXED
Severity:	major	CC:	bugwatch, darrella, slavek.banko
Priority:	P1
Version:	3.5.13 [Trinity]
Hardware:	All
OS:	All
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Attachments:	A screen grab or the icon placement. A screen grab or the icon placement. Patch to fix device icon placement

Description Darrell 2010-12-19 10:07:19 CST

When enabling any of the Desktop device Icons such as My Documents, My Network, Printers, etc., the icon always first appears on the left side of the desktop (expected) but always in the second row of the icon grid (not expected). The icons do not appear vertically.

Looks slap-happy.

This is with an existing kde profile from KDE 3.5.10.

Seems the icons should appear vertically for the first time used.

Comment 1 Darrell 2011-12-20 15:29:53 CST

This has become more frustrating in 3.5.13.

First, no device icons appear on the desktop unless triggered by a device event, such as inserting a CD/DVD or a USB device. Refer to Bug Report 385.

Second, the placement is always with respect to the second horizontal grid row. Each new device icon appears to the horizontal right of the previous icon.

I prefer my icons to appear in the first vertical column, below any existing icon. Is this configurable in any way? If not, where in the source code is this horizontal placement happening? That never was the default behavior in 3.5.10.

Third, when a device is removed, the desktop refreshes and all device icons get moved to the second horizontal grid row rather than remaining in the first vertical column despite being manually placed there.

The horizontal placement is frustrating because any app that is open that covers most of the desktop, such as Konqueror or Konsole, obscures the event of the icon appearing on the desktop. With vertical placement in the first vertical grid column, that never was an issue as I always could see the icon appear.

The problem reported in report 385 compounds the issue.

Comment 2 Darrell 2012-01-27 20:27:37 CST

*** Bug 306 has been marked as a duplicate of this bug. ***

Comment 3 Darrell 2012-02-02 14:46:54 CST

Created attachment 318 [details]
A screen grab or the icon placement.

Comment 4 Darrell 2012-02-04 11:38:21 CST

My latest testing results, now that both HAL and GAMIN support are part of the build process:

As before, the desktop device icons appear in the second horizontal row. When I manually move the icon to the first vertical row (the way the icons appeared in 3.5.10), the popup context menu no longer shows the options to eject (CD/DVD), unmount, or safely remove (USB). Those options appear only when I leave the icon in the second horizontal row.

Further, when I unmount a floppy, actually unmount any device, but leave the media connected or installed, the icon automatically moves to the second horizontal row.

I wish we could restore the placement behavior of 3.5.10. :)

Comment 5 Darrell 2012-02-04 11:52:17 CST

Created attachment 330 [details]
A screen grab or the icon placement.

Comment 6 Darrell 2012-03-06 19:57:58 CST

In tdebase/kdesktop, there are several files with new functions such as findPlaceForIcon, findPlaceForIconRow, findPlaceForIconCol. I can see serious effort went into adding those functions, but I don't know the big picture why they were added.

I suspect that is where the behavior changed to placing the icons only in the second row, left to right.

The original 3.5.10 placement, and in most desktops, first left-hand column, top to bottom, and continuing placements at the top of the second column, top to bottom, etc.

Comment 7 Darrell 2012-03-15 23:45:17 CDT

I believe the change in icon placment behavior is caused by a set of OpenSuse patches merged Sept. 3, 2010 (GIT hash 27856879bf962f178d88e79144e37a47e731b122).

Comment 8 Darrell 2012-03-21 15:12:34 CDT

Created attachment 500 [details]
Patch to fix device icon placement

The attached patch restores a snippet of code removed through GIT hash 27856879bf962f178d88e79144e37a47e731b122, Sept. 3, 2010, "Massive import of OpenSUSE patches."

Restoring the snippet resolves the device icon placement problem. Device icons once again are sanely placed at the bottom of the left-most column with empty space at the bottom.

Upon pushing this patch to GIT this bug report may be considered resolved.

Comment 9 Darrell 2012-03-22 15:15:08 CDT

Patch pushed to GIT in hash 5df6c5fca20e917aaa82665131b931a0aa7c8628.

Patch tested. Device icons once again are sanely placed at the bottom of the left-most column with empty space at the bottom.

Patch peer reviewed by Calvin.

This resolves the bug report!