By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 455

Summary:	[patch] Storage media applet buttons are too large
Product:	TDE	Reporter:	Aleksey Midenkov <midenok>
Component:	tdebase	Assignee:	Timothy Pearson <kb9vqf>
Status:	NEEDINFO ---
Severity:	normal	CC:	bugwatch, darrella, kb9vqf, midenok
Priority:	P5
Version:	3.5.13.x [Trinity]
Hardware:	Other
OS:	Linux
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Bug Depends on:
Bug Blocks:	2968
Attachments:	Patch before.png after.png Patch Patch Cleaned up version of patch Applies against latest GIT Missing files

Description Aleksey Midenkov 2011-03-09 08:50:12 CST

The icons in storage media applet are sized according to a panel size. If the panel is large the icons are too unnormally large. In our era of widescreen format and small displays the better place for taskbar is on the left side. Or the right side (though I hardly can imagine a man preferring the right side over the left side). Please, look at the before.png attached here. It's my typical taskbar (placed on the left side of my notebook screen as you already know). As you see the 3 icons are enormous. This is our hero -- storage media applet! Now I have about 10 partitions on one flash, and you guess what a disaster it makes to the taskbar.

I have made the patch which places buttons into a grid just like in quicklauncher applet (just look after.png). The size can be configured or made auto as in quicklauncher. The other change is that the context menu is moved to the right button as where it should always be. By the left mouse button the media is opened.

I had huge compilation problems (maybe because I compiled on debian, not ubuntu). I moved libkicker_core and libkicker_ui to dynamic library because they are static and self-dependent. The other solution was to enclose them in -Wl,--start-group -Wl,--end-group. But this is impossible for libtool for now.

And before applying the patch please do this command:

svn mv kicker/applets/launcher/flowgridmanager.* kicker/libkicker/

P.S. Btw this was not fixed in KDE4 a year ago. And it has even more UI blunders. This is sad to see how lots of people are toiling on some cool cross-fading effects leaving behind the elementary rules of where to place buttons and how to organize dialogs.

Comment 1 Aleksey Midenkov 2011-03-09 08:52:16 CST

Created attachment 56 [details]
Patch

Comment 2 Aleksey Midenkov 2011-03-09 08:53:30 CST

Created attachment 57 [details]
before.png

Comment 3 Aleksey Midenkov 2011-03-09 08:53:53 CST

Created attachment 58 [details]
after.png

Comment 4 Timothy Pearson 2011-03-09 08:59:38 CST

This looks like a very good idea and start!

However, I think the attached patch may have some problems, as it is attempting to completely remove the flowmanager C and H files.  Is this intended behaviour?

Thanks!

Comment 5 Aleksey Midenkov 2011-03-09 09:41:35 CST

Created attachment 59 [details]
Patch

Mmm, the patch was done by 'svn diff' command. I were too lazy to create the proper patch, pardon...  Attached the new patch which is appliable now.

Comment 6 Aleksey Midenkov 2011-03-09 09:49:35 CST

Created attachment 60 [details]
Patch

And somehow missed admin/...

Attached again. This fixes krandr compilation which is not related to the task of course. But could be helpful...

Comment 7 Timothy Pearson 2011-03-09 09:49:53 CST

OK, that looks better.  I'll run this by the other dev team members, and if they also approve it will be committed to SVN.

Thanks!

Comment 8 Aleksey Midenkov 2011-07-03 07:08:08 CDT

Thanks! Any news on that patch?

Comment 9 Timothy Pearson 2011-07-05 15:11:49 CDT

(In reply to comment #8)
> Thanks! Any news on that patch?

Not yet.  We are now entering the bug fixing phase of 3.5.13 and I would expect action on this bug soon.

Comment 10 Timothy Pearson 2011-10-23 17:18:01 CDT

Just to give a status update--we have not forgotten about this patch.  It is difficult to determine its full impact to the Trinity codebase due to its size, and therefore it is difficult to integrate into SVN.

I will see what I can do with it for the next release.

Comment 11 Timothy Pearson 2012-01-10 17:13:18 CST

Sorry, clicked on the wrong importance item in the drop-down.

Comment 12 Timothy Pearson 2012-01-11 18:57:26 CST

Beginning to dissect this patch for possible inclusion in R14.0.

The patch moves kicker/applets/launcher/flowgridmanager.* to libkicker/
This will require a CMake files update.

Comment 13 Timothy Pearson 2012-01-11 19:01:21 CST

Created attachment 265 [details]
Cleaned up version of patch

Patch is now more manageable; just remember that the flowmanager files need to be moved.

Comment 14 Timothy Pearson 2012-01-11 19:14:08 CST

Created attachment 266 [details]
Applies against latest GIT

Same as above, but applies against latest GIT tree

Comment 15 Timothy Pearson 2012-01-11 23:43:40 CST

I am missing the following files:

preferences_page.ui
mediaprefsdlg.cpp
mediaprefsdlg.h
prefs.kcfgc

Please attach them to this bug report.

Comment 16 Darrell 2013-04-13 14:57:17 CDT

Is the problem still valid? Was the patch pushed to GIT?

Comment 17 Darrell 2013-04-13 15:01:22 CDT

Oops. Too quick. The icons looks fine on my system regardless of the panel size I select.

Comment 18 Timothy Pearson 2013-04-13 15:04:15 CDT

(In reply to comment #16)
> Is the problem still valid? Was the patch pushed to GIT?

I never received the required files.  The problem with the panel buttons persists; essentially if I have a 128-pixel high taskbar, then the panel buttons will try to take up 128 pixels of horizontal real estate *each*.  This is definitely still a bug!

Comment 19 Darrell 2013-04-13 15:14:29 CDT

Okay. :) I'm just trying to clean house!

Comment 20 Aleksey Midenkov 2013-05-14 04:15:03 CDT

Created attachment 1277 [details]
Missing files

Sorry for late reply. Here are missing files (media.tar.bz2).

Comment 21 Darrell 2013-08-17 20:09:02 CDT

Any progress with this report?