| Summary: | Patches required to build qt3 on Slackware | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Darrell <darrella> |
| Component: | qt3 | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | bugwatch, darrella, f.couperin |
| Priority: | P5 | ||
| Version: | 3.5.13 [Trinity] | ||
| Hardware: | Other | ||
| OS: | Slackware 13 | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Attachments: |
mysql.h patch
libpng14 patch popen leak fix qcstring format warnings patch qt3 warnings patch x11 patch mysql.h: Replace previous patch that was a gzip file x11-diff: Replace previous patch that was a gzip file |
||
|
Description
Darrell
2011-11-17 13:17:18 CST
Additionally, I need to run the following snippet in my build script: if [ -f /usr/include/mysql/mysql.h ] && [ ! -L /usr/include/mysql.h ]; then (cd /usr/include; ln -s mysql/mysql.h mysql.h) fi Created attachment 185 [details]
mysql.h patch
Patch added as an attachment rather than a link that might disappear.
Created attachment 186 [details]
libpng14 patch
Patch added as an attachment rather than a link that might disappear.
Created attachment 187 [details]
popen leak fix
Patch added as an attachment rather than a link that might disappear.
Created attachment 188 [details]
qcstring format warnings patch
Patch added as an attachment rather than a link that might disappear.
Created attachment 189 [details]
qt3 warnings patch
Patch added as an attachment rather than a link that might disappear.
Created attachment 190 [details]
x11 patch
Patch added as an attachment rather than a link that might disappear.
(In reply to comment #3) > Created attachment 186 [details] > libpng14 patch > > Patch added as an attachment rather than a link that might disappear. It seems to me that 3.5.13 and git versions are already patched for libpng 1.4 Created attachment 260 [details]
mysql.h: Replace previous patch that was a gzip file
Created attachment 261 [details]
x11-diff: Replace previous patch that was a gzip file
Regarding Comment 1 about the sym link, I don't think that is a problem any longer. Comment on attachment 186 [details]
libpng14 patch
qt3-png14.patch was applied in a more general form to qt3 some time ago
Comment on attachment 187 [details]
popen leak fix
qt3-popen-leak-fix.diff committed in GIT hash 540da17
Comment on attachment 188 [details]
qcstring format warnings patch
qt3-qcstring-format-warnings.diff committed to GIT in hash ce82c99.
Comment on attachment 188 [details]
qcstring format warnings patch
qt3-qcstring-format-warnings.diff committed to GIT in hash ce82c99.
Comment on attachment 189 [details]
qt3 warnings patch
qt3-warnings.diff was already repaired in GIT some time ago
The remaining two patches (mysql.h and x11-diff) appear to be distribution specific. All others were committed to GIT or had been already repaired in GIT when this bug report was processed. Thanks for reporting, and for the patches! This is great! Regarding the mysql.h patch and based on several recent patches, could the solution be to have the configfure process look for the header file in the mysql subdirectory? In Slackware the header files are installed at /usr/include/mysql. The mysql files are also in /usr/include/mysql on Ubuntu and Debian, so the question becomes why Slackware is failing to build while Ubuntu/Debian build just fine. As there is no distribition-agnostic patch available (yet) I'm marking this bug NEW instead of PATCHAVAIL. If this changes it can be marked PATCHAVAIL again. Okay, nice to know. I'll look at your build script. I hope I'll see a difference. Any other ideas how to troubleshoot? I just built qt3 again. Without the mysql.h header patch. No build failures. I added the -I/usr/include/mysql configure option, which I discovered several days ago. As far as I can tell between two build logs, qt3 built with mysql support without the patch and the log file sizes are almost the same. I'm guessing the patch is a carryover from many years ago. Nobody ever cared to look into why the patch was needed. Perhaps at one time in the early days of Qt3 the patch was needed because there was no -I/usr/include/mysql configure option. Who knows. Are there any tests I can run to validate that qt3 built properly with mysql support? Regarding the remaining patch to set the QT_BUILTIN_GIF_READER variable to true in qgif.h, reading the comments at the beginning of that header file provides a probable clue why people at one time patched the file. At one time GIF support was crippled with patents and Qt3 provides built-in GIF support to avoid that old problem. I suspect sometime after that original suggestion to patch, the Qt devs added the configure option qt-gif, which enables built in GIF support. With that configure option I'm guessing the patch to the QT_BUILTIN_GIF_READER variable no longer is needed. The patching advice probably is now only a carryover from days gone by. The new package does contain plugins/sqldrivers/libqsqlmysql.so, as well as many qsql*.h header files. I'm guessing mysql support built? Otherwise I'm guessing we can tag this bug report as resolved. > The new package does contain plugins/sqldrivers/libqsqlmysql.so, as well as > many qsql*.h header files. I'm guessing mysql support built? Yes. > > Otherwise I'm guessing we can tag this bug report as resolved. Done. Thanks for running those tests! |