By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 681

Summary:	Add a KControl option/check box to show/not show the exiting "Saving Your Settings" dialog.
Product:	TDE	Reporter:	Darrell <darrella>
Component:	tdebase	Assignee:	Darrell <darrella>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	bugwatch, darrella, ignaz.forster, slavek.banko
Priority:	P1
Version:	R14.0.0 [Trinity]
Hardware:	Other
OS:	All
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Bug Depends on:	258
Bug Blocks:
Attachments:	Patch to add a check box control in KControl Updated patch to add a check box control in KControl Patch to add a check box control in KControl

Description Darrell 2011-11-22 23:47:45 CST

Some people like the dialog and some don't. Best option is to let the user decide. :)

Comment 1 Darrell 2011-11-22 23:54:51 CST

Probably the session management section is a good location. :)

Comment 2 Darrell 2012-03-31 20:59:27 CDT

Providing a solution to this bug report will help resolve bug report 922 as well.

Comment 3 Darrell 2012-04-06 18:57:47 CDT

Much like bug report 258, the underlying support already exists. The configuration option key name is showFancyLogout, and is stored in $TDEHOME/share/config/ksmserver, group [Logout].

Unlike bug report 258, resolving this bug report only requires adding a check box in KControl and respective readEntry and writeEntry support.

The key name is confusing because in that same configuration file and [Logout] group, there also is a key name doFancyLogout that controls the gray fading effect when confirmLogout=true.

I am in favor of changing the key name from showFancyLogout to showFeedbackDlg.

Comment 4 Darrell 2012-04-06 22:24:30 CDT

Created attachment 522 [details]
Patch to add a check box control in KControl

This patch provides the requested check box control and changes the ksmserver key name to reduce confusion against the original doFancyLogout key name.

Comment 5 Darrell 2012-04-07 14:20:41 CDT

I likely will not push this to GIT immediately after somebody tests the patch.

Calvin is working on bug report 258, which will provide KControl controls for configuring the logout gray fade effect. When those controls are completed, the check box for controlling the feedback dialog should be grouped with those controls.

Comment 6 Darrell 2012-04-12 14:44:46 CDT

Created attachment 536 [details]
Updated patch to add a check box control in KControl

Comment 7 Slávek Banko 2012-05-20 12:15:14 CDT

Created attachment 627 [details]
Patch to add a check box control in KControl

Updated in line with commit d2f8fca9.

Comment 8 Darrell 2012-05-20 18:43:07 CDT

Ha! Beat me to the punch. :-) I had an updated patch ready but was waiting for the Trinity server to return.

Comment 9 Darrell 2012-06-08 19:37:08 CDT

I'm going to push this patch to GIT.

Tim, please note the name of the dialogs and config file keys change with this patch. The reason is to better match the GUI description and then to avoid too much "showFancyWhatever" names with Calvin's patch. I write this so you don't get confused the next time you patch something in the vicinity and no longer can find "showFancyWhatever." :-)

Calvin is working on a patch for bug report 258. The eventual idea is to group the GUI controls together from both patches. We can still do that, but let's just get this patch into the system and out of the way.

Comment 10 Darrell 2012-06-08 21:05:57 CDT

Pushed in GIT hash 8a61818a. This resolves the bug report.