| Summary: | Build issue: KOffice: FTBFS with ruby 1.9.1 installed | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Darrell <darrella> |
| Component: | non-core programs | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugwatch, darrella, slavek.banko |
| Priority: | P1 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | Other | ||
| OS: | Other | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=243565 | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | 3.5.13 | Application Name: | KOffice |
| Attachments: |
Partial patch to build with ruby 1.9.1
Patch to build with both ruby 1.9.1 and 1.9.3 Fix build on Ruby 1.9.x without pkgconfig file Fix build on Ruby 1.9.x without pkgconfig file - part 2 |
||
Some of the header files that are part of the includes no longer exist in ruby 1.9.x, such as env.h. Some are deprecated. Broken, broken, broken. :) Ruby support will likely have to be dropped, as 1.9 might as well be different language entirely where the C++ bindings are concerned: http://push.cx/developer-day-notes-4-a-ruby-19-case-study-on-upgrading-rcov That's fine by me. We need to fix the build messages so people understand that the problem is not ruby is not installed but support for versions beyond 1.8 are not supported. I'd like to see serious attention given to bug report 464 to split the packages into individual components. koffice just takes too long to build and troubleshooting is a PITA when the breakage occurs an hour and 20 minutes into the build. With that said, chalk seems to be the most problematic for building. Too many external dependencies and those dependencies are moving targets where developers of those projects don't care what downstream packagers need to do to stay current. Does all ruby 1.9 support get dropped? tdebindings and amarok depend upon ruby and they build fine with ruby 1.9 as long as the build process can find the ruby headers --- a point that needs to be addressed for the entire project. The particular problem with koffice ruby dependency is the missing header files. The following header files no longer exist: env.h node.h version.h The following header files have been moved: rubysig.h (moved to ruby/backwards/) st.h (moved to ruby/backwards/) The patch proposed here still works but the primary problem is specifically chalk using ruby header files that no longer exist. I don't know what else in koffice uses ruby but we should merge the patch and then revise the chalk make files to not build with ruby or rework how those missing ruby header files are used. Similar patching to that made with tdebindings is required to build koffice with ruby 1.9.3. Version 1.9.3 uses a pkgconfig pc file whereas 1.9.1 does not. Patching to use the pc file probably will not resolve the problem of the missing header files: env.h node.h version.h We aren't alone with this problem...the KDE "sister" bug to this one has been languishing for over 2 years now! I pushed a preliminary patch in GIT hash cc27883 that addresses some of the build problems. The kross Ruby code is a MESS. I strongly suspect that it never worked properly or was even completed (!), and I am not going to put much work into it beyond making sure that it compiles in some form. I think our best long-term approach is two-fold: 1. Strip ruby support from koffice. 2. Resolve enhancement request 464 to split KOffice into individual packages. With the success of libreoffice, and the related support for kdialog with Trinity patching, I don't see an overwhelming demand for the main koffice apps. We don't abandon them, but I see a slightly higher demand for the smaller apps in koffice. By splitting into individual apps we allow packagers to decide. Splitting into packages will help us more quickly resolve koffice problems because we can focus on patching the specific app. Testers can more easily test without rebuilding the entire suite, which takes about 1 hour and 40 minutes on my system. Possibly as project leader post a request to the mail list asking for experience with such repackaging and to ask people to help with bug report 464. In the past I seem to recall some Arch people having split koffice into component packages. So this has been done, we just need experience to help Phase 1 would be to post information how to build separate packages with the existing source tree. Phase 2 would be to move the files into new source tree modules. Created attachment 874 [details]
Patch to build with both ruby 1.9.1 and 1.9.3
This patch is a copy of the same patch for tdebindings in commit 2712dc64 from 2012-09-30. Without the patch koffice FTBFS on Slackware 14 with ruby 1.9.3. With the patch koffice builds there and also builds without incident in Slackware 13.1 with ruby 1.9.1.
Created attachment 899 [details]
Fix build on Ruby 1.9.x without pkgconfig file
I modified the patch 115acc39 from tdebindings also for KOffice.
Ah, you must have read my mind. :) I had a note to myself to update the patch. Thanks. :) I have tested both patches in 32-bit with ruby 1.9.1 and 64-bit with ruby 1.9.3. No problems. Patch in attachment 874 [details] pushed to GIT in commit e1592357. Patch in attachment 899 [details] pushed to GIT in commit fc0c74f6. That still leaves the problem of the missing ruby include files in 1.9.3: env.h node.h version.h Also the libwpd-0.9 problems addressed in bug report 1169. Created attachment 940 [details]
Fix build on Ruby 1.9.x without pkgconfig file - part 2
I found that with ruby 1.9.x without pkgconfig file was missing settings RUBY_ENABLESHARED and publishing RUBY_LIBRUBYARG. With the attached patch works for me building with original ruby 1.9.x from Quantal.
Please test and approve.
I did not (yet) build the full package, but the patch resolves a problem I had been noticing lately with the configuration not finding the ruby shared library and hence, not building with ruby support. Probably the same problem you noticed that prompted you to make the patch. Go ahead and push the patch. :) Patch from attachment 940 [details] pushed to GIT in hash e566a4be.
|
Created attachment 218 [details] Partial patch to build with ruby 1.9.1 KOffice FTBFS with ruby 1.9.1 installed. I have a partial patch, but others will have to finish as I don't know ruby or C++.