By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 783

Summary: Build issue: Poppler support is always enabled in koffice/chalk build process
Product: TDE Reporter: Francois Andriot <albator78>
Component: non-core programsAssignee: Timothy Pearson <kb9vqf>
Status: RESOLVED FIXED    
Severity: blocker CC: bugwatch, darrella, slavek.banko
Priority: P5    
Version: 3.5.13 [Trinity]   
Hardware: All   
OS: Linux   
Compiler Version: TDE Version String:
Application Version: Application Name:
Attachments: Fix poppler detection in chalk

Description Francois Andriot 2012-01-08 04:07:25 CST
Created attachment 259 [details]
Fix poppler detection in chalk

Hello, there must be a good reason for that, but I do not know which :)
The poppler support is always enabled for chalk, even when poppler is not available on the building computer. This looks like a quick workaround.

Look at file: koffice/filters/chalk/pdf/configure.in.in

See attached patch to restore the original poppler-qt detection.
Comment 1 Darrell 2012-02-03 23:29:01 CST
This patch no longer works in GIT. That is, the patch probably works, but poppler support in chalk no longer is built, I am receiving this configure message:

You're missing libpoppler 0.5.1 or later (binaries and/or headers).
chalk won't be able to import pdf
note that the qt-binding of libpoppler is required

With GIT I no longer rebuild poppler to include Qt3 support because that was thought to no longer be needed in TDE. Yet I'll take a guess that a poppler-tqt layer like that in tdegraphics/kfile-plugins/dependencies is needed?

This is a build failure so I am bumping to blocker.
Comment 2 Timothy Pearson 2012-06-12 18:06:34 CDT
This should now be fixed via the addition of a .pc file for poppler-tqt to tdegraphics, and an associated update to the koffice build system.

In all likelihood You will need to export PKG_CHECK_MODULES=/<tde_prefix>/lib/pkgconfig/:$PKG_CHECK_MODULES before your build.

Let me know if you run into any problems after a tdegraphics rebuild/reinstall!
Comment 3 Timothy Pearson 2012-06-12 18:08:19 CDT
(In reply to comment #0)
> Created attachment 259 [details]
> Fix poppler detection in chalk
> 
> Hello, there must be a good reason for that, but I do not know which :)
> The poppler support is always enabled for chalk, even when poppler is not
> available on the building computer. This looks like a quick workaround.
> 
> Look at file: koffice/filters/chalk/pdf/configure.in.in
> 
> See attached patch to restore the original poppler-qt detection.

Committed to GIT in hash 11a4c24.  Not sure why that was there. :-)
Comment 4 Timothy Pearson 2012-06-12 18:12:30 CDT
(In reply to comment #2)
> This should now be fixed via the addition of a .pc file for poppler-tqt to
> tdegraphics, and an associated update to the koffice build system.
> 
> In all likelihood You will need to export
> PKG_CHECK_MODULES=/<tde_prefix>/lib/pkgconfig/:$PKG_CHECK_MODULES before your
> build.
> 
> Let me know if you run into any problems after a tdegraphics rebuild/reinstall!

That should be PKG_CONFIG_PATH, not PKG_CHECK_MODULES.  Never copy+paste without looking! :-)
Comment 5 Timothy Pearson 2012-06-25 22:32:53 CDT
As koffice builds fine here with the patch, I am closing this bug as RESOLVED FIXED.

Thanks for reporting!
Comment 6 Slávek Banko 2012-06-26 20:21:08 CDT
(Odpověď na komentář #4)
> That should be PKG_CONFIG_PATH, not PKG_CHECK_MODULES.  Never copy+paste
> without looking! :-)

I have another solution - handier:
When in koffice instead of

 PKG_CHECK_MODULES (POPPLER...

you use

 KDE_PKG_CHECK_MODULES(POPPLER...

then there is no need to adjust PKG_CONFIG_PATH in the makefile.
Successfully tested in v3.5.13-sru ;)