Bug 791

Created attachment 734 [details]
Akode 2.0.2: adds pulseaudio support (patch from Fedora 9)

Hello, in case you still want to build akode for your distro, here are the patches I'm using to do so.

Created attachment 735 [details]
Akode 2.0.2: adds multilib support (patch from Fedora 9)

Created attachment 736 [details]
Akode 2.0.2: fix flac 1.1.3 support (patch from Fedora 9)

Created attachment 737 [details]
Akode 2.0.2: fix compilation with GCC 4.3 (patch from Fedora 9)

Created attachment 738 [details]
Akode 2.0.2: fix autotool >= 1.10 detection + 1 CXXFLAGS

FYI, my build sequence for Akode 2.0.2 is as follow:
(replace %{} macros with target directories path, e.g /opt/trinity/xxx)

##########

sed -i "admin/acinclude.m4.in" \
  -e "s|/usr/include/tqt|%{tde_includedir}/tqt|g" \
  -e "s|kde_htmldir='.*'|kde_htmldir='%{tde_tdedocdir}/HTML'|g"

_cp -f "/usr/share/aclocal/libtool.m4" "admin/libtool.m4.in"
_cp -f "/usr/share/libtool/config/ltmain.sh" "admin/ltmain.sh" || cp -f "/usr/share/libtool/ltmain.sh" "admin/ltmain.sh"
_make -f admin/Makefile.common cvs

./configure \
  --bindir=%{tde_bindir} \
  --libdir=%{tde_libdir} \
  --includedir=%{tde_includedir} \
  --datadir=%{tde_datadir} \
  --disable-static \
  --enable-shared \
  --disable-debug --disable-warnings --disable-dependency-tracking \
  --with-libltdl \
  --with-alsa \
  --with-oss \
  --with-flac \
  --with-jack \
  --with-libsamplerate \
  --with-pulseaudio \
  --with-speex \
  --with-vorbis \
  --without-ffmpeg \
  --without-libmad \
  --enable-closure \
  --enable-new-ldflags \
  --enable-final

make -j4 LIBTOOL=$(which libtool)

##########

Note: the last command with "LIBTOOL=$(which libtool)" is a hack indicating that there is a problem with akode-provided autotools configuration files (they are surely deprecated). But it works this way.

Created attachment 1415 [details]
Akode 2.0.2 : fix ffmpeg include (not sure about this patch ?)

Created attachment 2537 [details]
akode 14.0.0: update for build issues

Hello, the attached patch applies to Akode 14.0.0 in Trinity GIT.

1) Convert POLYP support to PulseAudio support (polyp was early version of pulseaudio)

2) Fix incorrect OGG detection in openSUSE

For your information: akode is already incorporated into the GIT tree == will be part R14.1.0 and later:

http://git.trinitydesktop.org/cgit/akode/

There was also a conversion into CMake. Please can you test building from these source code?

Hello, the latest patch applies to the Akode already imported in GIT, which does FTBFS on my computer compared to original Akode + attached patches.

The Akode GIT repository is lacking at least 2 patches that  are mandatory to have a working Akode

1) The polyp=>pulseaudio conversion
2) Missing "akode.pc" file generation (created from "akode.pc.in"), needed for tdemultimedia to detect Akode during "./configure".

Please, review the attached patches, check those that are missing, and apply them in GIT repository.

(In reply to Francois Andriot from comment #10)
> Hello, the latest patch applies to the Akode already imported in GIT, which
> does FTBFS on my computer compared to original Akode + attached patches.
> 
> The Akode GIT repository is lacking at least 2 patches that  are mandatory
> to have a working Akode
> 
> 1) The polyp=>pulseaudio conversion
> 2) Missing "akode.pc" file generation (created from "akode.pc.in"), needed
> for tdemultimedia to detect Akode during "./configure".
> 
> Please, review the attached patches, check those that are missing, and apply
> them in GIT repository.

Ad 1) yes, it is a good idea - I'm sure it will be incorporated within R14.0.2.

Ad 2) tdemultimedia uses binary 'akode-config', rather than pkg-config file. Therefore missing pkg-config file for akode for now can not cause FTBFS in tdemultimedia. However, creating a pkg-config file is definitely a good idea and I'm sure it also will be incorporated within R14.0.2.

Hello,
yes, I've seen that tdemultimedia uses "akode-config" command to detect akode, but on all distro I build on, without the "akode.pc" patch, tdemultimedia does not detect akode and akode support is not built at all ...
The original patch is called "add multilib support", which in Fedora world means "add support for separated /usr/lib64 and /usr/lib directories". I bet the problem was related to having a "/usr/lib64" directory. Maybe you don't have this scenario.

Comment on attachment 736 [details]
Akode 2.0.2: fix flac 1.1.3 support (patch from Fedora 9)

Already included in GIT hash 583884cc.

Comment on attachment 737 [details]
Akode 2.0.2: fix compilation with GCC 4.3 (patch from Fedora 9)

Already included in GIT hash 48eea5b2 and 4ef4f179.

Comment on attachment 738 [details]
Akode 2.0.2: fix autotool >= 1.10 detection + 1 CXXFLAGS

Admin folder was replaced by common admin submodule.

Comment on attachment 734 [details]
Akode 2.0.2: adds pulseaudio support (patch from Fedora 9)

After merging with parts from attachment 2537 [details] pushed to GIT in hash cf18d66a.

Comment on attachment 735 [details]
Akode 2.0.2: adds multilib support (patch from Fedora 9)

Added the necessary code for CMake build and pushed to GIT in hash d67c4c24.

Comment on attachment 2537 [details]
akode 14.0.0: update for build issues

The rest of the patch pushed to GIT in hash 386d5647.

From my previous testing showed that ffmpeg decoder is now broken and would require further work. Therefore I propose for now to close this bug report, because the subject of this bug report was fulfilled.

François, thank you for your good work on this!

>Therefore I propose for now to close this bug report, because the subject of >this bug report was fulfilled.
Sounds good to me.