| Summary: | Build issue: tdeaddons: unknown icon type | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Darrell <darrella> |
| Component: | tdeaddons | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | bugwatch, darrella, michele.calgaro |
| Priority: | P5 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | Other | ||
| OS: | Other | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | tdeaddons | |
| Attachments: | Patch to fix "Unknown icon type" message | ||
|
Description
Darrell
2012-01-20 22:02:41 CST
Created attachment 1686 [details]
Patch to fix "Unknown icon type" message
According to the LICENSE document in the same directory, livemark-item.png is retained for license tracking purposes. The file is not compiled.
I am attaching a patch I believe is correct and works for me. I no longer see the message and cr16-app-konqsidebar_news.png is correctly compiled to /opt/trinity/share/icons/crystalsvg/16x16/apps/konqsidebar_news.png.
Hi Darrell, even without your patch I don't see the 'unknown icon type livemark' warning message when I compile tdeaddons. Could you double check on your system as well? Are you compiling with cmake or autotools? The messages appear only with autotools. Other than tdelibs and tdebase I've never seen any formal declaration that any of the cmake migrations are complete and fully tested or audited. >Are you compiling with cmake or autotools? The messages appear only with >autotools. I am using CMake. > Other than tdelibs and tdebase I've never seen any formal declaration that any > of the cmake migrations are complete and fully tested or audited. Not sure as well, but according to the log in the tdeaddons GIT module, it looks like the CMake conversion was all done 2013-11-03 Remaining parts of cmake conversion Slávek Banko 2013-10-15 Initial cmake conversion Alexander Golubev So I think this bug doesn't need a patch after all :) Okay, so there is an informal declaration of a completed conversion. No flight plan is filed anywhere. :-) Push the patch anyway? No harm --- no foul? > Push the patch anyway? No harm --- no foul?
If it helps, yes!
I am not sure what difference it makes though, perhaps you can explain so I learn something more :)
> I am not sure what difference it makes though, perhaps you can explain so I >learn something more Only explanation is I put forth a lot of work into resolving all of these "unknown icon" paper cut bugs. The patch in attachment 1686 [details] was pushed to git in commit 3c6bdf4b. |