| Summary: | TDE temporary directory names conflict with KDE4 names | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Darrell <darrella> |
| Component: | other (any) | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | blocker | CC: | bugwatch, darrella |
| Priority: | P1 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | Other | ||
| OS: | Other | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Attachments: |
Patch to fix TDE temporary directory names
Patch to modify KDETMP and KDEVARTMP environment variables Updated patch to fix more instances. Updated patch Updated patch Updated patch Fix possible temp dir locations Fix names of temporary directories |
||
Created attachment 290 [details]
Patch to modify KDETMP and KDEVARTMP environment variables
I am adding a second patch to modify the environment variables KDETMP and KDEVARTMP, changing them both to TDETMP and TDEVARTMP throughout the entire source tree. Apply this second patch after applying the previous patch addressing this specific bug report.
Created attachment 291 [details]
Updated patch to fix more instances.
I missed some instances. :)
This is a single patch to update both the environment variable references and temporary directory names, and replaces the two previous separate patches.
I am noticing a lot of changes from ksocket to tdesocket. This would need to be applied globally across the entire TDE source tree, as a lot of applications use the ksocket directory for files. Can you post a patch that only includes changes to the user visible strings (e.g. help strings) and also post a list of internal strings (such as ksocket) that you want renamed? Thanks! I'm not following. :) My patch already applies to the entire GIT tree. Therefore all ksocket -> tdesocket changes are global and not to only a few packages. If we don't rename ksocket then we'll have conflicts with KDE4, which uses the same name. If I had a test plan I could apply the patch, rebuild Trinity, test expectations, and report the results. I am remaining at GIT short version 2838 for now until GIT merges settle for a while. I can build all of the core and main packages right now except tdebindings. Therefore any test plan should prove successful. I renamed ksocket and kcache to tdesocket and tdecache recently in GIT. What else needs to be done to close this report? Woof woof! I did not know you did that! If you globally updated tdesocket and tdecache, then looking at my original patch, probably only a few things: * tmp-$HOSTNAME -> /tmp/tde-$USER * Environment variables KDETMP -> TDETMP KDEVARTMP -> TDEVARTMP I'm attaching three updated patches. I haven't updated GIT for several days, so let me know if the new patches fail. Created attachment 305 [details]
Updated patch
Created attachment 306 [details]
Updated patch
Created attachment 307 [details]
Updated patch
Created attachment 410 [details]
Fix possible temp dir locations
This last patch amends tdelibs/kinit/lnusertemp.c to look for all three environment variables rather than only TMPDIR. Several months ago in an unrelated project I got burned by sources that limited the environment variable search to only TMPDIR. Checking all three variables is more robust.
Looks like all of the tde-i18n docbook files were updated from KDETMP to TDETMP. I will be pushing other handbook related patches. If we merge this last small patch we can close this bug report as resolved. :)
I have been using this patch in my daily builds. No noticeable problems. Should I push this patch? Last patch merged in GIT hash db9522797ab0139b316bb74bbbc79341a4eacfbf. This resolves the bug report. Created attachment 484 [details]
Fix names of temporary directories
Looks like we forgot to rename two of the temporary directories. Patch attached.
Patch to fix tde-i18n merged in GIT hash 50c3f68ada12dde4457d2005fb23450fe1998989. Patch to fix tdelibs merged in GIT hash 628ce684b973d8f8ed6ce04049bae393d2ac71a7. Patch to fix tdebase merged in GIT hash 51e4bce4621e8b5b56ceae4fc54ee3a618c7fced. Patch to fix koffice merged in GIT hash f50344ebcc6fde98e251750860d30ff73c2ce453. Patch to fix kbfx merged in GIT hash 87afb3232383d13dab0666fbdeae37a6f0b23958. Patch to fix adept merged in GIT hash 77811b8ba122ab8cb44e0dc0b4f3bd49a16f7341. Patch to fix kmymoney merged in GIT hash 5805f2c193cb4c04c4df065eb2fab7844b625601. Patch to fix k9copy merged in GIT hash a9898601d8a1851a969303523c66e5adaa6f0a82. This resolves the bug report. |
Created attachment 289 [details] Patch to fix TDE temporary directory names In both Trinity and KDE4, special directories are used to store temporary information. Persistent temporary information is stored in $TDEHOME/cache-$HOSTNAME, while non persistent temporary information is stored in $TDEHOME/socket-$HOSTNAME and $TDEHOME/tmp-$HOSTNAME. The directories in both $TDEHOME and $KDEHOME are sym links. The names used for the sym links cause no conflict by themselves because they reside in different profile directories, but the actual directory names pointed to by the sym links are the same for both desktops and will cause conflicts. KDE4 AS IS: cache-$HOSTNAME -> /var/tmp/kdecache-$USER socket-$HOSTNAME -> /tmp/ksocket-$USER tmp-$HOSTNAME -> /tmp/kde-$USER TDE AS IS: cache-$HOSTNAME -> /var/tmp/kdecache-$USER socket-$HOSTNAME -> /tmp/ksocket-$USER tmp-$HOSTNAME -> /tmp/kde-$USER Recommendation: Change the actual directory names. TDE PROPOSED: cache-$HOSTNAME -> /var/tmp/tdecache-$USER socket-$HOSTNAME -> /tmp/tdesocket-$USER tmp-$HOSTNAME -> /tmp/tde-$USER A patch is attached to address this specific bug report.