By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 818

Summary:	Build issue: Amarok: Several build options missing with the cmake conversion
Product:	TDE	Reporter:	Darrell <darrella>
Component:	non-core programs	Assignee:	Timothy Pearson <kb9vqf>
Status:	RESOLVED FIXED
Severity:	major	CC:	bugwatch, darrella, fatzer2, michele.calgaro, mike, slavek.banko
Priority:	P1
Version:	R14.0.x [Trinity]
Hardware:	Other
OS:	Other
See Also:	http://bugs.pearsoncomputing.net/show_bug.cgi?id=1300
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Bug Depends on:
Bug Blocks:	1300, 3060
Attachments:	Adds PostgreSQL support

Description Darrell 2012-01-26 15:15:22 CST

Several build options are missing for Amarok. From the Amarok 1.4.10 configure help options:

  --enable-mysql              build Amarok with MySQL support
  --enable-postgresql         build Amarok with PostgreSQL support
  --disable-amazon            disable Amazon cover download support default=enable
  --without-arts              build without aRts default=no
  --with-nmm                  build Amarok with NMM-engine
  --with-helix                build Amarok with Helix-engine
  --without-opengl            build Amarok without OpenGL support
  --without-included-sqlite   build Amarok using system sqlite library
  --without-musicbrainz       build Amarok without MusicBrainz support

These options do not seem to be supported.

Second, there seems to be no way in Amarok not to build last.fm support. Although disabled by default in the user configuration settings, there should be an option not to build the support at all. Many people just want a music player, not a social networking tool. :)

Comment 1 Darrell 2012-02-16 13:45:49 CST

This is a build issue and the bug report should be bumped to Blocker.

Comment 2 Mike 2012-09-07 13:28:09 CDT

Created attachment 810 [details]
Adds PostgreSQL support

Comment 3 Mike 2012-09-07 13:32:32 CDT

I specifically need postgres support so I have added an 'ENABLE_POSTGRESQL' option to the cmake build system. It effective gives the equivalent of '--enable-postgresql' that is available when using autotools.

I'm not a developer so it may well not fit with the TDE style guide but it does the job.

Comment 4 Darrell 2012-10-14 20:35:57 CDT

Also missing are CMakeLists.txt files for amarok/amarok/src/metadata/mp4, speex, trueaudio, wavpack.

Comment 5 Darrell 2012-10-29 13:14:35 CDT

Looks like Mike's patch could be used as a template to port the --enable-mysql option.

I always use the built-in sqlite database. Is there an amarok conversion tool to convert from the built-in sqlite database to the external sqlite, mysql, or postgresql databases? If there is a way to convert the built-in database then I could help with testing.

Comment 6 Alexander Golubev (Fat-Zer) 2014-07-19 12:12:58 CDT

(In reply to Darrell from comment #5)
> Looks like Mike's patch could be used as a template to port the
> --enable-mysql option.

The MySQL option will be more complicated because cmake doesn't provide appropriate module for mysql nor the mysql package doesn't provide the pkg-config file...
There is a third-party implementation: http://www.cmake.org/Wiki/CMakeUserFindMySQL
But IMO it's quite crappy...

The patch looks good except two points: 
1. The option supposed to be called WITH_* rather than ENABLE_* acording to common notation
2. There is no need in db_{libs,dirs,incs} variables: feel free to use their PostgreSQL_* variants directly. If the project is configured to build without postgres they just will be evaluated into null strings.

Comment 7 Michele Calgaro 2018-07-29 08:21:46 CDT

When resolving this bug, bug 1300 should be closed as well if its status hasn't changed.

Comment 8 Slávek Banko 2020-03-05 11:47:49 CST

CMake conversion has now been completed thanks to Greg's excellent work. See http://mirror.git.trinitydesktop.org/cgit/amarok/commit/?id=16ec57d25f