By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 840

Summary:	OnlyShowIn=KDE
Product:	TDE	Reporter:	Darrell <darrella>
Component:	other (any)	Assignee:	Timothy Pearson <kb9vqf>
Status:	RESOLVED FIXED
Severity:	blocker	CC:	bugwatch, darrella
Priority:	P1
Version:	R14.0.0 [Trinity]
Hardware:	Other
OS:	Other
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Attachments:	adept: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE desktop-effects-tde: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE gtk-qt-engine: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE knutclient: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE krusader: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE tde-guidance: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE tdebase: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE tdelibs: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE tdemultimedia: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE tdenetwork: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE tdepim: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE tdeutils: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE

Description Darrell 2012-02-01 19:36:39 CST

When used in *.desktop files, the OnlyShowIn parameter is set to KDE. This will conflict with KDE4 and is technically incorrect. The OnlyShowIn parameter should be set to TDE.

Here is a list of the files in the GIT tree that have that parameter set to KDE:

applications/krusader/krusader/krusader_root-mode.desktop
applications/adept/adept/notifier/adept_notifier_auto.desktop
applications/knutclient/src/knutclient.desktop
applications/desktop-effects-tde/desktop-effects-tde.desktop
applications/gtk-qt-engine/kcm_gtk/kcmgtk.desktop
applications/tde-guidance/powermanager/guidance-power-manager.desktop
tdepim/kabc/kabcdistlistupdater/kabcdistlistupdater.desktop
tdepim/korganizer/korgac/korgac.desktop
tdepim/kalarm/kalarm.desktop
tdelibs/kabc/kab2kabc.desktop
tdelibs/kresources/kresources.desktop
tdebase/konqueror/preloader/konqy_preload.desktop
tdebase/konqueror/Home.desktop
tdebase/kappfinder/kappfinder.desktop
tdebase/ktip/ktip.desktop
tdebase/kfind/Kfind.desktop
tdebase/klipper/klipper.desktop
tdebase/kicker/kicker/panel.desktop
tdebase/kicker/kicker/kcmkicker.desktop
tdebase/kdesktop/kdesktop.desktop
tdebase/kdesktop/init/Home.desktop
tdebase/kdesktop/init/My_Computer
tdebase/kdesktop/init/Printers
tdebase/kdesktop/init/System.desktop
tdebase/kdesktop/init/My_Network_Places
tdebase/kpersonalizer/kpersonalizer.desktop
tdebase/kscreensaver/KBlankscreen.desktop
tdebase/kscreensaver/KRandom.desktop
tdebase/kcontrol/randr/krandrtray.desktop
tdebase/kcontrol/kcontrol/kinfocenter.desktop
tdebase/kcontrol/kcontrol/kinfocenter.desktop
tdebase/kcontrol/kcontrol/KControl.desktop
tdebase/khelpcenter/Help.desktop
tdebase/kmenuedit/kmenuedit.desktop
tdeutils/kdf/kwikdisk.desktop
tdeutils/superkaramba/src/superkaramba.desktop
tdemultimedia/arts/builder/x-artsbuilder.desktop
tdemultimedia/arts/builder/artsbuilder.desktop
tdemultimedia/arts/tools/artscontrol.desktop
tdemultimedia/arts/tools/artscontrolapplet.desktop
tdemultimedia/kmix/kmix.desktop
tdemultimedia/kmix/restore_kmix_volumes.desktop
tdenetwork/filesharing/advanced/kcm_sambaconf/kcmsambaconf.desktop

Comment 1 Darrell 2012-02-28 23:04:17 CST

Created attachment 433 [details]
adept: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE

Comment 2 Darrell 2012-02-28 23:05:27 CST

Created attachment 434 [details]
desktop-effects-tde: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE

Comment 3 Darrell 2012-02-28 23:05:52 CST

Created attachment 435 [details]
gtk-qt-engine: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE

Comment 4 Darrell 2012-02-28 23:06:17 CST

Created attachment 436 [details]
knutclient: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE

Comment 5 Darrell 2012-02-28 23:06:47 CST

Created attachment 437 [details]
krusader: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE

Comment 6 Darrell 2012-02-28 23:07:13 CST

Created attachment 438 [details]
tde-guidance: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE

Comment 7 Darrell 2012-02-28 23:07:36 CST

Created attachment 439 [details]
tdebase: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE

Comment 8 Darrell 2012-02-28 23:08:03 CST

Created attachment 440 [details]
tdelibs: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE

Comment 9 Darrell 2012-02-28 23:08:29 CST

Created attachment 441 [details]
tdemultimedia: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE

Comment 10 Darrell 2012-02-28 23:08:53 CST

Created attachment 442 [details]
tdenetwork: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE

Comment 11 Darrell 2012-02-28 23:09:16 CST

Created attachment 443 [details]
tdepim: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE

Comment 12 Darrell 2012-02-28 23:09:44 CST

Created attachment 444 [details]
tdeutils: Change ShowOnlyIn=KDE -> ShowOnlyIn=TDE

Comment 13 Darrell 2012-02-28 23:10:27 CST

I notice in the following:

tdelibs/kinit/autostart.cpp
tdelibs/kio/kio/kservice.cpp
tdelibs/kio/kio/kservicegroup.cpp

that support for OnlyShowIn=TDE does exist. I attached patches for the aforementioned files.

The patches are straightforward, but I won't push the patches until somebody provides a peer check that patching is conceptually sound and won't break something else in tdelibs.

Comment 14 Timothy Pearson 2012-02-28 23:28:34 CST

All patches that set OnlyShowIn=TDE should be pushed across all modules.  If something breaks it should be fixed in the desktop file handlers in tdelibs.

Comment 15 Darrell 2012-02-28 23:44:01 CST

The patches I attached are for the only modules I found using ShowOnlyIn=KDE. Unless I missed something in my grepping, the patches attached is the complete set.

None of the attached patches touch any handler code.

If I understand your post correctly, push the patches?

Comment 16 Timothy Pearson 2012-02-28 23:50:00 CST

Sorry, I guess I wasn't clear. :-)

My point was that these patches are 100% correct and should be pushed ASAP, and that if anything breaks, the handler code, not the .desktop files, should be fixed.

Thanks!

Comment 17 Darrell 2012-03-05 19:24:35 CST

tdeutils patch merged in GIT hash 660480128fbed70e6898eb6cab4a40e85fd98873.
tdepim patch merged in GIT hash bf7afe36b8129991c538dfc234bd3d4c8a43d71d.
tdenetwork patch merged in GIT hash f067fe42a29900977ff95e56d48b434f1813e7f9.
tdemultimedia patch merged in GIT hash dbd80a86756711f3aeb99264b5017c5fa785e372.
tdelibs patch merged in GIT hash 000bad21ebdda62f24f96a22fee60ca7a6dc0c9e.
tdebase patch merged in GIT hash 5515785d64e04f6290b32cb3b859a06957b2d1a6.
tde-guidance patch merged in GIT hash ebb7677ce08db1f0ce23c48e2b935d0ae16a7d7a.
krusader patch merged in GIT hash ed84072a8ddc3f9d38e8e80588360e4011f9f4bd.
knutclient patch merged in GIT hash 6c17ad02f79ee5bf6b256d1d75ec429dfa88ddff.
gtk-qt-engine patch merged in GIT hash 094e695efe4ef3653f84ec03ee756568e647ef97.
desktop-effects-tde patch merged in GIT hash 1e04dc17704cdaf0000d783e2752a549cd90b115.
adept patch merged in GIT hash fec2a52f5815777b42a2a95378d8a0ff520cb5ca.

This resolves the bug report.