By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 869

Summary:	kwin: Implement Mac like window switching
Product:	TDE	Reporter:	Calvin Morrison <mutantturkey>
Component:	tdebase	Assignee:	Calvin Morrison <mutantturkey>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	bugwatch, darrella, kb9vqf
Priority:	P5
Version:	R14.0.0 [Trinity]
Hardware:	Other
OS:	All
Compiler Version:		TDE Version String:
Application Version:		Application Name:	twin
Attachments:	for tdebase adds a bit to tdecore this is the final (hopeful) patch err final patch Final patch updated for GIT err ok!

Description Calvin Morrison 2012-02-21 09:01:15 CST

In Mac OS, you can switch not only between all windows, but between just 
windows that are in the same application. e.g you want to switch to the 
Download window of Firefox, just ALT+~ and you'll switch to the next firefox 
window if you are currently on a firefox window.

This is a really good feature ( probably the only one I actuall miss ) from 
Mac's desktop.

window maker recently introduced this feature, and there is a link to the 
commit:

http://repo.or.cz/w/wmaker-crm.git/commit/18408fff93468c533bf4aef3ce6c9808b415adde

we can their commit to figure out how to do it. I am assuming it is done via a 
X atom property. 

Calvin.

Comment 1 Calvin Morrison 2012-04-16 14:51:48 CDT

Created attachment 539 [details]
for tdebase

Comment 2 Calvin Morrison 2012-04-16 14:52:12 CDT

Created attachment 540 [details]
adds a bit to tdecore

Comment 3 Calvin Morrison 2012-04-16 14:52:34 CDT

Patches available :-)

Comment 4 Darrell 2012-04-17 12:49:33 CDT

My initial test with modified GIT patches is promising.

Make the cycling of the shortcut the same as Alt-Tab and we have a great addition.

Comment 5 Calvin Morrison 2012-04-23 21:53:58 CDT

Created attachment 555 [details]
this is the final (hopeful) patch

Comment 6 Calvin Morrison 2012-04-24 09:22:25 CDT

Created attachment 556 [details]
err final patch

done. all working

Comment 7 Darrell 2012-04-24 11:26:38 CDT

Using the latest patch. Reverse scroll does not work?

Comment 8 Calvin Morrison 2012-04-24 14:06:34 CDT

Are you doing a full rebuild of tdebase? You'll need to recompile kcontrol as well as kwin to get the updated kwinbindings.cpp to apply.

Comment 9 Darrell 2012-04-24 14:30:56 CDT

Full rebuild of tdebase, and I rebuilt tdelibs as well without the previous tdecore patch.

Are you saying reverse cycling works for you?

Comment 10 Calvin Morrison 2012-04-24 14:32:17 CDT

Cycling forward and backwards using the Alt + ` and Alt + ~ (which is actually Alt + Shift + `) works for me.

Calvin

Comment 11 Darrell 2012-04-24 14:59:01 CDT

Perhaps I misunderstood your mail list post. Is the tdecore patch still needed or no longer needed?

Comment 12 Darrell 2012-04-24 16:04:56 CDT

I did not include the original tdecore patch in my latest tdelibs rebuild. I tried a clean profile and the reverse cycling works. That observation led me to look at my profile kdeglobals, where I found a stale shortcut from the previous patches. Interesting that kdeglobals did not self-update. Fixed. Now reverse cycling works.

Feel better, huh? :-)

Good job!

Unless the project BMOC objects, I can push my version of the patch, which is already adapted to GIT.

Comment 13 Calvin Morrison 2012-04-24 16:09:55 CDT

Can you wait for a few days before you submit it? I want to make sure the quality is top notch. thanks!

Comment 14 Darrell 2012-04-24 16:28:25 CDT

You make the call. Post something here or in the mail list when you want to cah like a crow. :)

Comment 15 Darrell 2012-04-25 18:12:28 CDT

Created attachment 560 [details]
Final patch updated for GIT

Comment 16 Darrell 2012-05-08 17:01:57 CDT

Calvin, do you want this patch pushed to GIT?

Comment 17 Calvin Morrison 2012-05-11 13:41:29 CDT

Ok,

darrell I think it's good 2 go. Can you test and push?

thanks!

Comment 18 Calvin Morrison 2012-05-11 13:41:33 CDT

Created attachment 618 [details]
err ok!

Comment 19 Darrell 2012-05-11 17:04:05 CDT

Latest "err ok!" patch tested in GIT. Keyboard shortcut cycles in both directions. Seems fine to me. Push?

Comment 20 Timothy Pearson 2012-06-09 21:37:57 CDT

(In reply to comment #19)
> Latest "err ok!" patch tested in GIT. Keyboard shortcut cycles in both
> directions. Seems fine to me. Push?

Go ahead!

Comment 21 Darrell 2012-06-09 21:44:24 CDT

Pushed in GIT hash 1e959a2a.

Thanks Calvin!