By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 875

Summary: rpmlint raises errors on tdelibs code
Product: TDE Reporter: Robert Xu <robxu9>
Component: tdelibsAssignee: Timothy Pearson <kb9vqf>
Status: RESOLVED FIXED    
Severity: blocker CC: bugwatch, darrella
Priority: P5    
Version: R14.0.0 [Trinity]   
Hardware: All   
OS: Other   
Compiler Version: TDE Version String:
Application Version: Application Name:

Description Robert Xu 2012-02-26 13:42:07 CST
The following need to be fixed before tdelibs can be successfully built on my side:


I: A function overflows or underflows an array access. This could be a
real error,
  but occasionaly this condition is also misdetected due to loop
unrolling or strange pointer
  handling. So this is warning only, please review.
W: tdelibs arraysubscript
/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/libkmid/track.cc:337

I: Program is likely to break with new gcc. Try -fno-strict-aliasing.
W: tdelibs strict-aliasing-punning
/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/kimgio/dds.cpp:493, 503
W: tdelibs strict-aliasing-punning
/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/kioslave/iso/kiso.cpp:252,
307, 308, 314
W: tdelibs strict-aliasing-punning
/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/libkmid/deviceman.cc:547,
560, 579, 601, 622
W: tdelibs strict-aliasing-punning
/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/libkmid/fmout.cc:121, 235,
237, 238, 243, 280, 290, 302, 316
W: tdelibs strict-aliasing-punning
/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/libkmid/gusout.cc:200, 234,
236, 237, 241, 276, 298, 312, 407
W: tdelibs strict-aliasing-punning
/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/libkmid/midiout.cc:81
W: tdelibs strict-aliasing-punning
/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/libkmid/synthout.cc:167,
173, 180, 191
W: tdelibs strict-aliasing-punning
/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/tdecore/kcrash.cpp:304

I: Program returns random data in a function
E: tdelibs no-return-in-nonvoid-function
/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/krsync/rsyncconfigdialog.cpp:180
E: tdelibs no-return-in-nonvoid-function
/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/tdecore/kapplication.cpp:198
Comment 1 Timothy Pearson 2012-02-26 21:07:53 CST
The libkmid errors are due to a problem in the way _TIMER_EVENT is defined in the system's (non-TDE) linux/soundcard.h include file.  You will need to find a way to override/ignore those particular warnings, as they are not caused by TDE code.

I am working on the other warnings and will push a patch shortly.
Comment 2 Robert Xu 2012-02-26 21:09:14 CST
(In reply to comment #1)
> The libkmid errors are due to a problem in the way _TIMER_EVENT is defined in
> the system's (non-TDE) linux/soundcard.h include file.  You will need to find a
> way to override/ignore those particular warnings, as they are not caused by TDE
> code.
> 
> I am working on the other warnings and will push a patch shortly.

Those warnings can be ignored. It's the error at the bottom that's stopping the whole process.
Comment 3 Timothy Pearson 2012-02-26 21:15:11 CST
(In reply to comment #2)
> (In reply to comment #1)
> > The libkmid errors are due to a problem in the way _TIMER_EVENT is defined in
> > the system's (non-TDE) linux/soundcard.h include file.  You will need to find a
> > way to override/ignore those particular warnings, as they are not caused by TDE
> > code.
> > 
> > I am working on the other warnings and will push a patch shortly.
> 
> Those warnings can be ignored. It's the error at the bottom that's stopping the
> whole process.

Odd; that was the one warning that should have been fixed a while back.  Are you getting that warning from the latest GIT HEAD?
Comment 4 Robert Xu 2012-02-26 21:16:24 CST
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > The libkmid errors are due to a problem in the way _TIMER_EVENT is defined in
> > > the system's (non-TDE) linux/soundcard.h include file.  You will need to find a
> > > way to override/ignore those particular warnings, as they are not caused by TDE
> > > code.
> > > 
> > > I am working on the other warnings and will push a patch shortly.
> > 
> > Those warnings can be ignored. It's the error at the bottom that's stopping the
> > whole process.
> 
> Odd; that was the one warning that should have been fixed a while back.  Are
> you getting that warning from the latest GIT HEAD?

Very latest :| I'll trigger another pull and rebuild. The tarball I used is no greater than 1-2 weeks old. :|
Comment 5 Timothy Pearson 2012-02-26 21:19:48 CST
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (In reply to comment #1)
> > > > The libkmid errors are due to a problem in the way _TIMER_EVENT is defined in
> > > > the system's (non-TDE) linux/soundcard.h include file.  You will need to find a
> > > > way to override/ignore those particular warnings, as they are not caused by TDE
> > > > code.
> > > > 
> > > > I am working on the other warnings and will push a patch shortly.
> > > 
> > > Those warnings can be ignored. It's the error at the bottom that's stopping the
> > > whole process.
> > 
> > Odd; that was the one warning that should have been fixed a while back.  Are
> > you getting that warning from the latest GIT HEAD?
> 
> Very latest :| I'll trigger another pull and rebuild. The tarball I used is no
> greater than 1-2 weeks old. :|

That could have been fixed in less than 2 weeks ago.  I'd hold off on a rebuild until I commit a fix for the second error though. ;-)
Comment 6 Robert Xu 2012-02-26 21:21:10 CST
(In reply to comment #5)
> 
> That could have been fixed in less than 2 weeks ago.  I'd hold off on a rebuild
> until I commit a fix for the second error though. ;-)

sneaky ;P ok, I'll wait for an update on this bug.
Comment 7 Timothy Pearson 2012-02-26 21:29:06 CST
I don't like type punning in a crash handler (it's asking for trouble on top of trouble) so I rewrote the section relying on type punning in kcrash.  This, and most of the other warnings are fixed in GIT hash 77f4891.

Let me know if you run into any more problems.
Comment 8 Robert Xu 2012-02-26 22:15:06 CST
Now fails early on:

[  6%] Building CXX object tdecore/CMakeFiles/tdecore-shared.dir/kprocess.cpp.o
cd /home/abuild/rpmbuild/BUILD/tdelibs-R13.99/build/tdecore && /usr/bin/c++   -Dtdecore_shared_EXPORTS -DHAVE_CONFIG_H -fomit-frame-pointer -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g   -DQT_NO_ASCII_CAST -DQT_CLEAN_NAMESPACE -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -DQT_THREAD_SUPPORT -D_REENTRANT -include tqt.h -O3 -DNDEBUG -fPIC -I/usr/lib/qt3/include -I/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/build/tdecore -I/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/build -I/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/tdecore -I/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/tdecore/network -I/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/dcop -I/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/libltdl -I/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/tdefx -I/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/tdeui -I/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/kio/kio    -o CMakeFiles/tdecore-shared.dir/kprocess.cpp.o -c /home/abuild/rpmbuild/BUILD/tdelibs-R13.99/tdecore/kprocess.cpp
/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/tdecore/kprocess.cpp: In member function 'virtual int KProcess::commSetupDoneP()':
/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/tdecore/kprocess.cpp:960:23: error: 'TQ_CHECK_PTR' was not declared in this scope
/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/tdecore/kprocess.cpp:968:24: error: 'TQ_CHECK_PTR' was not declared in this scope
/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/tdecore/kprocess.cpp:977:24: error: 'TQ_CHECK_PTR' was not declared in this scope
In file included from /home/abuild/rpmbuild/BUILD/tdelibs-R13.99/tdecore/kprocess.cpp:1137:0:
/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/tdecore/kprocess.cpp: In member function 'virtual bool KProcess::start(KProcess::RunMode, KProcess::Communication)':
/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/tdecore/kprocess.cpp:407:37: warning: ignoring return value of 'ssize_t write(int, const void*, size_t)', declared with attribute warn_unused_result [-Wunused-result]
/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/tdecore/kprocess.cpp: In member function 'void KProcess::setupEnvironment()':
/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/tdecore/kprocess.cpp:193:46: warning: ignoring return value of 'int chdir(const char*)', declared with attribute warn_unused_result [-Wunused-result]
make[2]: *** [tdecore/CMakeFiles/tdecore-shared.dir/kprocess.cpp.o] Error 1
make[2]: Leaving directory `/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/build'
make[1]: *** [tdecore/CMakeFiles/tdecore-shared.dir/all] Error 2
make[1]: Leaving directory `/home/abuild/rpmbuild/BUILD/tdelibs-R13.99/build'
make: *** [all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.mHxdSb (%build)

(I think I may have to rebuild tqtinterface now...)
Comment 9 Timothy Pearson 2012-02-26 22:18:45 CST
That is a tqtinterface problem.

If you update to the very latst GIT, it would be wise to rebuild qt3/tqt3, tqtinterface, and arts before rebuilding tdelibs.
Comment 10 Timothy Pearson 2012-02-26 22:19:21 CST
Rather, I should say that this is a tqtinterface ***outdated build*** problem, not a problem with the tqtinterface sources in GIT. ;-)
Comment 11 Robert Xu 2012-04-01 11:27:45 CDT
This has been solved as far as I know. (Latest commit to GIT should have no problems)