| Summary: | kate-sort plugin should be added tdeaddons and be ported to katepart | ||
|---|---|---|---|
| Product: | TDE | Reporter: | David C. Rankin <trin> |
| Component: | tdeaddons | Assignee: | David C. Rankin <trin> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | bugwatch, darrella, kb9vqf, michele.calgaro, mutantturkey, slavek.banko, trin |
| Priority: | P5 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Bug Depends on: | |||
| Bug Blocks: | 1969, 2014 | ||
| Attachments: |
Kate 'Tools' menu showing 'Sort' plugin
Kate 'plugins' included in std opensuse kde3 kate TDE14 source code for katesort-plugin (attachment corrupted) Patch to add katesort plugin to tdeaddons (attachment corrupted) katesort sources pruned of cruft (attachment corrupted) katesort plugin source code - before qt-tqt and kde-tde convert (attachment corrupted) Patch to add katesort plugin to tdeaddons katesort sources pruned of cruft |
||
|
Description
David C. Rankin
2012-02-29 11:48:59 CST
Created attachment 446 [details]
Kate 'plugins' included in std opensuse kde3 kate
Attached is the completed conversion for the TDE14 katesort-plugin. It builds fine on arch with the standard autotools build. After building, simply install, then launch kate and go to Settings -> Configure Kate -> Plugins (first) and then just check the box next to Sort. Created attachment 1956 [details]
TDE14 source code for katesort-plugin (attachment corrupted)
This source needs to be tested (works perfect on Arch), then pushed to the TDE git tree under applications.
Created attachment 1960 [details]
Patch to add katesort plugin to tdeaddons (attachment corrupted)
This patch adds the katesort plugin to tdeaddons as originally requested in the bug report summary. The short katesort help handbook is merged into the tdeaddons kate plugins handbook. The patch has been tested on Slackware 14.0 32-bit.
Created attachment 1961 [details]
katesort sources pruned of cruft (attachment corrupted)
This tar.xz file is derived from the original sources but pruned of all unnecessary cruft. These sources are used with a 'katesort' build script as though the sources would be installed to the application branch. The help handbook was updated with a separate *.desktop file in order to properly populate the help handbook table of contents.
These pruned sources were tested on slackware 14.0 32-bit.
I prefer the patch that merges kate sort into tdeaddons. No additional *.desktop files are needed with the tdeaddons version because the short handbook was merged directly into the tdeaddons kate-plugins handbook. The original sources were about 750 KB, the pruned sourced about 350 KB, and the merged tdeaddon sources only about 75 KB.
That's smart. For testing do we just add the katesort directory below tdeaddons and let the existing tdeaddons autotools setup configure katesort to build (I guess via it's subdirs or directories call?) Created attachment 1965 [details]
katesort plugin source code - before qt-tqt and kde-tde convert (attachment corrupted)
Slavek, as you requested here is the original source before qt-tqt or kde-tde conversion. Darrell, this has all the cruft cleaned and is named 'katesort' as you named it to become a subdirectory to the tdeaddons code. It already has had the 'admin' directory deleted/replaced with the tde admin. The only things that will need to be done after you push this to the git tree is:
(1) convert_existing_qt3_app_to_tqt3
(2) convert_existing_kde3_app_to_tde
(3) copy Darrell's docbook fix/merge to doc dir
I have already tested the above conversion process (minus the docbook merge) and it works fine. So let's get this pushed. The resulting file list is:
/opt/trinity/lib/trinity/libsortplugin.la
/opt/trinity/lib/trinity/libsortplugin.so
/opt/trinity/share/apps/kate/plugins/sort/plugin_sort.rc
/opt/trinity/share/doc/tde/HTML/cs/katesort/common
/opt/trinity/share/doc/tde/HTML/cs/katesort/index.cache.bz2
/opt/trinity/share/doc/tde/HTML/cs/katesort/index.docbook
/opt/trinity/share/doc/tde/HTML/cs/katesort/sort_plugin_cs.png
/opt/trinity/share/doc/tde/HTML/en/katesort/common
/opt/trinity/share/doc/tde/HTML/en/katesort/index.cache.bz2
/opt/trinity/share/doc/tde/HTML/en/katesort/index.docbook
/opt/trinity/share/doc/tde/HTML/en/katesort/sort_plugin_en.png
/opt/trinity/share/icons/hicolor/16x16/actions/katesort.png
/opt/trinity/share/icons/hicolor/32x32/actions/katesort.png
/opt/trinity/share/services/katesort.desktop
Comment on attachment 1956 [details]
TDE14 source code for katesort-plugin (attachment corrupted)
Can you please resubmit this attachment? It was corrupted in the Bugzilla upgrade.
Thanks!
Comment on attachment 1960 [details]
Patch to add katesort plugin to tdeaddons (attachment corrupted)
Can you please resubmit this attachment? It was corrupted in the Bugzilla upgrade.
Thanks!
Comment on attachment 1961 [details]
katesort sources pruned of cruft (attachment corrupted)
Can you please resubmit this attachment? It was corrupted in the Bugzilla upgrade.
Thanks!
Comment on attachment 1965 [details]
katesort plugin source code - before qt-tqt and kde-tde convert (attachment corrupted)
Can you please resubmit this attachment? It was corrupted in the Bugzilla upgrade.
Thanks!
Created attachment 1967 [details] Patch to add katesort plugin to tdeaddons Updated patch to replace corrupted version of the same in attachment 1960 [details]. Created attachment 1968 [details] katesort sources pruned of cruft Updated tar.xz to replace corrupted attachment 1961 [details]. Pushed to GIT in hashes ba41b408, d7401b1d, 462324fb and final 3e682801. Thank you all for prepare and testing. This bug report can be closed? Kate sort works great! Well done. IMO we could close. I am closing the bug. David, if you really need the sort plugin to be converted to a "katepart' plugin so that if can be used in KWrite as well, please open a separate wishlist bug report, since that will definitely go after v14.0.0 release |