By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 895

Summary:	Konqueror tabs - close tab not shown on hover / Advanced tab setting broken
Product:	TDE	Reporter:	David C. Rankin <trin>
Component:	tdebase	Assignee:	Timothy Pearson <kb9vqf>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugwatch, darrella
Priority:	P5
Version:	3.5.13 [Trinity]
Hardware:	All
OS:	Linux
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Attachments:	Add GUI control for HoverCloseButton option

Description David C. Rankin 2012-03-05 21:01:02 CST

In konqueror web browser, when multiple tabs are displayed, if you hover over the page tab itself the close icon should appear on the tab allowing the user to close the tab with the mouse. This is not working in TDE - confirmed on the trinity-dev list.

Second, the following setting appears broken and has no effect:

konqueror settings -> Web Behavior -> Tabbed Browsing -> Advanced Options -> [ ] show close button instead of website icon

With this option selected, IIRC, konqueror is supposed to display the close icon on each tab instead of the website icon.

Comment 1 Darrell 2012-10-09 15:10:07 CDT

As of 10/9/2012 this is fixed in R14. There is no problem in 3.5.13 either (I did not test 3.5.13.1.).

Although the Advanced "Show close button..." option was broken at one time in R14, possibly the reason for the hover feature not working was a missing konquerorrc HoverCloseButton config option.

To enable that feature use kwriteconfig or directly edit the user's konquerorrc:

HoverCloseButton=true
PermanentCloseButton=false (GUI control in Advanced)

The HoverCloseButton option has no effect when PermanentCloseButton=true 

There is no GUI control to set HoverCloseButton. If a GUI control is added, the check box should be a child of the "Show close button..." check box and would be disabled when the "Show close button..." is enabled.

Further, the logic used in the code seems to never create or change the HoverCloseButton option.

One solution might be to change the default HoverCloseButton in konqueror.kcfg from false to true, but adding the GUI check box seems the best all-around solution. That way the user becomes aware of the option rather than being a "hidden" feature, which is a euphemism for "too lazy to add a GUI control."

Please keep the report open as a mechanism for adding a GUI control.

Comment 2 Darrell 2012-10-09 19:53:19 CDT

Created attachment 859 [details]
Add GUI control for HoverCloseButton option

This patch provides a check box GUI control for the konquerorrc HoverCloseButton configuration option. The new check box is dependent upon the parent "Show close button instead of website icon" check box. When the parent check box is enabled the new check box is disabled and vice-versa.

The patch works for me on a Slackware 13.1 system.

This bug report may be closed as resolved after somebody successfully tests the patch and the patch is pushed to GIT.

Comment 3 Darrell 2013-03-02 21:03:01 CST

Patch in attachment 859 [details] pushed in GIT commit c84d841e. Resolved.