| Summary: | Konqueror: Add check box to control mouse wheel cycling over tab bar | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Darrell <darrella> |
| Component: | tdebase | Assignee: | Michele Calgaro <michele.calgaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugwatch, darrella, michele.calgaro, slavek.banko |
| Priority: | P1 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | Konqueror | |
| Attachments: |
Partial patch to provide GUI control for tab cycling
tdebase patch for konqueror tab mouse wheel scroll support |
||
I was looking into bug 909 and 910. Basically the wheel scroll action is built into KDEUI and it is hard coded. relevant files are: tdelibs/tdeui/ktabbar.cpp tdelibs/tdeui/ktabwidget.cpp What is a solution, a global configuration option? or can we intercept/disconnect/handle the signal so it doesn't go to ktabbar? Add a configuration option. Konqueror: Settings, Web Behavior, Advanced (Yet Another Advanced dialog that should be merged into the parent dialog), Text: "&Cycle through tabs with mouse wheel" (Consistent text with taskbar patch.) Created attachment 857 [details]
Partial patch to provide GUI control for tab cycling
This is a partial attempt at providing a GUI control for tab cycling. The new check box control is located in the Web Behavior Tabbed Browsing section and correctly updates/toggles the user's konquerorrc file.
The patch does not yet control over tab cycling. Somehow the new konquerorrc key must be tied to the ActivateNextTab and ActivatePrevTab features.
Patch in attachment 857 [details] pushed in GIT commit 2b96a180. The patch only provides the GUI check box control and does not control tab cycling.
After bug 909 I will also look into this, which should be quite straight forward by then. Created attachment 1554 [details] tdebase patch for konqueror tab mouse wheel scroll support To apply this patch you first need to apply at least the tdelibs part of the patch for bug 909. This patch does the following things: 1) rearranges the 'Web behavior -> Tabbed browsing' options, centralizing all options inside the advancedTabDialog dialog. Beside having all the options together in one place, it reduces the height required to display the 'Web behavior' setting window. Before, such height was bigger that 768 pixel and prevented the setting window to be fully displayed within any 1366x768 monitor. 2) completes the support in Konqueror for the tab scroll using mouse wheel. The option is located in 'Web behavior -> Tabbed browsing -> Show tab options -> Cycle tabs with mouse wheel' 3) allows the option 'Web behavior -> Tabbed browsing -> Show tab options -> Hide the tab bar when only one tab is open' to be changed and applied at runtime, without the need to restart Konqueror or reload the view profile Changed status to PATCHAVAIL. Would anyone let me know the following things please? 1) is P1 high priority and P5 low priority or is it the opposite? 2) am I doing something wrong, of when adding an attachment it is not possible to change the bug status at the same time? I am just wondering... > 1) is P1 high priority and P5 low priority or is it the opposite? I always presumed P1 was the highest. Then again, I believe the default is P5. Calvin or Tim maintain the bugzilla and would know. > 2) am I doing something wrong, of when adding an attachment it is not possible to change the bug status at the same time? I always had the same problem. I don't know whether the problem is the bugzilla version, a bugzilla config option, or PEBKAC. I'm rebuilding tdebase to test the patch.... The patch works great! One comment: Buried somewhere deep in a past IRC or developer list conversation, or in an etherpad, is a goal to remove all "Advanced" buttons in configuration dialogs. The changes made in the patch fall nicely into that goal. Rather than a new dialog button named "Show tab options," would you be able to move all options in the child dialog directly into the parent dialog "Tabbed Browsing" group box? Yes, the change might make the Web Behavior dialog a tad large. (In reply to comment #9) > The patch works great! > > One comment: > > Buried somewhere deep in a past IRC or developer list conversation, or in an > etherpad, is a goal to remove all "Advanced" buttons in configuration dialogs. > The changes made in the patch fall nicely into that goal. > > Rather than a new dialog button named "Show tab options," would you be able to > move all options in the child dialog directly into the parent dialog "Tabbed > Browsing" group box? > > Yes, the change might make the Web Behavior dialog a tad large. Hi Darrell, thanks for the information about priority, I also assumed the same. Moving all "Tabbed Browsing" options to the "Web behavior" page would make "Web behavior" really huge. I would rather create an additional category on the left side called "Tabbed browsing" and move all options there. In this way we avoid making "Web behavior" a big beast. Perhaps Tim or Slavek can share their opinion with us. I am not a big fan of "Advanced options" buttons either and I actually thought about creating that "Tabbed browsing" category for this patch while working on it. But in the end I thought it would be better to do things one step at a time. This patch adds support for the mouse wheel scrolling and I think it would be better to push this patch to GIT as it is at the moment. After that, I can open a new bug report for moving the "Tabbed Browsing" options to a new category in the parent window. What do you think? >This patch adds support for the mouse wheel scrolling and I think it would be >better to push this patch to GIT as it is at the moment. >After that, I can open a new bug report for moving the "Tabbed Browsing" >options to a new category in the parent window. >What do you think? Sounds fine to me. :-) We'll wait for Slavek to test the patch on his system before pushing to GIT. If you want, you can open a new bug report now. I will not add the report to the R14 etherpad list. We can use a generic bug report to affect all instances of removing "Advanced" buttons and other related child dialogs. We have several such bug reports now that serve as a focal point for similarly related bugs. For example, bug report 1560. I will try to find the original conversations about this topic. Possibly we might have already created a starter list of such instances. (In reply to comment #12) > If you want, you can open a new bug report now. Bug 1683 opened Pushed to GIT in hash 36ba7f5. Moving gui configuration for tabbed browsing to a separate settings tab will be solved in a separate bug 1683. Thank you for your good work! |
Currently there is no option to control mouse wheel cycling when the mouse pointer hovers over the tab bar. Although useful for many people, the cycling feature is frustrating for others. In bug report 251 a patch was submitted to add a check box control for task bar application cycling. That patch can be used as a template to add the same control option. ("Cycle through tabs with mouse wheel")